diff options
| -rw-r--r-- | middleware/backend.go | 4 | ||||
| -rw-r--r-- | middleware/kubernetes/kubernetes.go | 13 | ||||
| -rw-r--r-- | middleware/kubernetes/lookup.go | 2 |
3 files changed, 14 insertions, 5 deletions
diff --git a/middleware/backend.go b/middleware/backend.go index e1c6e9496..3ce7ab5fd 100644 --- a/middleware/backend.go +++ b/middleware/backend.go @@ -25,6 +25,10 @@ type ServiceBackend interface { // Debug returns a string used when returning debug services. Debug() string + + // Returns _all_ services that matches a certain name. + // Note: it does not implement a specific service. + Records(name string, exact bool) ([]msg.Service, error) } // Options are extra options that can be specified for a lookup. diff --git a/middleware/kubernetes/kubernetes.go b/middleware/kubernetes/kubernetes.go index a1e6bdb73..13f92adca 100644 --- a/middleware/kubernetes/kubernetes.go +++ b/middleware/kubernetes/kubernetes.go @@ -124,10 +124,10 @@ func (k *Kubernetes) Services(state request.Request, exact bool, opt middleware. svcs = append(svcs, k.defaultNSMsg(r)) return svcs, nil, nil } - s, e := k.Records(r) + s, e := k.Entries(r) return s, nil, e // Haven't implemented debug queries yet. case "SRV": - s, e := k.Records(r) + s, e := k.Entries(r) // SRV for external services is not yet implemented, so remove those records noext := []msg.Service{} for _, svc := range s { @@ -347,10 +347,15 @@ func (k *Kubernetes) parseRequest(lowerCasedName string, qtype uint16) (r record } -// Records looks up services in kubernetes. If exact is true, it will lookup +// Records not implemented, see Entries(). +func (k *Kubernetes) Records(name string, exact bool) ([]msg.Service, error) { + return nil, fmt.Errorf("NOOP") +} + +// Entries looks up services in kubernetes. If exact is true, it will lookup // just this name. This is used when find matches when completing SRV lookups // for instance. -func (k *Kubernetes) Records(r recordRequest) ([]msg.Service, error) { +func (k *Kubernetes) Entries(r recordRequest) ([]msg.Service, error) { // Abort if the namespace does not contain a wildcard, and namespace is not published per CoreFile // Case where namespace contains a wildcard is handled in Get(...) method. diff --git a/middleware/kubernetes/lookup.go b/middleware/kubernetes/lookup.go index e47b6e8c6..3eae6ba5e 100644 --- a/middleware/kubernetes/lookup.go +++ b/middleware/kubernetes/lookup.go @@ -16,7 +16,7 @@ func (k Kubernetes) records(state request.Request, exact bool) ([]msg.Service, e if err != nil { return nil, err } - services, err := k.Records(r) + services, err := k.Entries(r) if err != nil { return nil, err } |