aboutsummaryrefslogtreecommitdiff
path: root/plugin/trace (follow)
AgeCommit message (Collapse)AuthorFilesLines
2021-07-20auto remove trailing whitespacesGravatar coredns[bot] 1-1/+1
Signed-off-by: coredns[bot] <bot@bot.coredns.io>
2021-07-19auto go fmtGravatar coredns[bot] 1-3/+3
Signed-off-by: coredns[bot] <bot@bot.coredns.io>
2021-07-14publish trace id as metadata from trace plugin (#4749)Gravatar Ondřej Benkovský 2-0/+17
Signed-off-by: Ondrej Benkovsky <ondrej.benkovsky@wandera.com>
2021-07-10plugin/trace: fix rcode tag in case of no response (#4742)Gravatar Ondřej Benkovský 2-8/+25
Signed-off-by: Ondrej Benkovsky <ondrej.benkovsky@wandera.com>
2021-07-05auto go fmtGravatar coredns[bot] 1-1/+1
Signed-off-by: coredns[bot] <bot@bot.coredns.io>
2021-06-29trace plugin can mark traces with error tag (#4720)Gravatar Ondřej Benkovský 2-1/+21
Signed-off-by: Ondrej Benkovsky <ondrej.benkovsky@wandera.com>
2021-01-28plugin/trace - Use compatible tag name for datadog (#4408)Gravatar Bob 2-21/+51
Traces are currently working properly with datadog with the exception of having the ability to facet the tags ![image](https://user-images.githubusercontent.com/5513509/105051238-dddbbd00-5a6e-11eb-8fb2-071b3b1fa8cc.png) In order to get valuable graph in dashboard the tag on the metrics need to be faceted by datadog. This PR update the tags with facetable path. While keeping backward compatibility with existing path for zipkin. Graph like: ![image](https://user-images.githubusercontent.com/5513509/93375960-339e1f80-f859-11ea-81f0-a1074c375630.png) ![image](https://user-images.githubusercontent.com/5513509/93375997-4153a500-f859-11ea-9f8d-63d45217c681.png) ![image](https://user-images.githubusercontent.com/5513509/93376064-5597a200-f859-11ea-823a-6768f59e3497.png) ![image](https://user-images.githubusercontent.com/5513509/93376405-d6ef3480-f859-11ea-8d6f-58dda247cc86.png) ![image](https://user-images.githubusercontent.com/5513509/93376518-069e3c80-f85a-11ea-9a7e-0426a3817439.png) Signed-off-by: bob <bob.bouteillier@datadoghq.com>
2020-12-11Update README.md (#4331)Gravatar Chotiwat Chawannakul 1-1/+1
Automatically submitted.
2020-11-19plugin/trace: cleanup README.md (#4280)Gravatar Miek Gieben 1-11/+7
Various improvements to the documentation. Started because `:warning:` isn't a markdown feature (replace with Note:). Signed-off-by: Miek Gieben <miek@miek.nl>
2020-11-11auto go fmtGravatar coredns-auto-go-fmt[bot] 1-2/+2
2020-11-10plugin/trace: Fix zipkin json_v2 (#4180)Gravatar Bob 4-9/+17
Automatically submitted.
2020-10-28docs: move Also See to See Also (#4245)Gravatar Miek Gieben 1-1/+1
sed -i 's/Also See/See Also/' plugin/**/README.md Some plugins did already use 'See Also', so it's all consistent now. Fixes: #4196 Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-12[plugin][trace] - Have a consistent spanName (#4171)Gravatar Bob 5-27/+61
Automatically submitted.
2020-09-29Add proto and remote tags to trace plugin (#4159)Gravatar Miek Gieben 2-3/+13
* Add proto and client-ip trace tags Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com> * Commit my own suggestion Signed-off-by: Miek Gieben <miek@miek.nl> Co-authored-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
2020-09-24For caddy v1 in our org (#4018)Gravatar Miek Gieben 3-4/+3
* For caddy v1 in our org This RP changes all imports for caddyserver/caddy to coredns/caddy. This is the v1 code of caddy. For the coredns/caddy repo the following changes have been made: * anything not needed by us is deleted * all `telemetry` stuff is deleted * all its import paths are also changed to point to coredns/caddy * the v1 branch has been moved to the master branch * a v1.1.0 tag has been added to signal the latest release Signed-off-by: Miek Gieben <miek@miek.nl> * Fix imports Signed-off-by: Miek Gieben <miek@miek.nl> * Group coredns/caddy with out plugins Signed-off-by: Miek Gieben <miek@miek.nl> * remove this file Signed-off-by: Miek Gieben <miek@miek.nl> * Relax import ordering github.com/coredns is now also a coredns dep, this makes github.com/coredns/caddy fit more natural in the list. Signed-off-by: Miek Gieben <miek@miek.nl> * Fix final import Signed-off-by: Miek Gieben <miek@miek.nl>
2020-09-16bump prometheus with zipkin (#4109)Gravatar Zou Nengren 1-8/+11
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-09-09plugin/trace: fix struct allignment (#4112)Gravatar Miek Gieben 1-1/+2
* plugin/trace: fix struct allignment A 64 bit entity needs to be the first in a struct to make it work on 32 bit systems. Fixes: #4111 Signed-off-by: Miek Gieben <miek@miek.nl> * plugin/erratic does makes the same mistake Signed-off-by: Miek Gieben <miek@miek.nl>
2020-07-23Disable debug mode for tracing - removes extra logging (#4016)Gravatar Oleg Atamanenko 2-1/+7
Signed-off-by: Oleg Atamanenko <oleg.atamanenko@gmail.com>
2020-01-30presubmit: check import path ordering (#3636)Gravatar Miek Gieben 1-5/+3
Add a test for this as well as it's annoying to point out in every code review. Fix all the import paths that are flagged by this new test. Fixes: #3634 Signed-off-by: Miek Gieben <miek@miek.nl>
2019-11-29Move to CODEOWNERS (#3489)Gravatar Miek Gieben 1-4/+0
* Move to CODEOWNERS No change in who own what; just a move to CODEOWNERS. This allows dreck cleanups. Added .dreck.yaml for alias and exec. Fixes: #3486 Signed-off-by: Miek Gieben <miek@miek.nl> * stickler bot Signed-off-by: Miek Gieben <miek@miek.nl> * sort the file Signed-off-by: Miek Gieben <miek@miek.nl>
2019-10-01Run gostaticheck (#3325)Gravatar Miek Gieben 1-2/+0
* Run gostaticheck Run gostaticcheck on the codebase and fix almost all flagged items. Only keep * coremain/run.go:192:2: var appVersion is unused (U1000) * plugin/chaos/setup.go:54:3: the surrounding loop is unconditionally terminated (SA4004) * plugin/etcd/setup.go:103:3: the surrounding loop is unconditionally terminated (SA4004) * plugin/pkg/replacer/replacer.go:274:13: argument should be pointer-like to avoid allocations (SA6002) * plugin/route53/setup.go:124:28: session.New is deprecated: Use NewSession functions to create sessions instead. NewSession has the same functionality as New except an error can be returned when the func is called instead of waiting to receive an error until a request is made. (SA1019) * test/grpc_test.go:25:69: grpc.WithTimeout is deprecated: use DialContext and context.WithTimeout instead. Will be supported throughout 1.x. (SA1019) The first one isn't true, as this is set via ldflags. The rest is minor. The deprecation should be fixed at some point; I'll file some issues. Signed-off-by: Miek Gieben <miek@miek.nl> * Make sure to plug in the plugins import the plugins, that file that did this was removed, put it in the reload test as this requires an almost complete coredns server. Signed-off-by: Miek Gieben <miek@miek.nl>
2019-09-20all: simply registering plugins (#3287)Gravatar Miek Gieben 1-6/+1
Abstract the caddy call and make it simpler. See #3261 for some part of the discussion. Go from: ~~~ go func init() { caddy.RegisterPlugin("any", caddy.Plugin{ ServerType: "dns", Action: setup, }) } ~~~ To: ~~~ go func init() { plugin.Register("any", setup) } ~~~ This requires some external documents in coredns.io to be updated as well; the old way still works, so it's backwards compatible. Signed-off-by: Miek Gieben <miek@miek.nl>
2019-07-31Move github.com/openzipkin/zipkin-go-opentracing => ↵Gravatar Yong Tang 1-1/+1
github.com/openzipkin-contrib/zipkin-go-opentracing (#3070) Move github.com/openzipkin/zipkin-go-opentracing => github.com/openzipkin-contrib/zipkin-go-opentracing and run `go mod tidy` Fixes 3069 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-07-03Update Caddy to 1.0.1, and update import path (#2961)Gravatar Yong Tang 3-3/+3
* Update Caddy to 1.0.1, and update import path This fix updates caddy to 1.0.1 and also updates the import path to github.com/caddyserver/caddy This fix fixes 2959 Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Also update plugin.cfg Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update and bump zplugin.go Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-06-10Follow up on PR 2868 (#2877)Gravatar Yong Tang 1-6/+2
This fix is a follow up on comment https://github.com/coredns/coredns/pull/2868#discussion_r291609761 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-06-09Fix Datadog tracer (#2868)Gravatar Anshul Sharma 1-16/+6
- Fixes #2862
2019-03-25Remove server addr from the context (#2722)Gravatar Miek Gieben 1-2/+1
* more Signed-off-by: Miek Gieben <miek@miek.nl> * Remove server addr from the context This was added twice, just leave the server which also holds the address. Conflicts with #2719 but should be easy to fix. Signed-off-by: Miek Gieben <miek@miek.nl> * doesn't need server context Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-12plugin/trace: update datadog import (#2676)Gravatar Miek Gieben 1-1/+1
Use gopkg.in/DataDog/dd-trace-go.v0 as this is the new home for it Fixes: #2282 Signed-off-by: Miek Gieben <miek@miek.nl>
2018-10-05Add request and response context to traces (#2162)Gravatar Nic Cope 2-13/+104
Automatically submitted.
2018-07-19Clean up tests logging (#1979)Gravatar Miek Gieben 1-0/+5
* Clean up tests logging This cleans up the travis logs so you can see the failures better. Older tests in tests/ would call log.SetOutput(ioutil.Discard) in a haphazard way. This add log.Discard and put an `init` function in each package's dir (no way to do this globally). The cleanup in tests/ is clear. All plugins also got this init function to have some uniformity and kill any (future) logging there in the tests as well. There is a one-off in pkg/healthcheck because that does log. Signed-off-by: Miek Gieben <miek@miek.nl> * bring back original log_test.go Signed-off-by: Miek Gieben <miek@miek.nl> * suppress logging here as well Signed-off-by: Miek Gieben <miek@miek.nl>
2018-04-25core: remove HostAddresses() (#1728)Gravatar Miek Gieben 2-7/+7
* core: remove HostAddresses() config.HostAddresses() is a weird function that gathers some data from the server and returns a string. It is *only* used the trace plugin, to figure out what server starts the trace. Looks to be better to fit in the with metrics.WithServer label on the trace itself to show which server handled the trace. Remove HostAddresses() and cleanup trace a small bit.:w * lint
2018-04-22all: fix plugin import ordering (#1717)Gravatar Miek Gieben 1-2/+1
Got a bit messed up with stb lib "context" usage.
2018-04-20global: move to context (#1699)Gravatar Miek Gieben 1-1/+2
* global: move to context Move from golang.org/x/net/context to std lib's context. Change done with: for i in $(grep -l '/context' **/*.go); do sed -e 's|golang.org/x/net/context|context|' -i $i; echo $i; done for i in **/*.go; do goimports -w $i; done * drop from dns.pb.go as well
2018-03-09Add DD support (#1596)Gravatar Yamil Asusta 4-15/+52
2018-02-14Plugin/BIND - extend the syntax to allow multiple addresses (#1512)Gravatar Francois Tur 1-1/+1
* Extend bind to allow multiple addresses. UTs added. Changes the log for server starting, adding address when available * update readme for bind * fixes after review * minor fix on readme * accept multiple BIND directives in blocserver, consolidate the addresses * fixes after review - format logging server address, variable names
2018-02-08Add OWNERS file (#1486)Gravatar Miek Gieben 1-0/+4
This should have everyone, but the process was quite manual. The rename from middleware -> plugin also meant I had to do some extra digging on who actually submitted the PR. I also double checked the current list of people with commit access. Every plugin now has an OWNERS, except *reverse*. I'll file a bug for that.
2018-01-04Manual pages (#1346)Gravatar Miek Gieben 1-1/+7
* Add manual pages Generate manual pages from the README and extend README with Name and Description sections. The generation requires 'ronn' which may not be available. Just check in all generated manual pages.
2017-09-15plugin: README.md updates (#1084)Gravatar Miek Gieben 1-2/+1
updates so the look better on coredns.io
2017-09-15plugins: expand examples (#1077)Gravatar Miek Gieben 1-2/+4
* plugins: expand examples Expand some examples and test them by annotating it with `corefile` * Can't start kubernetes * Can test pprof :(
2017-09-14Remove the word middleware (#1067)Gravatar Miek Gieben 5-0/+363
* Rename middleware to plugin first pass; mostly used 'sed', few spots where I manually changed text. This still builds a coredns binary. * fmt error * Rename AddMiddleware to AddPlugin * Readd AddMiddleware to remain backwards compat