aboutsummaryrefslogtreecommitdiff
path: root/test (follow)
AgeCommit message (Collapse)AuthorFilesLines
2024-04-26chore: fix function name in comment (#6608)Gravatar kindknow 1-1/+1
Signed-off-by: kindknow <iturf@sina.com>
2023-08-10Fix typos (#6235)Gravatar Zhizhen He 2-5/+5
* Fix typos and add todo to fix spelling of dnsutil.MaximumDefaulTTL Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com>
2023-07-31[RFC-9250]: Add QUIC server support (#6182)Gravatar João Henri 1-0/+165
Add DNS-over-QUIC server Signed-off-by: jaehnri <joao.henri.cr@gmail.com> Signed-off-by: João Henri <joao.henri.cr@gmail.com>
2023-06-17test: use `t.TempDir` to create temporary test directory (#6164)Gravatar Eng Zer Jun 3-26/+6
2023-06-09replace reviewdog fully by golangci-lint (#6139)Gravatar Ondřej Benkovský 1-3/+5
Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
2023-02-15Close the body after reading the response body information (#5907)Gravatar Fish-pro 1-0/+2
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
2022-10-28Fork TLSConfig for each encrypted connection (#5710)Gravatar sanyo0714 1-26/+47
* Fork TLSConfig for each encrypted connection Signed-off-by: sanyo <sanyo0714@163.com> Co-authored-by: sanyo <yeshengan.ysa@alibaba-inc.com>
2022-09-19GO linting bump and removal of deprecated linters (#5624)Gravatar Ondřej Benkovský 1-36/+1
* bump golangci-lint with support of go 1.19 Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com> * remove deprecated usage of varcheck, deadcode, and structcheck Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com> Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
2022-09-08plugin/view: Advanced routing interface and new 'view' plugin (#5538)Gravatar Chris O'Haver 1-0/+163
* introduce new interface "dnsserver.Viewer", that allows a plugin implementing it to decide if a query should be routed into its server block. * add new plugin "view", that uses the new interface to enable a user to define expression based conditions that must be met for a query to be routed to its server block. Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2022-07-18plugin/ready: Reset list of readiness plugins on startup (#5492)Gravatar Chris O'Haver 1-0/+62
* reset readiness plugins list on startup Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2022-07-15Add test for DNS over TLS (#5511)Gravatar Marius Kimmina 1-0/+46
2022-07-10add golangci-lint linter (#5499)Gravatar Ondřej Benkovský 6-6/+2
2022-06-27plugin/tsig: new plugin TSIG (#4957)Gravatar Chris O'Haver 1-0/+166
* expose tsig secrets via dnsserver.Config * add tsig plugin Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2022-03-18update all +build statements (#5271)Gravatar Qasim Sarfraz 4-4/+4
* update all +build statements Signed-off-by: MQasimSarfraz <syed.qasim.sarfraz@gmail.com> * remove old +build style Signed-off-by: MQasimSarfraz <syed.qasim.sarfraz@gmail.com>
2022-02-17Update to use the latest protobuf package to build pb (#5193)Gravatar Yong Tang 1-0/+4
* Update to use the latest protobuf package to build pb The pb package was generated some time ago with old version of https://github.com/golang/protobuf which was deprecated and in favor of google.golang.org/protobuf (see deprecation notice in https://pkg.go.dev/github.com/golang/protobuf) This PR updates the generation of pb package with v1.27.1 of google.golang.org/protobuf. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Exclude pb from import test Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2022-02-01plugin/rewrite: Write failures with ResponseReverter (#5150)Gravatar Chris O'Haver 1-0/+28
* write failures with ResponseReverter instead of letting server write them Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * fix comment Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2021-11-12Metrics: expand coredns_dns_responses_total with plugin label (#4914)Gravatar Miek Gieben 1-12/+13
* Metrics: expand coredns_dns_responses_total with plugin label This adds (somewhat hacky?) code to add a plugin label to the coredns_dns_responses_total metric. It's completely obvlious to the plugin as we just check who called the *recorder.WriteMsg method. We use runtime.Caller( 1 2 3) to get multiple levels of callers, this should be deep enough, but it depends on the dns.ResponseWriter wrapping that's occuring. README.md of metrics updates and test added in test/metrics_test.go to check for the label being set. I went through the plugin to see what metrics could be removed, but actually didn't find any, the plugin push out metrics that make sense. Due to the path fiddling to figure out the plugin name I doubt this works (out-of-the-box) for external plugins, but I haven't tested that. Signed-off-by: Miek Gieben <miek@miek.nl> * better comment Signed-off-by: Miek Gieben <miek@miek.nl> * Metrics: expand coredns_dns_responses_total with plugin label This adds (somewhat hacky?) code to add a plugin label to the coredns_dns_responses_total metric. It's completely obvlious to the plugin as we just check who called the *recorder.WriteMsg method. We use runtime.Caller( 1 2 3) to get multiple levels of callers, this should be deep enough, but it depends on the dns.ResponseWriter wrapping that's occuring. README.md of metrics updates and test added in test/metrics_test.go to check for the label being set. I went through the plugin to see what metrics could be removed, but actually didn't find any, the plugin push out metrics that make sense. Due to the path fiddling to figure out the plugin name I doubt this works (out-of-the-box) for external plugins, but I haven't tested that. Signed-off-by: Miek Gieben <miek@miek.nl> * Update core/dnsserver/server.go Co-authored-by: dilyevsky <ilyevsky@gmail.com> * Use [3]string Signed-off-by: Miek Gieben <miek@miek.nl> * imports Signed-off-by: Miek Gieben <miek@miek.nl> * remove dnstest changes Signed-off-by: Miek Gieben <miek@miek.nl> * revert Signed-off-by: Miek Gieben <miek@miek.nl> * Add some sleeps to make it less flaky Signed-off-by: Miek Gieben <miek@miek.nl> * Revert "Add some sleeps to make it less flaky" This reverts commit b5c6655196e3ad570555f086832ceb1f48f6f2d5. * Remove forward when not needed Signed-off-by: Miek Gieben <miek@miek.nl> * remove newline Signed-off-by: Miek Gieben <miek@miek.nl> Co-authored-by: dilyevsky <ilyevsky@gmail.com>
2021-10-13cleanup deprecated package io/ioutil (#4920)Gravatar Zou Nengren 7-24/+19
Signed-off-by: zounengren <zouyee1989@gmail.com>
2021-09-14plugin/file/auto: Write CNAME answer to client even if target lookup is ↵Gravatar Chris O'Haver 1-0/+7
SERVFAIL (#4863) * write cname answer to client even if target lookup is servfail Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * fix existing unit test expectations Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2021-07-14deflake TestMultiZoneBlockConfigs (#4751)Gravatar Miek Gieben 1-5/+25
Deflake by retrying and adding random port numbers. We try 3 times to get an instance. Also fix a bug where server.Stop() was called even if the server creation failed - this was never hit due to t.Fatal() above it, but fix that nontheless. Signed-off-by: Miek Gieben <miek@miek.nl>
2021-07-09Share plugins among zones in the same server block (#4593)Gravatar Chris O'Haver 1-0/+31
* share plugins among zones in the same server block Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * update caddy dep Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * simp code Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * copy ListenHosts and Debug from first config Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * copy tls configs from first config Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * add test to validate debug setting is replicated to all configs in block Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * stop server Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2021-06-10plugin/secondary: Retry initial transfer until successful (#4663)Gravatar Chris O'Haver 1-0/+84
* retry initial transfer Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * fix import grouping Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * add test; use backoff timeout Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * fix import order Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * manual backoff Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2021-05-19Fix obsure crash in Corefile parsing (#4637)Gravatar Miek Gieben 1-0/+17
This was found by fuzzing. We need to make this a fully qualified domain name to catch all errors in dnsserver/register.go and not later when plugin.Normalize() is called again on these strings, with the prime difference being that the domain name is fully qualified. This was found by fuzzing where "ȶ" is deemed OK, but "ȶ." is not (might be a bug in miekg/dns actually). But here we were checking ȶ, which is OK, and later we barf in ȶ. leading to "index out of range". Added a tests and check manually if it would crash with the current code (yes), and fail with an error in this PR (yes). Signed-off-by: Miek Gieben <miek@miek.nl>
2021-05-14Fix etcd to use v3.5.0-alpha.0 (#4628)Gravatar Jason Du 1-1/+1
Signed-off-by: Jason Du <xdu@infoblox.com>
2021-05-11reverse zones (#4538)Gravatar Miek Gieben 1-0/+54
* core: fix v4 non-octet reverse zones This fixes the reverse zones handling. Add expanstion of the reverse notation to all octet boundary subnets and add those to the config - just as if they were directly typed in the config. This takes inspiration from #4501, but that (even with DCO!!) seems to be just using https://github.com/apparentlymart/go-cidr/ so use that instead - I think a minor function is still needed that one is copied from #4501. Also sort the zones we are listing on startup - caught in this PR because of the expanded zones being not listed next to each other. This also removes the need for FilterFunc from the config, so this is now gone as well, making the whole thing slightly more efficient. Add couple of reverse unit tests and a e2e test that queries for the correct (and incorrect) reverse zones and checks the reply. Closes: #4501 Fixes: #2779 Signed-off-by: Miek Gieben <miek@miek.nl> * Add more test cases Add test from origin bug report: #2779 Signed-off-by: Miek Gieben <miek@miek.nl> * Rebase and fix conflicts Signed-off-by: Miek Gieben <miek@miek.nl>
2021-05-11test: Fix rare race condition in TestZoneReload (#4617)Gravatar Steve Greene 1-2/+2
The following test failure for `TestZoneReload` can be observed periodically: `file_reload_test.go:58: Expected two RR in answer section got 2` This failure can be consistently reproduced using the following command (on my machine, at least): `( cd test ; go test -v -race -run "TestZoneReload" ./... -count=500)` test/file_reload_test.go: Address a typo in a test failure message. Sleep for double the file reload interval to avoid a rare race condition between test code and the file plugin's reload code, which is presumably a result of the time it takes to actually reload. Signed-off-by: Stephen Greene <sgreene@redhat.com>
2021-02-05plugin/transfer: only allow outgoing axfr over tcp (#4452)Gravatar Miek Gieben 1-2/+4
* plugin/transfer: only allow outgoing axfr over tcp Return refused when the query comes in over udp. No need to add a new test case as the current crop needed to be changed to use TCP. Fixes: #4450 Signed-off-by: Miek Gieben <miek@miek.nl> * transfer tests: this needs tcp as well Signed-off-by: Miek Gieben <miek@miek.nl>
2021-01-24Fix import ordering presubmit test (#4422)Gravatar Miek Gieben 1-1/+1
Automatically submitted.
2021-01-15plugin/file: guard against cname loops (#4387)Gravatar Miek Gieben 1-0/+49
Automatically submitted.
2020-12-11Remove unneeded test/go-test-tmpfile565156097 (#4330)Gravatar Yong Tang 1-19/+0
This PR removes test/go-test-tmpfile565156097 from commit 6bbb48d. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-12-09plugin/file: Use NXDOMAIN response if CNAME target is NXDOMAIN (#4303)Gravatar Chris O'Haver 2-0/+126
* pass through nxdomain results Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * return srvfail and nodata results Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * add test Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * cover more response cases Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-11-11Remove newlines between braces (#4279)Gravatar Miek Gieben 2-2/+0
These are found with: `pcregrep -M "}\n\n}" **/*.go` Sometimes a unneeded newline is inserted, remove those. Signed-off-by: Miek Gieben <miek@miek.nl>
2020-11-11auto test: increase sleep (#4282)Gravatar Miek Gieben 1-2/+2
Doing a reload every 10ms and sleeping 10ms makes this too racy, increase all those sleeps to 5ms. A better method would be to get notified of the reload/change, this would require some polling to get the RR we expect, with a much longer timeout to stop the test eventually. Signed-off-by: Miek Gieben <miek@miek.nl>
2020-11-07Setup GitHub Actions for auto remove trailing whitespaces (#4269)Gravatar Yong Tang 1-62/+0
* Setup GitHub Actions for auto remove trailing whitespaces This PR setup GitHub Actions for auto remove trailing whitespaces, if any non-go files are touched (.git directory are ignored) Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Remove TestTrailingWhitespace in presubmit tests Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * paths and paths-ignore are mutually exlcusive so only keep paths-ignore Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Remove redundent bufio import Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-11-06Remove travis and move to github workflow (#4267)Gravatar Miek Gieben 2-1/+20
Add github testing workflow, simplify the Makefile because that was complex because of Travis. Remove the fuzzing, needs to be re-added when that works properly with go modules (it has been disabled for quite some time). Multiple builds and files have been added so these tests can all run in parallel. Our testing now tests a couple of minutes, the codeql is by far the more expensive. Move metric's naming test to test/presubmit_test.go Add longer sleep in the TestAutoAXFR. Bye bye travis! Closes: #4266 Signed-off-by: Miek Gieben <miek@miek.nl>
2020-11-05Add check for Also See for READMEs (#4261)Gravatar Miek Gieben 1-0/+4
Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-30Speed up testing (#4239)Gravatar Miek Gieben 5-14/+14
* Speed up testing * make notification run in the background, this recudes the test_readme time from 18s to 0.10s * reduce time for zone reload * TestServeDNSConcurrent remove entirely. This took a whopping 58s for ... ? A few minutes staring didn't reveal wth it is actually testing. Making values smaller revealed race conditions in the tests. Remove entirely. * Move many interval values to variables so we can reset them to short values for the tests. * test_large_axfr: make the zone smaller. The number used 64K has no rational, make it 64/10 to speed up. * TestProxyThreeWay: use client with shorter timeout A few random tidbits in other tests. Total time saved: 177s (almost 3m) - which makes it worthwhile again to run the test locally: this branch: ~~~ ok github.com/coredns/coredns/test 10.437s cd plugin; time go t ./... 5,51s user 7,51s system 11,15s elapsed 744%CPU ( ~~~ master: ~~~ ok github.com/coredns/coredns/test 35.252s cd plugin; time go t ./... 157,64s user 15,39s system 50,05s elapsed 345%CPU () ~~~ tests/ -25s plugins/ -40s This brings the total on 20s, and another 10s can be saved by fixing dnstapio. Moving this to 5s would be even better, but 10s is also nice. Signed-off-by: Miek Gieben <miek@miek.nl> * Also 0.01 Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-15cache: do the msg copy right (#4207)Gravatar Miek Gieben 1-0/+45
Not sure why this is proving so difficult.. pointers are hard? [Was tempted to rollback all tweaks here, but the original issue we're fixing it too important to not have a proper fix]. But we need to make a copy of the message at the earliest point in the handler because we are changing it (adding an opt rr). If we do this on the original message (which is a pointer) we change it (obvs). When undoing those changes we do work on a copy. Re: testing. There isn't a explicit test for this, so I've added on to the top-level test/ directory, which indeed makes the issue visible: master: ~~~ go test -v -run=TestLookupCacheWithoutEdns === RUN TestLookupCacheWithoutEdns cache_test.go:154: Expected no OPT RR, but got: ;; OPT PSEUDOSECTION: ; EDNS: version 0; flags: do; udp: 2048 --- FAIL: TestLookupCacheWithoutEdns (0.01s) FAIL ~~~ This branch: ~~~ % go test -v -run=TestLookupCacheWithoutEdns === RUN TestLookupCacheWithoutEdns --- PASS: TestLookupCacheWithoutEdns (0.01s) PASS ok github.com/coredns/coredns/test 0.109s ~~~ Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-15reduce sleeps (#4205)Gravatar Miek Gieben 4-12/+11
This reduces the amount of sleep time to speed up testing. master: PASS ok github.com/coredns/coredns/test 42.088s 12,33s user 1,30s system 44,29s elapsed 30%CPU () this branch: PASS ok github.com/coredns/coredns/test 33.527s Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-07core: fix crash with no plugins (#4184)Gravatar Miek Gieben 2-1/+29
* core: fix crash with no plugins A Corefile that defines a zone without plugins crashes coredns with the stack trace below. Change this to return a refused. ~~~ corefile example.org { whoami log cache debug } example.net { } ~~~ Asking for anyhing in example.net does this. Add test that tests this. ~~~ panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa5e6a4] goroutine 55 [running]: github.com/coredns/coredns/core/dnsserver.(*Server).ServeDNS(0xc000438f60, 0x2059420, 0xc0005a4030, 0x206c0e0, 0xc000522140, 0xc0005ae000) /home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:247 +0x884 github.com/coredns/coredns/core/dnsserver.(*Server).ServePacket.func1(0x206dd00, 0xc00009e180, 0xc0005ae000) /home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:126 +0xaf github.com/miekg/dns.HandlerFunc.ServeDNS(0xc000529270, 0x206dd00, 0xc00009e180, 0xc0005ae000) /home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:37 +0x44 github.com/miekg/dns.(*Server).serveDNS(0xc000286c60, 0xc000282400, 0x34, 0x200, 0xc00009e180) /home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:609 +0x2f7 github.com/miekg/dns.(*Server).serveUDPPacket(0xc000286c60, 0xc0003b03b4, 0xc000282400, 0x34, 0x200, 0xc00000e320, 0xc000522080) /home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:549 +0xb2 created by github.com/miekg/dns.(*Server).serveUDP /home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:479 +0x292 ~~~ Also fix single typo in chaos_test.go Signed-off-by: Miek Gieben <miek@miek.nl> * Fix naming Signed-off-by: Miek Gieben <miek@miek.nl>
2020-09-28plugin/cache: Fix filtering (#4148)Gravatar Miek Gieben 1-1/+46
The filtering of DNSSEC records in the cache plugin was not done correctly. Also the change to introduced this bug didn't take into account that the cache - by virtue of differentiating between DNSSEC and no-DNSSEC - relied on not copying the data from the cache. This change copies and then filters the data and factors the filtering into a function that is used in two places (albeit with on ugly boolean parameters to prevent copying things twice). Add tests, do_test.go is moved to test/cache_test.go because the OPT handing is done outside of the cache plugin. The core server re-attaches the correct OPT when replying, so that makes for a better e2e test. Added small unit test for filterRRslice and an explicit test that asks for DNSSEC first and then plain, and vice versa to test cache behavior. Fixes: #4146 Signed-off-by: Miek Gieben <miek@miek.nl>
2020-09-24Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142)Gravatar Yong Tang 4-14/+15
* Implement notifies for transfer plugin (#3972) * Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * really fix test Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * Add transfer tests copied and modified from #3452 Signed-off-by: Miek Gieben <miek@miek.nl> * Test correct selection of plugin Signed-off-by: Miek Gieben <miek@miek.nl> * add upstream back in Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * fix test Signed-off-by: Miek Gieben <miek@miek.nl> * properly merge Signed-off-by: Miek Gieben <miek@miek.nl> * Remove plugin/kubernetes/setup_transfer_test.go Signed-off-by: Yong Tang <yong.tang.github@outlook.com> Co-authored-by: Miek Gieben <miek@miek.nl>
2020-09-24For caddy v1 in our org (#4018)Gravatar Miek Gieben 4-7/+5
* For caddy v1 in our org This RP changes all imports for caddyserver/caddy to coredns/caddy. This is the v1 code of caddy. For the coredns/caddy repo the following changes have been made: * anything not needed by us is deleted * all `telemetry` stuff is deleted * all its import paths are also changed to point to coredns/caddy * the v1 branch has been moved to the master branch * a v1.1.0 tag has been added to signal the latest release Signed-off-by: Miek Gieben <miek@miek.nl> * Fix imports Signed-off-by: Miek Gieben <miek@miek.nl> * Group coredns/caddy with out plugins Signed-off-by: Miek Gieben <miek@miek.nl> * remove this file Signed-off-by: Miek Gieben <miek@miek.nl> * Relax import ordering github.com/coredns is now also a coredns dep, this makes github.com/coredns/caddy fit more natural in the list. Signed-off-by: Miek Gieben <miek@miek.nl> * Fix final import Signed-off-by: Miek Gieben <miek@miek.nl>
2020-08-20cleanup tempfiles for erratic_autopath_test (#4080)Gravatar Zhou Hao 1-1/+1
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
2020-07-21ignore vendor when presubmit test (#3999)Gravatar Zou Nengren 1-0/+15
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-07-21fix metric naming test (#4017)Gravatar Ben Ye 1-23/+16
Signed-off-by: Ben Ye <yb532204897@gmail.com>
2020-07-08Revert "Implement notifies for transfer plugin (#3972)" (#3995)Gravatar Yong Tang 4-15/+14
This reverts commit 68f1dd5ddf0451cc3a1b24a72c2965b8d896ffba. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-07-07Implement notifies for transfer plugin (#3972)Gravatar Miek Gieben 4-14/+15
* Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * really fix test Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * Add transfer tests copied and modified from #3452 Signed-off-by: Miek Gieben <miek@miek.nl> * Test correct selection of plugin Signed-off-by: Miek Gieben <miek@miek.nl> * add upstream back in Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * fix test Signed-off-by: Miek Gieben <miek@miek.nl> * properly merge Signed-off-by: Miek Gieben <miek@miek.nl>
2020-07-02Cleanup tempfiles (#3986)Gravatar Li Zhijian 2-0/+4
* cleanup tempfiles for auto_test Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com> * cleanup tempfiles for metrics_test Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
2020-04-25Fix mixed indentation within tests (#3855)Gravatar Ambrose Chua 31-307/+286
Signed-off-by: Ambrose Chua <ambrose@chua.family>