From c84df38ac59b0448e15cf85306e7ec10cd7ab155 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sat, 5 Aug 2017 12:29:43 -0700 Subject: middleware/kubernetes: fixes (#837) dedent code, use shorter names. use strings.EqualFold instead ToLower to avoid create garbage. --- middleware/kubernetes/kubernetes_test.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'middleware/kubernetes/kubernetes_test.go') diff --git a/middleware/kubernetes/kubernetes_test.go b/middleware/kubernetes/kubernetes_test.go index 3323ff893..268028c1e 100644 --- a/middleware/kubernetes/kubernetes_test.go +++ b/middleware/kubernetes/kubernetes_test.go @@ -78,9 +78,9 @@ func TestIsNameError(t *testing.T) { } func TestSymbolContainsWildcard(t *testing.T) { - var testdataSymbolContainsWildcard = []struct { - Symbol string - ExpectedResult bool + var tests = []struct { + s string + expected bool }{ {"mynamespace", false}, {"*", true}, @@ -90,10 +90,10 @@ func TestSymbolContainsWildcard(t *testing.T) { {"myname*", false}, } - for _, example := range testdataSymbolContainsWildcard { - actualResult := symbolContainsWildcard(example.Symbol) - if actualResult != example.ExpectedResult { - t.Errorf("Expected SymbolContainsWildcard result '%v' for example string='%v'. Instead got result '%v'.", example.ExpectedResult, example.Symbol, actualResult) + for _, te := range tests { + got := wildcard(te.s) + if got != te.expected { + t.Errorf("Expected Wildcard result '%v' for example '%v', got '%v'.", te.expected, te.s, got) } } } -- cgit v1.2.3