From d0d7f4c89abebcfb5783fcf1ea4fe1a2090e9f11 Mon Sep 17 00:00:00 2001 From: Markus Sommer Date: Fri, 4 Aug 2017 15:41:55 +0200 Subject: Kubernetes srv (#823) * Treat absence of port/service in SRV as wildcard Normally, a SRV-request should have the form _._... The k8s peer-finder which is used for bootstrapping by some applications will however query for SRV at .. To compensate for this behaviour, treat the absence of _ and _ as wildcards. * Modified tests with new SRV behaviour Added a testcase for a SRV request without port & service Removed now valid query from invalidSRVQueries * Forgot to run gofmt on test/kubernetes_test.go --- middleware/kubernetes/kubernetes_test.go | 1 - 1 file changed, 1 deletion(-) (limited to 'middleware/kubernetes/kubernetes_test.go') diff --git a/middleware/kubernetes/kubernetes_test.go b/middleware/kubernetes/kubernetes_test.go index c93270cbe..94a3c94ac 100644 --- a/middleware/kubernetes/kubernetes_test.go +++ b/middleware/kubernetes/kubernetes_test.go @@ -227,7 +227,6 @@ func TestParseRequest(t *testing.T) { } invalidSRVQueries := []string{ - "webs.mynamespace.svc.inter.webs.test.", // SRV requests must have port and protocol "_http._pcp.webs.mynamespace.svc.inter.webs.test.", // SRV protocol must be tcp or udp "_http._tcp.ep.webs.ns.svc.inter.webs.test.", // SRV requests cannot have an endpoint "_*._*.webs.mynamespace.svc.inter.webs.test.", // SRV request with invalid wildcards -- cgit v1.2.3