From fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Fri, 16 Feb 2018 09:43:22 +0100 Subject: pkg/typify: empty messages are OtherError (#1531) Messages with nothing in them are considered OtherError, they can not serve any purpose for normal clients (i.e. dyn update or notifies might have a use for them). Also update a test in the cache plugin, so that we explicitaly test for this case. --- plugin/cache/cache.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugin/cache/cache.go') diff --git a/plugin/cache/cache.go b/plugin/cache/cache.go index cb7a10140..2967e1b34 100644 --- a/plugin/cache/cache.go +++ b/plugin/cache/cache.go @@ -171,7 +171,7 @@ func (w *ResponseWriter) set(m *dns.Msg, key int, mt response.Type, duration tim case response.OtherError: // don't cache these default: - log.Printf("[WARNING] Caching called with unknown classification: %d", mt) + log.Printf("[WARNING] Caching called with unknown typification: %d", mt) } } -- cgit v1.2.3