From 725becd134752caead1aa2b2cf3a72d01c13b599 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sat, 19 Jan 2019 11:23:13 +0000 Subject: Stop importing testing in the main binary (#2479) * Stop importing testing in the main binary Stop importing "testing" into the main binary: * test/helpers.go imported it; remote that and change function signature * update all tests that use this Signed-off-by: Miek Gieben * Drop import testing from metrics plugin Signed-off-by: Miek Gieben * more fiddling Signed-off-by: Miek Gieben --- plugin/file/glue_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'plugin/file/glue_test.go') diff --git a/plugin/file/glue_test.go b/plugin/file/glue_test.go index e6f1e027f..eeddc4e33 100644 --- a/plugin/file/glue_test.go +++ b/plugin/file/glue_test.go @@ -46,12 +46,14 @@ func TestLookupGlue(t *testing.T) { rec := dnstest.NewRecorder(&test.ResponseWriter{}) _, err := fm.ServeDNS(ctx, rec, m) if err != nil { - t.Errorf("Expected no error, got %v\n", err) + t.Errorf("Expected no error, got %v", err) return } resp := rec.Msg - test.SortAndCheck(t, resp, tc) + if err := test.SortAndCheck(resp, tc); err != nil { + t.Error(err) + } } } -- cgit v1.2.3