From 0bf8b81cb7a5894e7cb6336ac5a8f7510c92692d Mon Sep 17 00:00:00 2001 From: Chris O'Haver Date: Wed, 12 Sep 2018 02:07:24 -0400 Subject: plugin/federation: handle missing avail-zone/region labels better (#2092) * handle missing avail-zone/region labels better * oops forgot a file --- plugin/kubernetes/federation.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'plugin/kubernetes/federation.go') diff --git a/plugin/kubernetes/federation.go b/plugin/kubernetes/federation.go index df6ae948b..78e31668b 100644 --- a/plugin/kubernetes/federation.go +++ b/plugin/kubernetes/federation.go @@ -1,6 +1,8 @@ package kubernetes import ( + "errors" + "github.com/coredns/coredns/plugin/etcd/msg" "github.com/coredns/coredns/plugin/pkg/dnsutil" "github.com/coredns/coredns/request" @@ -37,6 +39,10 @@ func (k *Kubernetes) Federations(state request.Request, fname, fzone string) (ms lz := node.Labels[LabelZone] lr := node.Labels[LabelRegion] + if lz == "" || lr == "" { + return msg.Service{}, errors.New("local node missing zone/region labels") + } + if r.endpoint == "" { return msg.Service{Host: dnsutil.Join([]string{r.service, r.namespace, fname, r.podOrSvc, lz, lr, fzone})}, nil } -- cgit v1.2.3