From e6ef320d13580548a1ff9a36c3b1365240577ac1 Mon Sep 17 00:00:00 2001 From: Chris O'Haver Date: Mon, 27 Aug 2018 14:41:04 -0400 Subject: handle blank name and namespaces (#2042) --- plugin/kubernetes/kubernetes.go | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) (limited to 'plugin/kubernetes/kubernetes.go') diff --git a/plugin/kubernetes/kubernetes.go b/plugin/kubernetes/kubernetes.go index eaadb142c..4bdcd4877 100644 --- a/plugin/kubernetes/kubernetes.go +++ b/plugin/kubernetes/kubernetes.go @@ -343,6 +343,16 @@ func (k *Kubernetes) findPods(r recordRequest, zone string) (pods []msg.Service, zonePath := msg.Path(zone, "coredns") ip := "" + // handle empty pod name + if podname == "" { + if k.namespace(namespace) || wildcard(namespace) { + // NODATA + return nil, nil + } + // NXDOMAIN + return nil, errNoItems + } + if strings.Count(podname, "-") == 3 && !strings.Contains(podname, "--") { ip = strings.Replace(podname, "-", ".", -1) } else { @@ -362,6 +372,7 @@ func (k *Kubernetes) findPods(r recordRequest, zone string) (pods []msg.Service, return []msg.Service{{Key: strings.Join([]string{zonePath, Pod, namespace, podname}, "/"), Host: ip, TTL: k.ttl}}, err } + // PodModeVerified err = errNoItems if wildcard(podname) && !wildcard(namespace) { // If namespace exist, err should be nil, so that we return nodata instead of NXDOMAIN @@ -370,7 +381,6 @@ func (k *Kubernetes) findPods(r recordRequest, zone string) (pods []msg.Service, } } - // PodModeVerified for _, p := range k.APIConn.PodIndex(ip) { // If namespace has a wildcard, filter results against Corefile namespace list. if wildcard(namespace) && !k.namespaceExposed(p.Namespace) { @@ -411,6 +421,16 @@ func (k *Kubernetes) findServices(r recordRequest, zone string) (services []msg. serviceList []*api.Service ) + // handle empty service name + if r.service == "" { + if k.namespace(r.namespace) || wildcard(r.namespace) { + // NODATA + return nil, nil + } + // NXDOMAIN + return nil, errNoItems + } + if wildcard(r.service) || wildcard(r.namespace) { serviceList = k.APIConn.ServiceList() endpointsListFunc = func() []*api.Endpoints { return k.APIConn.EndpointsList() } -- cgit v1.2.3 /option> Unnamed repository; edit this file 'description' to name the repository.
aboutsummaryrefslogtreecommitdiff
path: root/packages/integrations/markdoc/test (unfollow)
AgeCommit message (Expand)AuthorFilesLines
2023-11-01[ci] release (#8975)astro@3.4.2@astrojs/underscore-redirects@0.3.2Gravatar Houston (Bot) 36-76/+72
2023-11-01[ci] formatGravatar matthewp 1-12/+13
2023-11-01feat(dev-overlay): Add a tooltip on plugin hover / focus (#8978)Gravatar Erika 3-3/+46
2023-11-01Prevent the route announcer from being visible (#8977)Gravatar Matthew Phillips 6-18/+64
2023-11-01feat: new event to toggle a plugin from itself (#8968)Gravatar Erika 2-4/+13
2023-11-01Fix ViewTransitions example (#8976)Gravatar Matthew Phillips 1-3/+1
2023-11-01feat(underscore-redirects): add `base` to input paths (#8953)Gravatar Alexander Niebuhr 2-6/+17
2023-11-01[ci] formatGravatar lilnasy 2-3/+3
2023-11-01fix(slots): consume eagerly rendered slot after one use (#8929)Gravatar Arsh 6-2/+59
2023-11-01[ci] release (#8934)create-astro@4.5.0astro@3.4.1@astrojs/vue@3.0.3@astrojs/sitemap@3.0.3@astrojs/partytown@2.0.2@astrojs/markdoc@0.7.1Gravatar Houston (Bot) 50-122/+120
2023-11-01Undo the halloween theme (#8959)Gravatar Elian ☕️ 3-26/+24
2023-10-31refactor: dev overlay to make it easier to work with VT (#8966)Gravatar Erika 10-293/+386
2023-10-31[ci] formatGravatar matthewp 1-9/+9
2023-10-31Move VT route announcer styles to a class (#8965)Gravatar Matthew Phillips 3-4/+21
2023-10-31Three small improvements for handling client-only in view transitions (#8964)Gravatar Martin Trapp 1-2/+10
2023-10-30chore(deps): Upgrade Zod to @latest (#8762)Gravatar Eva Decker 6-11/+26