From 725becd134752caead1aa2b2cf3a72d01c13b599 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sat, 19 Jan 2019 11:23:13 +0000 Subject: Stop importing testing in the main binary (#2479) * Stop importing testing in the main binary Stop importing "testing" into the main binary: * test/helpers.go imported it; remote that and change function signature * update all tests that use this Signed-off-by: Miek Gieben * Drop import testing from metrics plugin Signed-off-by: Miek Gieben * more fiddling Signed-off-by: Miek Gieben --- plugin/kubernetes/kubernetes_apex_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'plugin/kubernetes/kubernetes_apex_test.go') diff --git a/plugin/kubernetes/kubernetes_apex_test.go b/plugin/kubernetes/kubernetes_apex_test.go index 9b00658bb..9a91ea2e2 100644 --- a/plugin/kubernetes/kubernetes_apex_test.go +++ b/plugin/kubernetes/kubernetes_apex_test.go @@ -72,7 +72,7 @@ func TestServeDNSApex(t *testing.T) { _, err := k.ServeDNS(ctx, w, r) if err != tc.Error { - t.Errorf("Test %d, expected no error, got %v\n", i, err) + t.Errorf("Test %d, expected no error, got %v", i, err) return } if tc.Error != nil { @@ -84,6 +84,8 @@ func TestServeDNSApex(t *testing.T) { t.Fatalf("Test %d, got nil message and no error ford", i) } - test.SortAndCheck(t, resp, tc) + if err := test.SortAndCheck(resp, tc); err != nil { + t.Error(err) + } } } -- cgit v1.2.3