From 9798dd067f53a74e3777cff539b2f01617c107c6 Mon Sep 17 00:00:00 2001 From: Yong Tang Date: Thu, 24 Sep 2020 11:30:39 -0700 Subject: Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) * Implement notifies for transfer plugin (#3972) * Fix notifies in transfer plugin Signed-off-by: Miek Gieben * Make it compile Signed-off-by: Miek Gieben * Port more plugins Signed-off-by: Miek Gieben * golint Signed-off-by: Miek Gieben * Fix tests Signed-off-by: Miek Gieben * Fix notifies in transfer plugin Signed-off-by: Miek Gieben * Make it compile Signed-off-by: Miek Gieben * Port more plugins Signed-off-by: Miek Gieben * golint Signed-off-by: Miek Gieben * Fix tests Signed-off-by: Miek Gieben * Fix tests Signed-off-by: Miek Gieben * really fix test Signed-off-by: Miek Gieben * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben * Add transfer tests copied and modified from #3452 Signed-off-by: Miek Gieben * Test correct selection of plugin Signed-off-by: Miek Gieben * add upstream back in Signed-off-by: Miek Gieben * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben * fix test Signed-off-by: Miek Gieben * properly merge Signed-off-by: Miek Gieben * Remove plugin/kubernetes/setup_transfer_test.go Signed-off-by: Yong Tang Co-authored-by: Miek Gieben --- plugin/kubernetes/setup_transfer_test.go | 47 -------------------------------- 1 file changed, 47 deletions(-) delete mode 100644 plugin/kubernetes/setup_transfer_test.go (limited to 'plugin/kubernetes/setup_transfer_test.go') diff --git a/plugin/kubernetes/setup_transfer_test.go b/plugin/kubernetes/setup_transfer_test.go deleted file mode 100644 index 57d665821..000000000 --- a/plugin/kubernetes/setup_transfer_test.go +++ /dev/null @@ -1,47 +0,0 @@ -package kubernetes - -import ( - "testing" - - "github.com/coredns/caddy" -) - -func TestKubernetesParseTransfer(t *testing.T) { - tests := []struct { - input string // Corefile data as string - expected string - shouldErr bool - }{ - {`kubernetes cluster.local { - transfer to 1.2.3.4 - }`, "1.2.3.4:53", false}, - {`kubernetes cluster.local { - transfer to 1.2.3.4:53 - }`, "1.2.3.4:53", false}, - {`kubernetes cluster.local { - transfer to * - }`, "*", false}, - {`kubernetes cluster.local { - transfer - }`, "", true}, - } - - for i, tc := range tests { - c := caddy.NewTestController("dns", tc.input) - k, err := kubernetesParse(c) - if err != nil && !tc.shouldErr { - t.Fatalf("Test %d: Expected no error, got %q", i, err) - } - if err == nil && tc.shouldErr { - t.Fatalf("Test %d: Expected error, got none", i) - } - if err != nil && tc.shouldErr { - // input should error - continue - } - - if k.TransferTo[0] != tc.expected { - t.Errorf("Test %d: Expected Transfer To to be %s, got %s", i, tc.expected, k.TransferTo[0]) - } - } -} -- cgit v1.2.3