From 22c0b30d5f7468c2477291419bee3e88dfba490c Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sat, 2 Jun 2018 19:48:39 +0100 Subject: presubmit: Check errorf as well (#1845) Uppercase all these test errors as well. And extend the presubmit to check for these in the future. Also do a slightly smarter grep to only get t.. as (because dump regexp) this also grep over non test files. --- plugin/pkg/response/typify_test.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'plugin/pkg/response') diff --git a/plugin/pkg/response/typify_test.go b/plugin/pkg/response/typify_test.go index faeaf3579..6be9aa8ff 100644 --- a/plugin/pkg/response/typify_test.go +++ b/plugin/pkg/response/typify_test.go @@ -14,7 +14,7 @@ func TestTypifyNilMsg(t *testing.T) { ty, _ := Typify(m, time.Now().UTC()) if ty != OtherError { - t.Errorf("message wrongly typified, expected OtherError, got %s", ty) + t.Errorf("Message wrongly typified, expected OtherError, got %s", ty) } } @@ -22,7 +22,7 @@ func TestTypifyDelegation(t *testing.T) { m := delegationMsg() mt, _ := Typify(m, time.Now().UTC()) if mt != Delegation { - t.Errorf("message is wrongly typified, expected Delegation, got %s", mt) + t.Errorf("Message is wrongly typified, expected Delegation, got %s", mt) } } @@ -32,19 +32,19 @@ func TestTypifyRRSIG(t *testing.T) { m := delegationMsgRRSIGOK() if mt, _ := Typify(m, utc); mt != Delegation { - t.Errorf("message is wrongly typified, expected Delegation, got %s", mt) + t.Errorf("Message is wrongly typified, expected Delegation, got %s", mt) } // Still a Delegation because EDNS0 OPT DO bool is not set, so we won't check the sigs. m = delegationMsgRRSIGFail() if mt, _ := Typify(m, utc); mt != Delegation { - t.Errorf("message is wrongly typified, expected Delegation, got %s", mt) + t.Errorf("Message is wrongly typified, expected Delegation, got %s", mt) } m = delegationMsgRRSIGFail() m = addOpt(m) if mt, _ := Typify(m, utc); mt != OtherError { - t.Errorf("message is wrongly typified, expected OtherError, got %s", mt) + t.Errorf("Message is wrongly typified, expected OtherError, got %s", mt) } } -- cgit v1.2.3