From b868350fc2823f429cc828558f3425d5135e680f Mon Sep 17 00:00:00 2001
From: Eng Zer Jun <engzerjun@gmail.com>
Date: Sat, 17 Jun 2023 21:21:01 +0800
Subject: test: use `t.TempDir` to create temporary test directory (#6164)

---
 plugin/pkg/tls/tls_test.go | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

(limited to 'plugin/pkg/tls/tls_test.go')

diff --git a/plugin/pkg/tls/tls_test.go b/plugin/pkg/tls/tls_test.go
index b94efc28c..db1cad052 100644
--- a/plugin/pkg/tls/tls_test.go
+++ b/plugin/pkg/tls/tls_test.go
@@ -7,8 +7,8 @@ import (
 	"github.com/coredns/coredns/plugin/test"
 )
 
-func getPEMFiles(t *testing.T) (rmFunc func(), cert, key, ca string) {
-	tempDir, rmFunc, err := test.WritePEMFiles("")
+func getPEMFiles(t *testing.T) (cert, key, ca string) {
+	tempDir, err := test.WritePEMFiles(t)
 	if err != nil {
 		t.Fatalf("Could not write PEM files: %s", err)
 	}
@@ -21,8 +21,7 @@ func getPEMFiles(t *testing.T) (rmFunc func(), cert, key, ca string) {
 }
 
 func TestNewTLSConfig(t *testing.T) {
-	rmFunc, cert, key, ca := getPEMFiles(t)
-	defer rmFunc()
+	cert, key, ca := getPEMFiles(t)
 
 	_, err := NewTLSConfig(cert, key, ca)
 	if err != nil {
@@ -31,8 +30,7 @@ func TestNewTLSConfig(t *testing.T) {
 }
 
 func TestNewTLSClientConfig(t *testing.T) {
-	rmFunc, _, _, ca := getPEMFiles(t)
-	defer rmFunc()
+	_, _, ca := getPEMFiles(t)
 
 	_, err := NewTLSClientConfig(ca)
 	if err != nil {
@@ -41,8 +39,7 @@ func TestNewTLSClientConfig(t *testing.T) {
 }
 
 func TestNewTLSConfigFromArgs(t *testing.T) {
-	rmFunc, cert, key, ca := getPEMFiles(t)
-	defer rmFunc()
+	cert, key, ca := getPEMFiles(t)
 
 	_, err := NewTLSConfigFromArgs()
 	if err != nil {
@@ -81,8 +78,7 @@ func TestNewTLSConfigFromArgs(t *testing.T) {
 }
 
 func TestNewHTTPSTransport(t *testing.T) {
-	rmFunc, _, _, ca := getPEMFiles(t)
-	defer rmFunc()
+	_, _, ca := getPEMFiles(t)
 
 	cc, err := NewTLSClientConfig(ca)
 	if err != nil {
-- 
cgit v1.2.3