From 9798dd067f53a74e3777cff539b2f01617c107c6 Mon Sep 17 00:00:00 2001 From: Yong Tang Date: Thu, 24 Sep 2020 11:30:39 -0700 Subject: Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) * Implement notifies for transfer plugin (#3972) * Fix notifies in transfer plugin Signed-off-by: Miek Gieben * Make it compile Signed-off-by: Miek Gieben * Port more plugins Signed-off-by: Miek Gieben * golint Signed-off-by: Miek Gieben * Fix tests Signed-off-by: Miek Gieben * Fix notifies in transfer plugin Signed-off-by: Miek Gieben * Make it compile Signed-off-by: Miek Gieben * Port more plugins Signed-off-by: Miek Gieben * golint Signed-off-by: Miek Gieben * Fix tests Signed-off-by: Miek Gieben * Fix tests Signed-off-by: Miek Gieben * really fix test Signed-off-by: Miek Gieben * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben * Add transfer tests copied and modified from #3452 Signed-off-by: Miek Gieben * Test correct selection of plugin Signed-off-by: Miek Gieben * add upstream back in Signed-off-by: Miek Gieben * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben * fix test Signed-off-by: Miek Gieben * properly merge Signed-off-by: Miek Gieben * Remove plugin/kubernetes/setup_transfer_test.go Signed-off-by: Yong Tang Co-authored-by: Miek Gieben --- plugin/transfer/select_test.go | 58 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 plugin/transfer/select_test.go (limited to 'plugin/transfer/select_test.go') diff --git a/plugin/transfer/select_test.go b/plugin/transfer/select_test.go new file mode 100644 index 000000000..6cb0d7681 --- /dev/null +++ b/plugin/transfer/select_test.go @@ -0,0 +1,58 @@ +package transfer + +import ( + "context" + "fmt" + "testing" + + "github.com/coredns/coredns/plugin/pkg/dnstest" + "github.com/coredns/coredns/plugin/test" + + "github.com/miekg/dns" +) + +type ( + t1 struct{} + t2 struct{} +) + +func (t t1) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) { + const z = "example.org." + if zone != z { + return nil, ErrNotAuthoritative + } + return nil, fmt.Errorf(z) +} +func (t t2) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) { + const z = "sub.example.org." + if zone != z { + return nil, ErrNotAuthoritative + } + return nil, fmt.Errorf(z) +} + +func TestZoneSelection(t *testing.T) { + tr := &Transfer{ + Transferers: []Transferer{t1{}, t2{}}, + xfrs: []*xfr{ + { + Zones: []string{"example.org."}, + to: []string{"192.0.2.1"}, // RFC 5737 IP, no interface should have this address. + }, + { + Zones: []string{"sub.example.org."}, + to: []string{"*"}, + }, + }, + } + r := new(dns.Msg) + r.SetAxfr("sub.example.org.") + w := dnstest.NewRecorder(&test.ResponseWriter{}) + _, err := tr.ServeDNS(context.TODO(), w, r) + if err == nil { + t.Fatal("Expected error, got nil") + } + if x := err.Error(); x != "sub.example.org." { + t.Errorf("Expected transfer for zone %s, got %s", "sub.example.org", x) + } +} -- cgit v1.2.3