diff options
author | 2017-08-29 01:03:24 +0200 | |
---|---|---|
committer | 2017-08-29 01:03:24 +0200 | |
commit | 7455313cf730cba1470b9b4ab5fe3554ff19c628 (patch) | |
tree | 9dd95b9f93efb7e76773c74a3a0e727f0948acb6 /src/controller.cpp | |
parent | 930605cac684e351e58c797fe4d376d50a16f5de (diff) | |
download | newsboat-7455313cf730cba1470b9b4ab5fe3554ff19c628.tar.gz newsboat-7455313cf730cba1470b9b4ab5fe3554ff19c628.tar.zst newsboat-7455313cf730cba1470b9b4ab5fe3554ff19c628.zip |
improved code quality according to Minoru's advice
Diffstat (limited to 'src/controller.cpp')
-rw-r--r-- | src/controller.cpp | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/controller.cpp b/src/controller.cpp index 53b6dbe8..e8e065e7 100644 --- a/src/controller.cpp +++ b/src/controller.cpp @@ -1317,11 +1317,12 @@ void controller::edit_urls_file() { v->push_empty_formaction(); stfl::reset(); - /* We should not check this particular exit code. - * Editors usually fail when closing+saving (and stay open). - * (tested with vim, nano, gedit, geany) - * (texmaker 5.0.1 and notepadqq 1.0.1 close without neither showing an - * error nor saving but despite return 0) + /* Most editors check for unsaved changes when attempting to exit and + * prompt to either save or discard them. If save was choosen without + * having write permissions a properly codd will fail and stay open + * (like vim, nano, gedit, geany). However other editors (texmaker + * 5.0.1 and notepadqq 1.0.1) close but despite return 0. + * So we should not check this particular exit code. */ int unused __attribute__((unused)); unused = utils::run_interactively(cmdline, "controller::edit_urls_file"); |