diff options
author | 2017-09-04 22:59:00 +0300 | |
---|---|---|
committer | 2017-09-04 22:59:00 +0300 | |
commit | bf4ba0510efbb04b37b0b4f1d80bf33f471dce04 (patch) | |
tree | 4abdcda57462b8804667e921f85aa04e2a7f9a46 /src/controller.cpp | |
parent | b3cf168b1a928e092508f676f6be4664d971e33c (diff) | |
download | newsboat-bf4ba0510efbb04b37b0b4f1d80bf33f471dce04.tar.gz newsboat-bf4ba0510efbb04b37b0b4f1d80bf33f471dce04.tar.zst newsboat-bf4ba0510efbb04b37b0b4f1d80bf33f471dce04.zip |
Revert "improved code quality according to Minoru's advice"
This reverts commit 7455313cf730cba1470b9b4ab5fe3554ff19c628.
Diffstat (limited to 'src/controller.cpp')
-rw-r--r-- | src/controller.cpp | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/controller.cpp b/src/controller.cpp index e8e065e7..53b6dbe8 100644 --- a/src/controller.cpp +++ b/src/controller.cpp @@ -1317,12 +1317,11 @@ void controller::edit_urls_file() { v->push_empty_formaction(); stfl::reset(); - /* Most editors check for unsaved changes when attempting to exit and - * prompt to either save or discard them. If save was choosen without - * having write permissions a properly codd will fail and stay open - * (like vim, nano, gedit, geany). However other editors (texmaker - * 5.0.1 and notepadqq 1.0.1) close but despite return 0. - * So we should not check this particular exit code. + /* We should not check this particular exit code. + * Editors usually fail when closing+saving (and stay open). + * (tested with vim, nano, gedit, geany) + * (texmaker 5.0.1 and notepadqq 1.0.1 close without neither showing an + * error nor saving but despite return 0) */ int unused __attribute__((unused)); unused = utils::run_interactively(cmdline, "controller::edit_urls_file"); |