diff options
author | 2017-09-04 22:59:10 +0300 | |
---|---|---|
committer | 2017-09-04 22:59:10 +0300 | |
commit | 4fe54cc292ddd860ba7d83c4795f09026a765277 (patch) | |
tree | 3ad5c7057f0e34eec22ce724de5ad6ca4ff404a3 /src/view.cpp | |
parent | ce7cfb4bbb71343545029e41c1fa4929dab7e838 (diff) | |
download | newsboat-4fe54cc292ddd860ba7d83c4795f09026a765277.tar.gz newsboat-4fe54cc292ddd860ba7d83c4795f09026a765277.tar.zst newsboat-4fe54cc292ddd860ba7d83c4795f09026a765277.zip |
Revert "intercept browser's/pager's failure (issue #449)"
This reverts commit 61639b2c29eb83c7ac947c262f35276c0aadc6ac.
Diffstat (limited to '')
-rw-r--r-- | src/view.cpp | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/src/view.cpp b/src/view.cpp index 64c6cec0..1ae5c0b9 100644 --- a/src/view.cpp +++ b/src/view.cpp @@ -311,7 +311,7 @@ void view::push_empty_formaction() { current_formaction = formaction_stack_size() - 1; } -bool view::open_in_pager(const std::string& filename) { +void view::open_in_pager(const std::string& filename) { formaction_stack.push_back(std::shared_ptr<formaction>()); current_formaction = formaction_stack_size() - 1; std::string cmdline; @@ -332,13 +332,8 @@ bool view::open_in_pager(const std::string& filename) { cmdline.append(filename); } stfl::reset(); - int pager_exit_code = utils::run_interactively(cmdline, "view::open_in_pager"); - if (pager_exit_code != 0) { - LOG(level::DEBUG, "utils::run_interactively: " - "Starting the pager failed with error code %d - command was %s", pager_exit_code, cmdline); - } + utils::run_interactively(cmdline, "view::open_in_pager"); pop_current_formaction(); - return pager_exit_code == 0; } bool view::open_in_browser(const std::string& url) { @@ -485,10 +480,7 @@ void view::push_itemview(std::shared_ptr<rss_feed> f, const std::string& guid, c } else { std::shared_ptr<rss_item> item = f->get_item_by_guid(guid); std::string filename = get_ctrl()->write_temporary_item(item); - if (!open_in_pager(filename)) { - show_error(_("Pager failed to show the item!")); - return; - } + open_in_pager(filename); try { bool old_unread = item->unread(); item->set_unread(false); |