#include "itemrenderer.h" #include "3rd-party/catch.hpp" #include "cache.h" #include "configcontainer.h" #include "regexmanager.h" #include "rssfeed.h" #include "test-helpers/envvar.h" using namespace newsboat; static const auto FEED_TITLE = std::string("Funniest jokes ever"); std::shared_ptr create_test_feed(Cache* c) { auto feed = std::make_shared(c, ""); feed->set_title(FEED_TITLE); return feed; } static const auto ITEM_TITLE = std::string("A frivolous test item"); static const auto ITEM_AUTHOR = std::string("Johnny Doe Jr."); // Sun Sep 30 19:34:25 UTC 2018 static const auto ITEM_PUBDATE = time_t { 1538336065 }; static const auto ITEM_LINK = std::string("https://example.com/see-more"); static const auto ITEM_DESCRIPTON = std::string("

Hello, world!

"); static const auto ITEM_DESCRIPTON_RENDERED = std::string("Hello, world!"); static const auto ITEM_ENCLOSURE_URL = std::string("https://example.com/see-more.mp3"); static const auto ITEM_ENCLOSURE_TYPE = std::string("audio/mpeg"); static const auto ITEM_FLAGS = std::string("wasdhjkl"); // Flags are sorted for rendering. static const auto ITEM_FLAGS_RENDERED = std::string("adhjklsw"); std::pair, std::shared_ptr> create_test_item( Cache* c) { const auto feed = create_test_feed(c); auto item = std::make_shared(c); item->set_feedptr(feed); item->set_title(ITEM_TITLE); item->set_author(ITEM_AUTHOR); item->set_pubDate(ITEM_PUBDATE); item->set_link(ITEM_LINK); item->set_flags(ITEM_FLAGS); return {item, feed}; } TEST_CASE("item_renderer::to_plain_text() produces a rendered representation " "of an RSS item, ready to be displayed to the user", "[item_renderer]") { TestHelpers::TzEnvVar tzEnv; tzEnv.set("UTC"); ConfigContainer cfg; // item_renderer uses that setting, so let's fix its value to make the test // reproducible cfg.set_configvalue("text-width", "80"); Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); SECTION("Item without an enclosure") { item->set_description(ITEM_DESCRIPTON, "text/html"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + ITEM_DESCRIPTON_RENDERED + '\n'; REQUIRE(result == expected); } SECTION("Item with an enclosure") { item->set_description(ITEM_DESCRIPTON, "text/html"); item->set_enclosure_url(ITEM_ENCLOSURE_URL); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + "Podcast Download URL: " + ITEM_ENCLOSURE_URL + '\n' + " \n" + ITEM_DESCRIPTON_RENDERED + '\n'; REQUIRE(result == expected); } SECTION("Item with an enclosure that has a MIME type") { item->set_description(ITEM_DESCRIPTON, "text/html"); item->set_enclosure_url(ITEM_ENCLOSURE_URL); item->set_enclosure_type(ITEM_ENCLOSURE_TYPE); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + "Podcast Download URL: " + ITEM_ENCLOSURE_URL + " (type: " + ITEM_ENCLOSURE_TYPE + ")\n" + " \n" + ITEM_DESCRIPTON_RENDERED + '\n'; REQUIRE(result == expected); } SECTION("Item with some links in the description") { item->set_description( ITEM_DESCRIPTON + "

See also this site.

", "text/html"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + ITEM_DESCRIPTON_RENDERED + '\n' + " \n" + "See also this site[1].\n" + " \n" + "Links: \n" + "[1]: https://example.com/ (link)\n"; REQUIRE(result == expected); } } TEST_CASE("item_renderer::to_plain_text() renders text to the width specified " "in `text-width` setting", "[item_renderer]") { TestHelpers::TzEnvVar tzEnv; tzEnv.set("UTC"); ConfigContainer cfg; Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); item->set_description( "Lorem ipsum dolor sit amet, consectetur adipiscing elit. " "Pellentesque nisl massa, luctus ut ligula vitae, suscipit tempus " "velit. Vivamus sodales, quam in convallis posuere, libero nisi " "ultricies orci, nec lobortis.", "text/html"); const auto header = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n"; SECTION("If `text-width` is not set, text is rendered in 80 columns") { const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = header + "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque nisl \n" + "massa, luctus ut ligula vitae, suscipit tempus velit. Vivamus sodales, quam in \n" + "convallis posuere, libero nisi ultricies orci, nec lobortis.\n"; REQUIRE(result == expected); } SECTION("If `text-width` is set to zero, text is rendered in 80 columns") { cfg.set_configvalue("text-width", "0"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = header + "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque nisl \n" + "massa, luctus ut ligula vitae, suscipit tempus velit. Vivamus sodales, quam in \n" + "convallis posuere, libero nisi ultricies orci, nec lobortis.\n"; REQUIRE(result == expected); } SECTION("Text is rendered in 37 columns") { cfg.set_configvalue("text-width", "37"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = header + "Lorem ipsum dolor sit amet, \n" "consectetur adipiscing elit. \n" "Pellentesque nisl massa, luctus ut \n" "ligula vitae, suscipit tempus velit. \n" "Vivamus sodales, quam in convallis \n" "posuere, libero nisi ultricies orci, \n" "nec lobortis.\n"; REQUIRE(result == expected); } SECTION("Text is rendered in 120 columns") { cfg.set_configvalue("text-width", "120"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = header + "Lorem ipsum dolor sit amet, consectetur adipiscing elit. " "Pellentesque nisl massa, luctus ut ligula vitae, suscipit \n" "tempus velit. Vivamus sodales, quam in convallis posuere, libero " "nisi ultricies orci, nec lobortis.\n"; REQUIRE(result == expected); } SECTION("angle brackets are only counted as one character") { cfg.set_configvalue("text-width", "37"); item->set_description( "<<<<<<<<<<" // 10 characters ">>>>>>>>>>" // 10 characters "Lorem ipsum dolor sit amet", "text/html"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = header + "<<<<<<<<<<>>>>>>>>>>Lorem ipsum dolor\n" "sit amet\n"; REQUIRE(result == expected); } } TEST_CASE("to_plain_text() does not escape '<' and '>' in header and body", "[item_renderer]") { TestHelpers::TzEnvVar tzEnv; tzEnv.set("UTC"); ConfigContainer cfg; Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); feed->set_title("<" + FEED_TITLE + ">"); item->set_title("<" + ITEM_TITLE + ">"); item->set_author("<" + ITEM_AUTHOR + ">"); item->set_description("<test>", "text/html"); const auto expected = std::string() + "Feed: <" + FEED_TITLE + ">\n" + "Title: <" + ITEM_TITLE + ">\n" + "Author: <" + ITEM_AUTHOR + ">\n" + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + "\n"; const auto result = item_renderer::to_plain_text(cfg, item); REQUIRE(result == expected); } TEST_CASE("Empty fields are not rendered", "[item_renderer]") { TestHelpers::TzEnvVar tzEnv; tzEnv.set("UTC"); ConfigContainer cfg; // item_renderer uses that setting, so let's fix its value to make the test // reproducible cfg.set_configvalue("text-width", "80"); Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); SECTION("Item without a feed title") { item->get_feedptr()->set_title(""); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n"; REQUIRE(result == expected); } SECTION("Item without a title") { item->set_title(""); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n"; REQUIRE(result == expected); } SECTION("Item without an author") { item->set_author(""); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n"; REQUIRE(result == expected); } SECTION("Item without a link") { item->set_link(""); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n"; REQUIRE(result == expected); } SECTION("Item without an enclosure") { item->set_description(ITEM_DESCRIPTON, "text/html"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + ITEM_DESCRIPTON_RENDERED + '\n'; REQUIRE(result == expected); } SECTION("Item without flags") { item->set_flags(""); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + " \n"; REQUIRE(result == expected); } } TEST_CASE("item_renderer::to_plain_text honours `html-renderer` setting", "[item_renderer]") { TestHelpers::TzEnvVar tzEnv; tzEnv.set("UTC"); ConfigContainer cfg; cfg.set_configvalue("text-width", "80"); Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); SECTION("Single-paragraph description") { const auto description = std::string() + "

Hello, world! Check out " "our site.

"; item->set_description(description, "text/html"); SECTION("internal renderer") { cfg.set_configvalue("html-renderer", "internal"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + "Hello, world! Check out our site[1].\n" + " \n" + "Links: \n" + "[1]: https://example.com/ (link)\n"; REQUIRE(result == expected); } // cat is pretty much guaranteed to be present in any Unix-like // environment, so let's use that instead of the less common w3m. SECTION("/bin/cat as a renderer") { cfg.set_configvalue("html-renderer", "/bin/cat"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + description + '\n'; REQUIRE(result == expected); } } SECTION("Multi-paragraph description") { const auto description = std::string() + "

Hello, world!

\n\n" "

Check out our site.

"; item->set_description(description, "text/html"); SECTION("internal renderer") { cfg.set_configvalue("html-renderer", "internal"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + "Hello, world!\n" + " \n" + "Check out our site[1].\n" + " \n" + "Links: \n" + "[1]: https://example.com/ (link)\n"; REQUIRE(result == expected); } // cat is pretty much guaranteed to be present in any Unix-like // environment, so let's use that instead of the less common w3m. SECTION("/bin/cat as a renderer") { cfg.set_configvalue("html-renderer", "/bin/cat"); const auto result = item_renderer::to_plain_text(cfg, item); const auto expected = std::string() + "Feed: " + FEED_TITLE + '\n' + "Title: " + ITEM_TITLE + '\n' + "Author: " + ITEM_AUTHOR + '\n' + "Date: Sun, 30 Sep 2018 19:34:25 +0000\n" + "Link: " + ITEM_LINK + '\n' + "Flags: " + ITEM_FLAGS_RENDERED + '\n' + " \n" + "

Hello, world!

\n" + " \n" + "

Check out our site.

\n"; REQUIRE(result == expected); } } } TEST_CASE("item_renderer::get_feedtitle() returns item's feed title without " "soft hyphens if that's available", "[item_renderer]") { ConfigContainer cfg; Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); const auto check = [&]() { const auto result = item_renderer::get_feedtitle(item); REQUIRE(result == "Welcome, lovely strangers!"); }; SECTION("Title without soft hyphens") { feed->set_title("Welcome, lovely strangers!"); check(); } SECTION("Title containing soft hyphens") { feed->set_title("Wel\u00ADcome, lo\u00ADve\u00ADly stran\u00ADgers!"); check(); } } TEST_CASE("item_renderer::get_feedtitle() returns item's feed self-link " "if its title is empty", "[item_renderer]") { ConfigContainer cfg; Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); const auto feedlink = std::string("https://rss.example.com/~joe/"); feed->set_title(""); feed->set_link(feedlink); const auto result = item_renderer::get_feedtitle(item); REQUIRE(result == feedlink); } TEST_CASE("item_renderer::get_feedtitle() returns item's feed URL " "if both the title and self-link are empty", "[item_renderer]") { ConfigContainer cfg; Cache rsscache(":memory:", &cfg); const auto feedurl = std::string("https://example.com/~joe/entries.rss"); std::shared_ptr feed = std::make_shared(&rsscache, feedurl); auto item = std::make_shared(&rsscache); item->set_feedptr(feed); feed->set_title(""); feed->set_link(""); const auto result = item_renderer::get_feedtitle(item); REQUIRE(result == feedurl); } TEST_CASE("Functions used for rendering articles escape '<' into `<>` for use with stfl", "[item_renderer]") { TestHelpers::TzEnvVar tzEnv; tzEnv.set("UTC"); ConfigContainer cfg; RegexManager rxman; Cache rsscache(":memory:", &cfg); std::shared_ptr item; std::shared_ptr feed; std::tie(item, feed) = create_test_item(&rsscache); feed->set_title("<" + FEED_TITLE + ">"); item->set_title("<" + ITEM_TITLE + ">"); item->set_author("<" + ITEM_AUTHOR + ">"); item->set_description("<test>", "text/html"); SECTION("to_stfl_list()") { const auto expected = std::string() + "{list" + "{listitem text:\"Feed: <>" + FEED_TITLE + ">\"}" + "{listitem text:\"Title: <>" + ITEM_TITLE + ">\"}" + "{listitem text:\"Author: <>" + ITEM_AUTHOR + ">\"}" + "{listitem text:\"Date: Sun, 30 Sep 2018 19:34:25 +0000\"}" + "{listitem text:\"Link: " + ITEM_LINK + "\"}" + "{listitem text:\"Flags: " + ITEM_FLAGS_RENDERED + "\"}" + "{listitem text:\" \"}" + "{listitem text:\"<>test>\"}" + "}"; std::vector links; const auto result = item_renderer::to_stfl_list(cfg, item, 80, 80, &rxman, "article", links); REQUIRE(result.first == expected); } SECTION("source_to_stfl_list()") { const auto expected = std::string() + "{list" + "{listitem text:\"Feed: <>" + FEED_TITLE + ">\"}" + "{listitem text:\"Title: <>" + ITEM_TITLE + ">\"}" + "{listitem text:\"Author: <>" + ITEM_AUTHOR + ">\"}" + "{listitem text:\"Date: Sun, 30 Sep 2018 19:34:25 +0000\"}" + "{listitem text:\"Link: " + ITEM_LINK + "\"}" + "{listitem text:\"Flags: " + ITEM_FLAGS_RENDERED + "\"}" + "{listitem text:\" \"}" + "{listitem text:\"<>html><test><>/html>\"}" + "}"; std::vector links; const auto result = item_renderer::source_to_stfl_list(item, 80, 80, &rxman, "article"); REQUIRE(result.first == expected); } } TEST_CASE("item_renderer::render_plaintext() splits text on newlines", "[item_renderer]") { using newsboat::item_renderer::OutputFormat; // Verifies that render_plaintext creates the expected lines, all marked as wrappable const auto check = [](const std::string input, const std::vector& expected_lines, OutputFormat format) { std::vector> output; item_renderer::render_plaintext(input, output, format); REQUIRE(output.size() == expected_lines.size()); for (std::size_t i = 0; i < output.size(); ++i) { INFO("i: " + std::to_string(i)); REQUIRE(output[i].first == LineType::wrappable); REQUIRE(output[i].second == expected_lines[i]); } }; SECTION(R"(regular text is split on \r and \n)") { const std::string text = "Lorem ipsum dolor sit amet\nconsectetur adipiscing elit\rsed do eiusmod tempor incididunt ut labore\net dolore magna aliqua."; check(text, { "Lorem ipsum dolor sit amet", "consectetur adipiscing elit", "sed do eiusmod tempor incididunt ut labore", "et dolore magna aliqua." }, OutputFormat::StflRichText); } SECTION("render_plaintext keeps indentation") { const std::string text = "The following lines are indented:\n hello\n this is a test\n\nback to no indentation"; check(text, { "The following lines are indented:", " hello", " this is a test", "", "back to no indentation" }, OutputFormat::StflRichText); } SECTION(R"(text is split on sequences of \r\n, and on separate \r and \n characters)") { const std::string text = "Lorem ipsum\r\ndolor sit amet\n\rconsectetur adipiscing elit\rsed do eiusmod tempor incididunt ut labore\net dolore magna\r\n\r\naliqua."; check(text, { "Lorem ipsum", "dolor sit amet", "", "consectetur adipiscing elit", "sed do eiusmod tempor incididunt ut labore", "et dolore magna", "", "aliqua." }, OutputFormat::StflRichText); } SECTION("render_plaintext escapes angle brackets for STFL") { const std::string text = "this < should be escaped >\n

test text

"; check(text, { "this <> should be escaped >", "<>p>test text<>/p>" }, OutputFormat::StflRichText); } SECTION("render_plaintext does not escape when rendering towards some plaintext output") { const std::string text = "this < should *not* be escaped >\n

test text

"; check(text, { "this < should *not* be escaped >", "

test text

" }, OutputFormat::PlainText); } }