1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
import React from 'dom-chef';
import delegate, {DelegateEvent} from 'delegate-it';
import * as pageDetect from 'github-url-detection';
import {CheckIcon, FileDiffIcon} from '@primer/octicons-react';
import features from '../feature-manager.js';
import observe from '../helpers/selector-observer.js';
import {assertNodeContent} from '../helpers/dom-utils.js';
function replaceCheckboxes(originalSubmitButton: HTMLButtonElement): void {
const form = originalSubmitButton.form!;
const actionsRow = originalSubmitButton.closest([
'.form-actions', // TODO: For GHE. Remove after June 2024
'.Overlay-footer',
])!;
const formAttribute = originalSubmitButton.getAttribute('form')!;
// Do not use `$$` because elements can be outside `form`
// `RadioNodeList` is dynamic, so we need to make a copy
const radios = [...form.elements.namedItem('pull_request_review[event]') as RadioNodeList] as HTMLInputElement[];
if (radios.length === 0) {
features.log.error(import.meta.url, 'Could not find radio buttons');
return;
}
// Set the default action for cmd+enter to Comment
if (radios.length > 1) {
form.prepend(
<input
type="hidden"
name="pull_request_review[event]"
value="comment"
/>,
);
}
// Generate the new buttons
for (const radio of radios) {
const parent = radio.parentElement!;
const labelElement = (
parent.querySelector('label')
?? radio.nextSibling! // TODO: Remove after April 2024
);
const tooltip = parent.querySelector([
'p', // TODO: Remove after April 2024
'.FormControl-caption',
])!.textContent.trim().replace(/\.$/, '');
assertNodeContent(labelElement, /^(Approve|Request changes|Comment)$/);
const classes = ['btn btn-sm'];
if (tooltip) {
classes.push('tooltipped tooltipped-nw tooltipped-no-delay');
}
const button = (
<button
type="submit"
name="pull_request_review[event]"
// Old version of GH don't nest the submit button inside the form, so must be linked manually. Issue #6963.
form={formAttribute}
value={radio.value}
className={classes.join(' ')}
aria-label={tooltip}
disabled={radio.disabled}
>
{labelElement.textContent}
</button>
);
if (!radio.disabled && radio.value === 'approve') {
button.prepend(<CheckIcon className="color-fg-success"/>);
} else if (!radio.disabled && radio.value === 'reject') {
button.prepend(<FileDiffIcon className="color-fg-danger"/>);
}
actionsRow.append(button);
}
// Remove original fields at last to avoid leaving a broken form
const fieldset = radios[0].closest('fieldset');
if (fieldset) {
fieldset.remove();
} else {
// To retain backwards compatibility with older GHE versions, remove any radios not within a fieldset. Issue #6963.
for (const radio of radios) {
radio.closest('.form-checkbox')!.remove();
}
}
originalSubmitButton.remove();
}
let lastSubmission: number | undefined;
function blockDuplicateSubmissions(event: DelegateEvent): void {
if (lastSubmission && Date.now() - lastSubmission < 1000) {
event.preventDefault();
console.log('Duplicate submission prevented');
return;
}
lastSubmission = Date.now();
}
function init(signal: AbortSignal): void {
// The selector excludes the "Cancel" button
observe('#review-changes-modal [type="submit"]:not([name])', replaceCheckboxes, {signal});
delegate('#review-changes-modal form', 'submit', blockDuplicateSubmissions, {signal});
}
void features.add(import.meta.url, {
include: [
pageDetect.isPRFiles,
],
awaitDomReady: true,
init,
});
/*
Test URLs
https://github.com/refined-github/sandbox/pull/4/files
https://github.com/refined-github/sandbox/pull/12/files
*/
|
