1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
import './show-names.css';
import React from 'dom-chef';
import * as pageDetect from 'github-url-detection';
import batchedFunction from 'batched-function';
import features from '../feature-manager.js';
import api from '../github-helpers/api.js';
import {getUsername, compareNames} from '../github-helpers/index.js';
import observe from '../helpers/selector-observer.js';
import {removeTextNodeContaining} from '../helpers/dom-utils.js';
// The selector observer calls this function several times, but we want to batch them into a single GraphQL API call
const batchUpdateLinks = batchedFunction(async (batchedUsernameElements: HTMLAnchorElement[]): Promise<void> => {
// TODO: Split up this function, it does too much
const usernames = new Set<string>();
const myUsername = getUsername();
for (const element of new Set(batchedUsernameElements)) {
const username = element.textContent;
if (username && username !== myUsername && username !== 'ghost') {
usernames.add(element.textContent!);
}
// Drop 'commented' label to shorten the copy
const commentedNode = element.parentNode!.nextSibling;
if (element.closest('.timeline-comment-header') && commentedNode) {
// "left a comment" appears in the main comment of reviews
removeTextNodeContaining(commentedNode, /commented|left a comment/);
}
}
if (usernames.size === 0) {
return;
}
const names = await api.v4(
[...usernames].map(user =>
api.escapeKey(user) + `: user(login: "${user}") {name}`,
).join(','),
);
for (const usernameElement of batchedUsernameElements) {
const username = usernameElement.textContent!;
const userKey = api.escapeKey(username);
// For the currently logged in user, `names[userKey]` would not be present
const {name} = names[userKey] ?? {};
if (!name) {
continue;
}
// If it's a regular comment author, add it outside <strong> otherwise it's something like "User added some commits"
if (compareNames(username, name)) {
usernameElement.textContent = name;
continue;
}
const {parentElement} = usernameElement;
const insertionPoint = parentElement!.tagName === 'STRONG' ? parentElement! : usernameElement;
insertionPoint.after(
' ',
<span className="color-fg-muted css-truncate d-inline-block">
(<bdo className="css-truncate-target" style={{maxWidth: '200px'}}>{name}</bdo>)
</span>,
' ',
);
}
});
const usernameLinksSelector = [
// `a` selector needed to skip commits by non-GitHub users
// # targets mannequins #6504
`:is(
.js-discussion,
.inline-comments
) a.author:not(
[href="#"],
[href*="/apps/"],
[href*="/marketplace/"],
[data-hovercard-type="organization"]
)`,
// On dashboard
// `.Link--primary` excludes avatars
// `.color-shadow-medium` excludes links in cards #6530
'#dashboard a.Link--primary[data-hovercard-type="user"]:not(.color-shadow-medium a)',
] as const;
function init(signal: AbortSignal): void {
document.body.classList.add('rgh-show-names');
observe(usernameLinksSelector, batchUpdateLinks, {signal});
}
void features.add(import.meta.url, {
include: [
pageDetect.isDashboard,
pageDetect.hasComments,
],
init,
});
/*
Test URLs:
- issue: https://github.com/isaacs/github/issues/297
- pr with reviews: https://github.com/rust-lang/rfcs/pull/2544
- mannequins: https://togithub.com/python/cpython/issues/67591
- newsfeed: https://github.com
*/
|
