1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
|
import React from 'dom-chef';
import select from 'select-dom';
import onetime from 'onetime';
import insertText from 'insert-text-textarea';
import delegate, {DelegateEvent} from 'delegate-it';
import features from '../libs/features';
import {observeOneMutation} from '../libs/simplified-element-observer';
import {reportBug} from '../libs/utils';
import oneEvent from '../libs/one-event';
const pendingSelector = '.timeline-comment-label.is-pending';
const getButton = onetime(() => (
<button className="rgh-submit-single btn-link ml-2 text-gray text-small" type="button">Send now</button>
));
function updateUI(): void {
// The feature only works with one comment
const labels = select.all(pendingSelector);
if (labels.length === 1) {
labels[0].after(getButton());
} else {
getButton().remove();
}
}
async function handleReviewSubmission(event: DelegateEvent): Promise<void> {
const container = event.delegateTarget.closest('.line-comments')!;
await observeOneMutation(container);
if (select.exists(pendingSelector, container)) {
updateUI();
}
// If no label is found, "Add single comment" was clicked
}
// Finds nearby comment field by listening it to its `focus` event.
// Supports multiple threads on same line, split diffs, replies and new threads.
async function getNewCommentField(commentContainer: Element, lineBeingCommentedOn: Element): Promise<HTMLTextAreaElement> {
const isReplyingToExistingThread = commentContainer.closest('.js-comments-holder')!.childElementCount > 1;
const listener = oneEvent(lineBeingCommentedOn.parentElement!, 'focusin');
if (isReplyingToExistingThread) {
const newCommentContainer = commentContainer.closest('.js-resolvable-thread-contents')!;
select('.review-thread-reply-button', newCommentContainer)!.click();
} else {
const isRightSide = commentContainer.closest('.js-addition');
(isRightSide ? select.last : select)('.js-add-line-comment', lineBeingCommentedOn)!.click();
}
// Hide comment box
return (await listener).target as HTMLTextAreaElement;
}
async function handleSubmitSingle(event: DelegateEvent): Promise<void> {
const commentContainer = event.delegateTarget.closest('.js-comment')!;
const commentText = select<HTMLTextAreaElement>('[name="pull_request_review_comment[body]"]', commentContainer)!.value;
if (!commentText) {
reportBug(__featureName__, 'comment not found');
return;
}
// The comments are in a <tr> right after the code
const lineBeingCommentedOn = commentContainer.closest('tr')!.previousElementSibling!;
// Use nearby comment box
const comment = await getNewCommentField(commentContainer, lineBeingCommentedOn);
const submitButton = select<HTMLButtonElement>('[name="single_comment"]', comment.form!)!;
const commentForm = comment.closest<HTMLElement>('.inline-comment-form-container')!;
// Copy comment to new comment box
insertText(comment.form!.elements['comment[body]'] as HTMLTextAreaElement, commentText);
// Safely try comment deletion
try {
console.log(commentForm);
commentForm.hidden = true;
// Delete comment without asking confirmation
const deleteLink = select<HTMLButtonElement>('[aria-label="Delete comment"]', commentContainer)!;
deleteLink.removeAttribute('data-confirm');
deleteLink.click();
// Wait for the comment to be removed
await observeOneMutation(lineBeingCommentedOn.parentElement!);
// Enable form and submit new comment
submitButton.disabled = false;
submitButton.click();
// Wait for the comment to be added
await observeOneMutation(lineBeingCommentedOn.parentElement!);
commentForm.hidden = false;
} catch (error) {
commentForm.hidden = false;
// Place comment in console to allow recovery
console.log('You were trying to sending this comment:');
console.log(commentText);
reportBug(__featureName__, 'there was an error sending the comment');
console.error(error);
}
}
function init(): void {
delegate('#files', '[action$="/review_comment/create"]', 'submit', handleReviewSubmission);
delegate('#files', '.rgh-submit-single', 'click', handleSubmitSingle);
updateUI();
}
features.add({
id: __featureName__,
description: 'Adds a button to submit a single PR comment if you mistakenly started a new review.',
screenshot: 'https://user-images.githubusercontent.com/1402241/60331761-f6394200-99c7-11e9-81c2-c671cba9602a.gif',
include: [
features.isPRFiles
],
load: features.onAjaxedPages,
init
});
|
