diff options
Diffstat (limited to 'internal/googlereader')
| -rw-r--r-- | internal/googlereader/handler.go | 449 | ||||
| -rw-r--r-- | internal/googlereader/middleware.go | 166 | ||||
| -rw-r--r-- | internal/googlereader/response.go | 5 |
3 files changed, 390 insertions, 230 deletions
diff --git a/internal/googlereader/handler.go b/internal/googlereader/handler.go index d3c0dfce..3c88d55f 100644 --- a/internal/googlereader/handler.go +++ b/internal/googlereader/handler.go @@ -6,19 +6,18 @@ package googlereader // import "miniflux.app/v2/internal/googlereader" import ( "errors" "fmt" + "log/slog" "net/http" - "net/http/httputil" "strconv" "strings" "time" - "github.com/gorilla/mux" "miniflux.app/v2/internal/config" "miniflux.app/v2/internal/http/request" + "miniflux.app/v2/internal/http/response" "miniflux.app/v2/internal/http/response/json" "miniflux.app/v2/internal/http/route" "miniflux.app/v2/internal/integration" - "miniflux.app/v2/internal/logger" "miniflux.app/v2/internal/model" "miniflux.app/v2/internal/proxy" mff "miniflux.app/v2/internal/reader/handler" @@ -26,6 +25,8 @@ import ( "miniflux.app/v2/internal/storage" "miniflux.app/v2/internal/urllib" "miniflux.app/v2/internal/validator" + + "github.com/gorilla/mux" ) type handler struct { @@ -201,24 +202,25 @@ func (r RequestModifiers) String() string { // Serve handles Google Reader API calls. func Serve(router *mux.Router, store *storage.Storage) { handler := &handler{store, router} + router.HandleFunc("/accounts/ClientLogin", handler.clientLoginHandler).Methods(http.MethodPost).Name("ClientLogin") + middleware := newMiddleware(store) - router.HandleFunc("/accounts/ClientLogin", middleware.clientLogin).Methods(http.MethodPost).Name("ClientLogin") sr := router.PathPrefix("/reader/api/0").Subrouter() sr.Use(middleware.handleCORS) sr.Use(middleware.apiKeyAuth) sr.Methods(http.MethodOptions) - sr.HandleFunc("/token", middleware.token).Methods(http.MethodGet).Name("Token") - sr.HandleFunc("/edit-tag", handler.editTag).Methods(http.MethodPost).Name("EditTag") - sr.HandleFunc("/rename-tag", handler.renameTag).Methods(http.MethodPost).Name("Rename Tag") - sr.HandleFunc("/disable-tag", handler.disableTag).Methods(http.MethodPost).Name("Disable Tag") - sr.HandleFunc("/tag/list", handler.tagList).Methods(http.MethodGet).Name("TagList") - sr.HandleFunc("/user-info", handler.userInfo).Methods(http.MethodGet).Name("UserInfo") - sr.HandleFunc("/subscription/list", handler.subscriptionList).Methods(http.MethodGet).Name("SubscriptonList") - sr.HandleFunc("/subscription/edit", handler.editSubscription).Methods(http.MethodPost).Name("SubscriptionEdit") - sr.HandleFunc("/subscription/quickadd", handler.quickAdd).Methods(http.MethodPost).Name("QuickAdd") - sr.HandleFunc("/stream/items/ids", handler.streamItemIDs).Methods(http.MethodGet).Name("StreamItemIDs") - sr.HandleFunc("/stream/items/contents", handler.streamItemContents).Methods(http.MethodPost).Name("StreamItemsContents") - sr.PathPrefix("/").HandlerFunc(handler.serve).Methods(http.MethodPost, http.MethodGet).Name("GoogleReaderApiEndpoint") + sr.HandleFunc("/token", handler.tokenHandler).Methods(http.MethodGet).Name("Token") + sr.HandleFunc("/edit-tag", handler.editTagHandler).Methods(http.MethodPost).Name("EditTag") + sr.HandleFunc("/rename-tag", handler.renameTagHandler).Methods(http.MethodPost).Name("Rename Tag") + sr.HandleFunc("/disable-tag", handler.disableTagHandler).Methods(http.MethodPost).Name("Disable Tag") + sr.HandleFunc("/tag/list", handler.tagListHandler).Methods(http.MethodGet).Name("TagList") + sr.HandleFunc("/user-info", handler.userInfoHandler).Methods(http.MethodGet).Name("UserInfo") + sr.HandleFunc("/subscription/list", handler.subscriptionListHandler).Methods(http.MethodGet).Name("SubscriptonList") + sr.HandleFunc("/subscription/edit", handler.editSubscriptionHandler).Methods(http.MethodPost).Name("SubscriptionEdit") + sr.HandleFunc("/subscription/quickadd", handler.quickAddHandler).Methods(http.MethodPost).Name("QuickAdd") + sr.HandleFunc("/stream/items/ids", handler.streamItemIDsHandler).Methods(http.MethodGet).Name("StreamItemIDs") + sr.HandleFunc("/stream/items/contents", handler.streamItemContentsHandler).Methods(http.MethodPost).Name("StreamItemsContents") + sr.PathPrefix("/").HandlerFunc(handler.serveHandler).Methods(http.MethodPost, http.MethodGet).Name("GoogleReaderApiEndpoint") } func getStreamFilterModifiers(r *http.Request) (RequestModifiers, error) { @@ -276,8 +278,7 @@ func getStream(streamID string, userID int64) (Stream, error) { case Like: return Stream{LikeStream, ""}, nil default: - err := fmt.Errorf("uknown stream with id: %s", id) - return Stream{NoStream, ""}, err + return Stream{NoStream, ""}, fmt.Errorf("googlereader: unknown stream with id: %s", id) } } else if strings.HasPrefix(streamID, fmt.Sprintf(UserLabelPrefix, userID)) || strings.HasPrefix(streamID, LabelPrefix) { id := strings.TrimPrefix(streamID, fmt.Sprintf(UserLabelPrefix, userID)) @@ -286,8 +287,8 @@ func getStream(streamID string, userID int64) (Stream, error) { } else if streamID == "" { return Stream{NoStream, ""}, nil } - err := fmt.Errorf("uknown stream type: %s", streamID) - return Stream{NoStream, ""}, err + + return Stream{NoStream, ""}, fmt.Errorf("googlereader: unknown stream type: %s", streamID) } func getStreams(streamIDs []string, userID int64) ([]Stream, error) { @@ -308,43 +309,43 @@ func checkAndSimplifyTags(addTags []Stream, removeTags []Stream) (map[StreamType switch s.Type { case ReadStream: if _, ok := tags[KeptUnreadStream]; ok { - return nil, fmt.Errorf(KeptUnread + " and " + Read + " should not be supplied simultaneously") + return nil, fmt.Errorf("googlereader: %s ad %s should not be supplied simultaneously", KeptUnread, Read) } tags[ReadStream] = true case KeptUnreadStream: if _, ok := tags[ReadStream]; ok { - return nil, fmt.Errorf(KeptUnread + " and " + Read + " should not be supplied simultaneously") + return nil, fmt.Errorf("googlereader: %s ad %s should not be supplied simultaneously", KeptUnread, Read) } tags[ReadStream] = false case StarredStream: tags[StarredStream] = true case BroadcastStream, LikeStream: - logger.Info("Broadcast & Like tags are not implemented!") + slog.Debug("Broadcast & Like tags are not implemented!") default: - return nil, fmt.Errorf("unsupported tag type: %s", s.Type) + return nil, fmt.Errorf("googlereader: unsupported tag type: %s", s.Type) } } for _, s := range removeTags { switch s.Type { case ReadStream: if _, ok := tags[ReadStream]; ok { - return nil, fmt.Errorf(KeptUnread + " and " + Read + " should not be supplied simultaneously") + return nil, fmt.Errorf("googlereader: %s ad %s should not be supplied simultaneously", KeptUnread, Read) } tags[ReadStream] = false case KeptUnreadStream: if _, ok := tags[ReadStream]; ok { - return nil, fmt.Errorf(KeptUnread + " and " + Read + " should not be supplied simultaneously") + return nil, fmt.Errorf("googlereader: %s ad %s should not be supplied simultaneously", KeptUnread, Read) } tags[ReadStream] = true case StarredStream: if _, ok := tags[StarredStream]; ok { - return nil, fmt.Errorf(Starred + " should not be supplied for add and remove simultaneously") + return nil, fmt.Errorf("googlereader: %s should not be supplied for add and remove simultaneously", Starred) } tags[StarredStream] = false case BroadcastStream, LikeStream: - logger.Info("Broadcast & Like tags are not implemented!") + slog.Debug("Broadcast & Like tags are not implemented!") default: - return nil, fmt.Errorf("unsupported tag type: %s", s.Type) + return nil, fmt.Errorf("googlereader: unsupported tag type: %s", s.Type) } } @@ -354,7 +355,7 @@ func checkAndSimplifyTags(addTags []Stream, removeTags []Stream) (map[StreamType func getItemIDs(r *http.Request) ([]int64, error) { items := r.Form[ParamItemIDs] if len(items) == 0 { - return nil, fmt.Errorf("no items requested") + return nil, fmt.Errorf("googlereader: no items requested") } itemIDs := make([]int64, len(items)) @@ -365,7 +366,7 @@ func getItemIDs(r *http.Request) ([]int64, error) { if err != nil { itemID, err = strconv.ParseInt(item, 16, 64) if err != nil { - return nil, fmt.Errorf("could not parse item: %v", item) + return nil, fmt.Errorf("googlereader: could not parse item: %v", item) } } itemIDs[i] = itemID @@ -385,66 +386,191 @@ func checkOutputFormat(w http.ResponseWriter, r *http.Request) error { output = request.QueryStringParam(r, "output", "") } if output != "json" { - err := fmt.Errorf("output only as json supported") + err := fmt.Errorf("googlereader: only json output is supported") return err } return nil } -func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { - userID := request.UserID(r) +func (h *handler) clientLoginHandler(w http.ResponseWriter, r *http.Request) { clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/edit-tag][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /accounts/ClientLogin", + slog.String("handler", "clientLoginHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + + if err := r.ParseForm(); err != nil { + slog.Warn("[GoogleReader] Could not parse request form data", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("error", err), + ) + json.Unauthorized(w, r) + return + } - err := r.ParseForm() + username := r.Form.Get("Email") + password := r.Form.Get("Passwd") + output := r.Form.Get("output") + + if username == "" || password == "" { + slog.Warn("[GoogleReader] Empty username or password", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + json.Unauthorized(w, r) + return + } + + if err := h.store.GoogleReaderUserCheckPassword(username, password); err != nil { + slog.Warn("[GoogleReader] Invalid username or password", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.String("username", username), + slog.Any("error", err), + ) + json.Unauthorized(w, r) + return + } + + slog.Info("[GoogleReader] User authenticated successfully", + slog.Bool("authentication_successful", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.String("username", username), + ) + + integration, err := h.store.GoogleReaderUserGetIntegration(username) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) + json.ServerError(w, r, err) + return + } + + h.store.SetLastLogin(integration.UserID) + + token := getAuthToken(integration.GoogleReaderUsername, integration.GoogleReaderPassword) + slog.Debug("[GoogleReader] Created token", + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.String("username", username), + ) + + result := login{SID: token, LSID: token, Auth: token} + if output == "json" { + json.OK(w, r, result) + return + } + + builder := response.New(w, r) + builder.WithHeader("Content-Type", "text/plain; charset=UTF-8") + builder.WithBody(result.String()) + builder.Write() +} + +func (h *handler) tokenHandler(w http.ResponseWriter, r *http.Request) { + clientIP := request.ClientIP(r) + + slog.Debug("[GoogleReader] Handle /token", + slog.String("handler", "tokenHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + + if !request.IsAuthenticated(r) { + slog.Warn("[GoogleReader] User is not authenticated", + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + json.Unauthorized(w, r) + return + } + + token := request.GoolgeReaderToken(r) + if token == "" { + slog.Warn("[GoogleReader] User does not have token", + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", request.UserID(r)), + ) + json.Unauthorized(w, r) + return + } + + slog.Debug("[GoogleReader] Token handler", + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", request.UserID(r)), + slog.String("token", token), + ) + + w.Header().Add("Content-Type", "text/plain; charset=UTF-8") + w.WriteHeader(http.StatusOK) + w.Write([]byte(token)) +} + +func (h *handler) editTagHandler(w http.ResponseWriter, r *http.Request) { + userID := request.UserID(r) + clientIP := request.ClientIP(r) + + slog.Debug("[GoogleReader] Handle /edit-tag", + slog.String("handler", "editTagHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + ) + + if err := r.ParseForm(); err != nil { json.ServerError(w, r, err) return } addTags, err := getStreams(r.PostForm[ParamTagsAdd], userID) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } removeTags, err := getStreams(r.PostForm[ParamTagsRemove], userID) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } if len(addTags) == 0 && len(removeTags) == 0 { - err = fmt.Errorf("add or/and remove tags should be supplied") - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] ", clientIP, err) + err = fmt.Errorf("googlreader: add or/and remove tags should be supplied") json.ServerError(w, r, err) return } tags, err := checkAndSimplifyTags(addTags, removeTags) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } itemIDs, err := getItemIDs(r) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } - logger.Debug("[GoogleReader][/edit-tag] [ClientIP=%s] itemIDs: %v", clientIP, itemIDs) - logger.Debug("[GoogleReader][/edit-tag] [ClientIP=%s] tags: %v", clientIP, tags) + slog.Debug("[GoogleReader] Edited tags", + slog.String("handler", "editTagHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + slog.Any("item_ids", itemIDs), + slog.Any("tags", tags), + ) + builder := h.store.NewEntryQueryBuilder(userID) builder.WithEntryIDs(itemIDs) builder.WithoutStatus(model.EntryStatusRemoved) entries, err := builder.GetEntries() if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -477,7 +603,6 @@ func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { if len(readEntryIDs) > 0 { err = h.store.SetEntriesStatus(userID, readEntryIDs, model.EntryStatusRead) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -486,7 +611,6 @@ func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { if len(unreadEntryIDs) > 0 { err = h.store.SetEntriesStatus(userID, unreadEntryIDs, model.EntryStatusUnread) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -495,7 +619,6 @@ func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { if len(unstarredEntryIDs) > 0 { err = h.store.SetEntriesBookmarkedState(userID, unstarredEntryIDs, false) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -504,7 +627,6 @@ func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { if len(starredEntryIDs) > 0 { err = h.store.SetEntriesBookmarkedState(userID, starredEntryIDs, true) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -513,7 +635,6 @@ func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { if len(entries) > 0 { settings, err := h.store.Integration(userID) if err != nil { - logger.Error("[GoogleReader][/edit-tag] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -529,22 +650,26 @@ func (h *handler) editTag(w http.ResponseWriter, r *http.Request) { OK(w, r) } -func (h *handler) quickAdd(w http.ResponseWriter, r *http.Request) { +func (h *handler) quickAddHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/subscription/quickadd][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /subscription/quickadd", + slog.String("handler", "quickAddHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + ) err := r.ParseForm() if err != nil { - logger.Error("[GoogleReader][/subscription/quickadd] [ClientIP=%s] %v", clientIP, err) json.BadRequest(w, r, err) return } url := r.Form.Get(ParamQuickAdd) if !validator.IsValidURL(url) { - json.BadRequest(w, r, fmt.Errorf("invalid URL: %s", url)) + json.BadRequest(w, r, fmt.Errorf("googlereader: invalid URL: %s", url)) return } @@ -568,6 +693,15 @@ func (h *handler) quickAdd(w http.ResponseWriter, r *http.Request) { json.ServerError(w, r, err) return } + + slog.Debug("[GoogleReader] Added a new feed", + slog.String("handler", "quickAddHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + slog.String("feed_url", newFeed.FeedURL), + ) + json.OK(w, r, quickAddResponse{ NumResults: 1, Query: newFeed.FeedURL, @@ -675,34 +809,37 @@ func move(stream Stream, destination Stream, store *storage.Storage, userID int6 return store.UpdateFeed(feed) } -func (h *handler) editSubscription(w http.ResponseWriter, r *http.Request) { +func (h *handler) editSubscriptionHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/subscription/edit][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /subscription/edit", + slog.String("handler", "editSubscriptionHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + ) - err := r.ParseForm() - if err != nil { - logger.Error("[GoogleReader][/subscription/edit] [ClientIP=%s] %v", clientIP, err) + if err := r.ParseForm(); err != nil { json.BadRequest(w, r, err) return } streamIds, err := getStreams(r.Form[ParamStreamID], userID) if err != nil || len(streamIds) == 0 { - json.BadRequest(w, r, errors.New("no valid stream IDs provided")) + json.BadRequest(w, r, errors.New("googlereader: no valid stream IDs provided")) return } newLabel, err := getStream(r.Form.Get(ParamTagsAdd), userID) if err != nil { - json.BadRequest(w, r, fmt.Errorf("invalid data in %s", ParamTagsAdd)) + json.BadRequest(w, r, fmt.Errorf("googlereader: invalid data in %s", ParamTagsAdd)) return } title := r.Form.Get(ParamTitle) - action := r.Form.Get(ParamSubscribeAction) + switch action { case "subscribe": _, err := subscribe(streamIds[0], newLabel, title, h.store, userID) @@ -735,41 +872,42 @@ func (h *handler) editSubscription(w http.ResponseWriter, r *http.Request) { } } default: - json.ServerError(w, r, fmt.Errorf("unrecognized action %s", action)) + json.ServerError(w, r, fmt.Errorf("googlereader: unrecognized action %s", action)) return } OK(w, r) } -func (h *handler) streamItemContents(w http.ResponseWriter, r *http.Request) { +func (h *handler) streamItemContentsHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/stream/items/contents][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /stream/items/contents", + slog.String("handler", "streamItemContentsHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + ) if err := checkOutputFormat(w, r); err != nil { - logger.Error("[GoogleReader][/stream/items/contents] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } err := r.ParseForm() if err != nil { - logger.Error("[GoogleReader][/stream/items/contents] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } var user *model.User if user, err = h.store.UserByID(userID); err != nil { - logger.Error("[GoogleReader][/stream/items/contents] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } requestModifiers, err := getStreamFilterModifiers(r) if err != nil { - logger.Error("[GoogleReader][/stream/items/contents] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -780,11 +918,17 @@ func (h *handler) streamItemContents(w http.ResponseWriter, r *http.Request) { itemIDs, err := getItemIDs(r) if err != nil { - logger.Error("[GoogleReader][/stream/items/contents] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } - logger.Debug("[GoogleReader][/stream/items/contents] [ClientIP=%s] itemIDs: %v", clientIP, itemIDs) + + slog.Debug("[GoogleReader] Fetching item contents", + slog.String("handler", "streamItemContentsHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + slog.Any("item_ids", itemIDs), + ) builder := h.store.NewEntryQueryBuilder(userID) builder.WithoutStatus(model.EntryStatusRemoved) @@ -796,12 +940,12 @@ func (h *handler) streamItemContents(w http.ResponseWriter, r *http.Request) { json.ServerError(w, r, err) return } + if len(entries) == 0 { - err = fmt.Errorf("no items returned from the database") - logger.Error("[GoogleReader][/stream/items/contents] [ClientIP=%s] %v", clientIP, err) - json.ServerError(w, r, err) + json.ServerError(w, r, fmt.Errorf("googlereader: no items returned from the database")) return } + result := streamContentItems{ Direction: "ltr", ID: fmt.Sprintf("feed/%d", entries[0].FeedID), @@ -893,29 +1037,33 @@ func (h *handler) streamItemContents(w http.ResponseWriter, r *http.Request) { json.OK(w, r, result) } -func (h *handler) disableTag(w http.ResponseWriter, r *http.Request) { +func (h *handler) disableTagHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/disable-tag][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /disable-tags", + slog.String("handler", "disableTagHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + ) err := r.ParseForm() if err != nil { - logger.Error("[GoogleReader][/disable-tag] [ClientIP=%s] %v", clientIP, err) json.BadRequest(w, r, err) return } streams, err := getStreams(r.Form[ParamStreamID], userID) if err != nil { - json.BadRequest(w, r, fmt.Errorf("invalid data in %s", ParamStreamID)) + json.BadRequest(w, r, fmt.Errorf("googlereader: invalid data in %s", ParamStreamID)) return } titles := make([]string, len(streams)) for i, stream := range streams { if stream.Type != LabelStream { - json.BadRequest(w, r, errors.New("only labels are supported")) + json.BadRequest(w, r, errors.New("googlereader: only labels are supported")) return } titles[i] = stream.ID @@ -930,38 +1078,41 @@ func (h *handler) disableTag(w http.ResponseWriter, r *http.Request) { OK(w, r) } -func (h *handler) renameTag(w http.ResponseWriter, r *http.Request) { +func (h *handler) renameTagHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/rename-tag][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /rename-tag", + slog.String("handler", "renameTagHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) err := r.ParseForm() if err != nil { - logger.Error("[GoogleReader][/rename-tag] [ClientIP=%s] %v", clientIP, err) json.BadRequest(w, r, err) return } source, err := getStream(r.Form.Get(ParamStreamID), userID) if err != nil { - json.BadRequest(w, r, fmt.Errorf("invalid data in %s", ParamStreamID)) + json.BadRequest(w, r, fmt.Errorf("googlereader: invalid data in %s", ParamStreamID)) return } destination, err := getStream(r.Form.Get(ParamDestination), userID) if err != nil { - json.BadRequest(w, r, fmt.Errorf("invalid data in %s", ParamDestination)) + json.BadRequest(w, r, fmt.Errorf("googlereader: invalid data in %s", ParamDestination)) return } if source.Type != LabelStream || destination.Type != LabelStream { - json.BadRequest(w, r, errors.New("only labels supported")) + json.BadRequest(w, r, errors.New("googlereader: only labels supported")) return } if destination.ID == "" { - json.BadRequest(w, r, errors.New("empty destination name")) + json.BadRequest(w, r, errors.New("googlereader: empty destination name")) return } @@ -991,14 +1142,17 @@ func (h *handler) renameTag(w http.ResponseWriter, r *http.Request) { OK(w, r) } -func (h *handler) tagList(w http.ResponseWriter, r *http.Request) { +func (h *handler) tagListHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][tags/list][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /tags/list", + slog.String("handler", "tagListHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) if err := checkOutputFormat(w, r); err != nil { - logger.Error("[GoogleReader][OutputFormat] %v", err) json.BadRequest(w, r, err) return } @@ -1023,14 +1177,17 @@ func (h *handler) tagList(w http.ResponseWriter, r *http.Request) { json.OK(w, r, result) } -func (h *handler) subscriptionList(w http.ResponseWriter, r *http.Request) { +func (h *handler) subscriptionListHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/subscription/list][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /subscription/list", + slog.String("handler", "subscriptionListHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) if err := checkOutputFormat(w, r); err != nil { - logger.Error("[GoogleReader][/subscription/list] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1055,27 +1212,34 @@ func (h *handler) subscriptionList(w http.ResponseWriter, r *http.Request) { json.OK(w, r, result) } -func (h *handler) serve(w http.ResponseWriter, r *http.Request) { +func (h *handler) serveHandler(w http.ResponseWriter, r *http.Request) { clientIP := request.ClientIP(r) - dump, _ := httputil.DumpRequest(r, true) - logger.Info("[GoogleReader][UNKNOWN] [ClientIP=%s] URL: %s", clientIP, dump) - logger.Error("Call to Google Reader API not implemented yet!!") + + slog.Debug("[GoogleReader] API endpoint not implemented yet", + slog.Any("url", r.RequestURI), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + json.OK(w, r, []string{}) } -func (h *handler) userInfo(w http.ResponseWriter, r *http.Request) { +func (h *handler) userInfoHandler(w http.ResponseWriter, r *http.Request) { clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][UserInfo] [ClientIP=%s] Sending", clientIP) + + slog.Debug("[GoogleReader] Handle /user-info", + slog.String("handler", "userInfoHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) if err := checkOutputFormat(w, r); err != nil { - logger.Error("[GoogleReader][/user-info] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } user, err := h.store.UserByID(request.UserID(r)) if err != nil { - logger.Error("[GoogleReader][/user-info] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1083,16 +1247,19 @@ func (h *handler) userInfo(w http.ResponseWriter, r *http.Request) { json.OK(w, r, userInfo) } -func (h *handler) streamItemIDs(w http.ResponseWriter, r *http.Request) { +func (h *handler) streamItemIDsHandler(w http.ResponseWriter, r *http.Request) { userID := request.UserID(r) clientIP := request.ClientIP(r) - logger.Info("[GoogleReader][/stream/items/ids][ClientIP=%s] Incoming Request for userID #%d", clientIP, userID) + slog.Debug("[GoogleReader] Handle /stream/items/ids", + slog.String("handler", "streamItemIDsHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", userID), + ) if err := checkOutputFormat(w, r); err != nil { - err := fmt.Errorf("output only as json supported") - logger.Error("[GoogleReader][/stream/items/ids] [ClientIP=%s] %v", clientIP, err) - json.ServerError(w, r, err) + json.ServerError(w, r, fmt.Errorf("googlereader: output only as json supported")) return } @@ -1101,44 +1268,62 @@ func (h *handler) streamItemIDs(w http.ResponseWriter, r *http.Request) { json.ServerError(w, r, err) return } - logger.Debug("Request Modifiers: %v", rm) + + slog.Debug("[GoogleReader] Request modifiers", + slog.String("handler", "streamItemIDsHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("modifiers", rm), + ) + if len(rm.Streams) != 1 { - err := fmt.Errorf("only one stream type expected") - logger.Error("[GoogleReader][/stream/items/ids] [ClientIP=%s] %v", clientIP, err) - json.ServerError(w, r, err) + json.ServerError(w, r, fmt.Errorf("googlereader: only one stream type expected")) return } switch rm.Streams[0].Type { case ReadingListStream: - h.handleReadingListStream(w, r, rm) + h.handleReadingListStreamHandler(w, r, rm) case StarredStream: - h.handleStarredStream(w, r, rm) + h.handleStarredStreamHandler(w, r, rm) case ReadStream: - h.handleReadStream(w, r, rm) + h.handleReadStreamHandler(w, r, rm) case FeedStream: - h.handleFeedStream(w, r, rm) + h.handleFeedStreamHandler(w, r, rm) default: - dump, _ := httputil.DumpRequest(r, true) - logger.Info("[GoogleReader][/stream/items/ids] [ClientIP=%s] Unknown Stream: %s", clientIP, dump) - err := fmt.Errorf("unknown stream type") - logger.Error("[GoogleReader][/stream/items/ids] [ClientIP=%s] %v", clientIP, err) - json.ServerError(w, r, err) - return + slog.Warn("[GoogleReader] Unknown Stream", + slog.String("handler", "streamItemIDsHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("stream_type", rm.Streams[0].Type), + ) + json.ServerError(w, r, fmt.Errorf("googlereader: unknown stream type %s", rm.Streams[0].Type)) } } -func (h *handler) handleReadingListStream(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { +func (h *handler) handleReadingListStreamHandler(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { clientIP := request.ClientIP(r) + slog.Debug("[GoogleReader] Handle ReadingListStream", + slog.String("handler", "handleReadingListStreamHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + builder := h.store.NewEntryQueryBuilder(rm.UserID) for _, s := range rm.ExcludeTargets { switch s.Type { case ReadStream: builder.WithStatus(model.EntryStatusUnread) default: - logger.Info("[GoogleReader][ReadingListStreamIDs][ClientIP=%s] xt filter type: %#v", clientIP, s) + slog.Warn("[GoogleReader] Unknown ExcludeTargets filter type", + slog.String("handler", "handleReadingListStreamHandler"), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("filter_type", s.Type), + ) } } + builder.WithoutStatus(model.EntryStatusRemoved) builder.WithLimit(rm.Count) builder.WithOffset(rm.Offset) @@ -1152,7 +1337,6 @@ func (h *handler) handleReadingListStream(w http.ResponseWriter, r *http.Request rawEntryIDs, err := builder.GetEntryIDs() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#reading-list] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1164,7 +1348,6 @@ func (h *handler) handleReadingListStream(w http.ResponseWriter, r *http.Request totalEntries, err := builder.CountEntries() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#reading-list] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1176,9 +1359,7 @@ func (h *handler) handleReadingListStream(w http.ResponseWriter, r *http.Request json.OK(w, r, streamIDResponse{itemRefs, continuation}) } -func (h *handler) handleStarredStream(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { - clientIP := request.ClientIP(r) - +func (h *handler) handleStarredStreamHandler(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { builder := h.store.NewEntryQueryBuilder(rm.UserID) builder.WithoutStatus(model.EntryStatusRemoved) builder.WithStarred(true) @@ -1194,7 +1375,6 @@ func (h *handler) handleStarredStream(w http.ResponseWriter, r *http.Request, rm rawEntryIDs, err := builder.GetEntryIDs() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#starred] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1206,7 +1386,6 @@ func (h *handler) handleStarredStream(w http.ResponseWriter, r *http.Request, rm totalEntries, err := builder.CountEntries() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#starred] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1218,9 +1397,7 @@ func (h *handler) handleStarredStream(w http.ResponseWriter, r *http.Request, rm json.OK(w, r, streamIDResponse{itemRefs, continuation}) } -func (h *handler) handleReadStream(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { - clientIP := request.ClientIP(r) - +func (h *handler) handleReadStreamHandler(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { builder := h.store.NewEntryQueryBuilder(rm.UserID) builder.WithoutStatus(model.EntryStatusRemoved) builder.WithStatus(model.EntryStatusRead) @@ -1236,7 +1413,6 @@ func (h *handler) handleReadStream(w http.ResponseWriter, r *http.Request, rm Re rawEntryIDs, err := builder.GetEntryIDs() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#read] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1248,7 +1424,6 @@ func (h *handler) handleReadStream(w http.ResponseWriter, r *http.Request, rm Re totalEntries, err := builder.CountEntries() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#read] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1260,11 +1435,9 @@ func (h *handler) handleReadStream(w http.ResponseWriter, r *http.Request, rm Re json.OK(w, r, streamIDResponse{itemRefs, continuation}) } -func (h *handler) handleFeedStream(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { - clientIP := request.ClientIP(r) +func (h *handler) handleFeedStreamHandler(w http.ResponseWriter, r *http.Request, rm RequestModifiers) { feedID, err := strconv.ParseInt(rm.Streams[0].ID, 10, 64) if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#feed] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1284,7 +1457,6 @@ func (h *handler) handleFeedStream(w http.ResponseWriter, r *http.Request, rm Re rawEntryIDs, err := builder.GetEntryIDs() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#feed] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } @@ -1296,7 +1468,6 @@ func (h *handler) handleFeedStream(w http.ResponseWriter, r *http.Request, rm Re totalEntries, err := builder.CountEntries() if err != nil { - logger.Error("[GoogleReader][/stream/items/ids#feed] [ClientIP=%s] %v", clientIP, err) json.ServerError(w, r, err) return } diff --git a/internal/googlereader/middleware.go b/internal/googlereader/middleware.go index 1bfc1a6e..280868b8 100644 --- a/internal/googlereader/middleware.go +++ b/internal/googlereader/middleware.go @@ -8,13 +8,11 @@ import ( "crypto/hmac" "crypto/sha1" "encoding/hex" + "log/slog" "net/http" "strings" "miniflux.app/v2/internal/http/request" - "miniflux.app/v2/internal/http/response" - "miniflux.app/v2/internal/http/response/json" - "miniflux.app/v2/internal/logger" "miniflux.app/v2/internal/model" "miniflux.app/v2/internal/storage" ) @@ -27,75 +25,6 @@ func newMiddleware(s *storage.Storage) *middleware { return &middleware{s} } -func (m *middleware) clientLogin(w http.ResponseWriter, r *http.Request) { - clientIP := request.ClientIP(r) - var username, password, output string - var integration *model.Integration - err := r.ParseForm() - if err != nil { - logger.Error("[GoogleReader][Login] [ClientIP=%s] Could not parse form", clientIP) - json.Unauthorized(w, r) - return - } - username = r.Form.Get("Email") - password = r.Form.Get("Passwd") - output = r.Form.Get("output") - - if username == "" || password == "" { - logger.Error("[GoogleReader][Login] [ClientIP=%s] Empty username or password", clientIP) - json.Unauthorized(w, r) - return - } - - if err = m.store.GoogleReaderUserCheckPassword(username, password); err != nil { - logger.Error("[GoogleReader][Login] [ClientIP=%s] Invalid username or password: %s", clientIP, username) - json.Unauthorized(w, r) - return - } - - logger.Info("[GoogleReader][Login] [ClientIP=%s] User authenticated: %s", clientIP, username) - - if integration, err = m.store.GoogleReaderUserGetIntegration(username); err != nil { - logger.Error("[GoogleReader][Login] [ClientIP=%s] Could not load integration: %s", clientIP, username) - json.Unauthorized(w, r) - return - } - - m.store.SetLastLogin(integration.UserID) - - token := getAuthToken(integration.GoogleReaderUsername, integration.GoogleReaderPassword) - logger.Info("[GoogleReader][Login] [ClientIP=%s] Created token: %s", clientIP, token) - result := login{SID: token, LSID: token, Auth: token} - if output == "json" { - json.OK(w, r, result) - return - } - builder := response.New(w, r) - builder.WithHeader("Content-Type", "text/plain; charset=UTF-8") - builder.WithBody(result.String()) - builder.Write() -} - -func (m *middleware) token(w http.ResponseWriter, r *http.Request) { - clientIP := request.ClientIP(r) - - if !request.IsAuthenticated(r) { - logger.Error("[GoogleReader][Token] [ClientIP=%s] User is not authenticated", clientIP) - json.Unauthorized(w, r) - return - } - token := request.GoolgeReaderToken(r) - if token == "" { - logger.Error("[GoogleReader][Token] [ClientIP=%s] User does not have token: %s", clientIP, request.UserID(r)) - json.Unauthorized(w, r) - return - } - logger.Info("[GoogleReader][Token] [ClientIP=%s] token: %s", clientIP, token) - w.Header().Add("Content-Type", "text/plain; charset=UTF-8") - w.WriteHeader(http.StatusOK) - w.Write([]byte(token)) -} - func (m *middleware) handleCORS(next http.Handler) http.Handler { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.Header().Set("Access-Control-Allow-Origin", "*") @@ -115,15 +44,24 @@ func (m *middleware) apiKeyAuth(next http.Handler) http.Handler { var token string if r.Method == http.MethodPost { - err := r.ParseForm() - if err != nil { - logger.Error("[GoogleReader][Login] [ClientIP=%s] Could not parse form", clientIP) + if err := r.ParseForm(); err != nil { + slog.Warn("[GoogleReader] Could not parse request form data", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("error", err), + ) Unauthorized(w, r) return } + token = r.Form.Get("T") if token == "" { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Post-Form T field is empty", clientIP) + slog.Warn("[GoogleReader] Post-Form T field is empty", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } @@ -131,29 +69,49 @@ func (m *middleware) apiKeyAuth(next http.Handler) http.Handler { authorization := r.Header.Get("Authorization") if authorization == "" { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] No token provided", clientIP) + slog.Warn("[GoogleReader] No token provided", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } fields := strings.Fields(authorization) if len(fields) != 2 { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Authorization header does not have the expected structure GoogleLogin auth=xxxxxx - '%s'", clientIP, authorization) + slog.Warn("[GoogleReader] Authorization header does not have the expected GoogleLogin format auth=xxxxxx", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } if fields[0] != "GoogleLogin" { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Authorization header does not begin with GoogleLogin - '%s'", clientIP, authorization) + slog.Warn("[GoogleReader] Authorization header does not begin with GoogleLogin", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } auths := strings.Split(fields[1], "=") if len(auths) != 2 { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Authorization header does not have the expected structure GoogleLogin auth=xxxxxx - '%s'", clientIP, authorization) + slog.Warn("[GoogleReader] Authorization header does not have the expected GoogleLogin format auth=xxxxxx", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } if auths[0] != "auth" { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Authorization header does not have the expected structure GoogleLogin auth=xxxxxx - '%s'", clientIP, authorization) + slog.Warn("[GoogleReader] Authorization header does not have the expected GoogleLogin format auth=xxxxxx", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } @@ -162,7 +120,12 @@ func (m *middleware) apiKeyAuth(next http.Handler) http.Handler { parts := strings.Split(token, "/") if len(parts) != 2 { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Auth token does not have the expected structure username/hash - '%s'", clientIP, token) + slog.Warn("[GoogleReader] Auth token does not have the expected structure username/hash", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.String("token", token), + ) Unauthorized(w, r) return } @@ -170,23 +133,54 @@ func (m *middleware) apiKeyAuth(next http.Handler) http.Handler { var user *model.User var err error if integration, err = m.store.GoogleReaderUserGetIntegration(parts[0]); err != nil { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] token: %s", clientIP, token) - logger.Error("[GoogleReader][Auth] [ClientIP=%s] No user found with the given google reader username: %s", clientIP, parts[0]) + slog.Warn("[GoogleReader] No user found with the given Google Reader username", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("error", err), + ) Unauthorized(w, r) return } expectedToken := getAuthToken(integration.GoogleReaderUsername, integration.GoogleReaderPassword) if expectedToken != token { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] Token does not match: %s", clientIP, token) + slog.Warn("[GoogleReader] Token does not match", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) Unauthorized(w, r) return } if user, err = m.store.UserByID(integration.UserID); err != nil { - logger.Error("[GoogleReader][Auth] [ClientIP=%s] No user found with the userID: %d", clientIP, integration.UserID) + slog.Error("[GoogleReader] Unable to fetch user from database", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Any("error", err), + ) Unauthorized(w, r) return } + if user == nil { + slog.Warn("[GoogleReader] No user found with the given Google Reader credentials", + slog.Bool("authentication_failed", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + ) + Unauthorized(w, r) + return + } + + slog.Info("[GoogleReader] User authenticated successfully", + slog.Bool("authentication_successful", true), + slog.String("client_ip", clientIP), + slog.String("user_agent", r.UserAgent()), + slog.Int64("user_id", user.ID), + slog.String("username", user.Username), + ) + m.store.SetLastLogin(integration.UserID) ctx := r.Context() diff --git a/internal/googlereader/response.go b/internal/googlereader/response.go index 6d97bf38..9a6ad378 100644 --- a/internal/googlereader/response.go +++ b/internal/googlereader/response.go @@ -8,7 +8,6 @@ import ( "net/http" "miniflux.app/v2/internal/http/response" - "miniflux.app/v2/internal/logger" ) type login struct { @@ -122,8 +121,6 @@ type contentItemOrigin struct { // Unauthorized sends a not authorized error to the client. func Unauthorized(w http.ResponseWriter, r *http.Request) { - logger.Error("[HTTP:Unauthorized] %s", r.URL) - builder := response.New(w, r) builder.WithStatus(http.StatusUnauthorized) builder.WithHeader("Content-Type", "text/plain") @@ -134,8 +131,6 @@ func Unauthorized(w http.ResponseWriter, r *http.Request) { // OK sends a ok response to the client. func OK(w http.ResponseWriter, r *http.Request) { - logger.Info("[HTTP:OK] %s", r.URL) - builder := response.New(w, r) builder.WithStatus(http.StatusOK) builder.WithHeader("Content-Type", "text/plain") |