From eb4bca6eb796fd1032a46756b5de0aa16f5fbd82 Mon Sep 17 00:00:00 2001
From: Frédéric Guillot <f@miniflux.net>
Date: Sun, 18 Aug 2024 12:07:57 -0700
Subject: fix: `store.GetEnclosure()` should return `nil` if no rows are
 returned

---
 internal/api/api_integration_test.go | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

(limited to 'internal/api/api_integration_test.go')

diff --git a/internal/api/api_integration_test.go b/internal/api/api_integration_test.go
index 3fd98119..1d06fb8c 100644
--- a/internal/api/api_integration_test.go
+++ b/internal/api/api_integration_test.go
@@ -67,10 +67,14 @@ func TestIncorrectEndpoint(t *testing.T) {
 	}
 
 	client := miniflux.NewClient("incorrect url")
-	_, err := client.Users()
-	if err == nil {
+	if _, err := client.Users(); err == nil {
 		t.Fatal(`Using an incorrect URL should raise an error`)
 	}
+
+	client = miniflux.NewClient("")
+	if _, err := client.Users(); err == nil {
+		t.Fatal(`Using an empty URL should raise an error`)
+	}
 }
 
 func TestHealthcheckEndpoint(t *testing.T) {
@@ -2074,7 +2078,6 @@ func TestUpdateEnclosureEndpoint(t *testing.T) {
 	}
 
 	var enclosure *miniflux.Enclosure
-
 	for _, entry := range result.Entries {
 		if len(entry.Enclosures) > 0 {
 			enclosure = entry.Enclosures[0]
@@ -2089,13 +2092,11 @@ func TestUpdateEnclosureEndpoint(t *testing.T) {
 	err = regularUserClient.UpdateEnclosure(enclosure.ID, &miniflux.EnclosureUpdateRequest{
 		MediaProgression: 20,
 	})
-
 	if err != nil {
 		t.Fatal(err)
 	}
 
 	updatedEnclosure, err := regularUserClient.Enclosure(enclosure.ID)
-
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -2134,7 +2135,6 @@ func TestGetEnclosureEndpoint(t *testing.T) {
 	}
 
 	var expectedEnclosure *miniflux.Enclosure
-
 	for _, entry := range result.Entries {
 		if len(entry.Enclosures) > 0 {
 			expectedEnclosure = entry.Enclosures[0]
@@ -2147,7 +2147,6 @@ func TestGetEnclosureEndpoint(t *testing.T) {
 	}
 
 	enclosure, err := regularUserClient.Enclosure(expectedEnclosure.ID)
-
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -2155,7 +2154,12 @@ func TestGetEnclosureEndpoint(t *testing.T) {
 	if enclosure.ID != expectedEnclosure.ID {
 		t.Fatalf(`Invalid enclosureID, got %d while expecting %d`, enclosure.ID, expectedEnclosure.ID)
 	}
+
+	if _, err = regularUserClient.Enclosure(99999); err == nil {
+		t.Fatalf(`Fetching an inexisting enclosure should raise an error`)
+	}
 }
+
 func TestGetEntryEndpoints(t *testing.T) {
 	testConfig := newIntegrationTestConfig()
 	if !testConfig.isConfigured() {
-- 
cgit v1.2.3