From 8d80e9103f836284b73bc8d176c5ca63c31b0dfc Mon Sep 17 00:00:00 2001 From: jvoisin Date: Mon, 4 Mar 2024 00:32:16 +0100 Subject: Delay call of `view.New` after logging the user in There is no need to do extra work like creating a session and its associated view until the user has been properly identified and as many possibly-failing sql request have been successfully run. --- internal/ui/api_key_list.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'internal/ui/api_key_list.go') diff --git a/internal/ui/api_key_list.go b/internal/ui/api_key_list.go index 14879196..fafb8628 100644 --- a/internal/ui/api_key_list.go +++ b/internal/ui/api_key_list.go @@ -13,9 +13,6 @@ import ( ) func (h *handler) showAPIKeysPage(w http.ResponseWriter, r *http.Request) { - sess := session.New(h.store, request.SessionID(r)) - view := view.New(h.tpl, r, sess) - user, err := h.store.UserByID(request.UserID(r)) if err != nil { html.ServerError(w, r, err) @@ -28,6 +25,8 @@ func (h *handler) showAPIKeysPage(w http.ResponseWriter, r *http.Request) { return } + sess := session.New(h.store, request.SessionID(r)) + view := view.New(h.tpl, r, sess) view.Set("apiKeys", apiKeys) view.Set("menu", "settings") view.Set("user", user) -- cgit v1.2.3