From beb8c80787beadbfdb8b970368a3200f7d59f58e Mon Sep 17 00:00:00 2001 From: jvoisin Date: Wed, 20 Mar 2024 23:59:37 +0100 Subject: Replace a bunch of `let` with `const` According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const > Many style guides (including MDN's) recommend using const over let whenever a variable is not reassigned in its scope. This makes the intent clear that a variable's type (or value, in the case of a primitive) can never change. --- internal/ui/static/js/dom_helper.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'internal/ui/static/js/dom_helper.js') diff --git a/internal/ui/static/js/dom_helper.js b/internal/ui/static/js/dom_helper.js index 352d6b03..0bad0d52 100644 --- a/internal/ui/static/js/dom_helper.js +++ b/internal/ui/static/js/dom_helper.js @@ -4,17 +4,17 @@ class DomHelper { } static openNewTab(url) { - let win = window.open(""); + const win = window.open(""); win.opener = null; win.location = url; win.focus(); } static scrollPageTo(element, evenIfOnScreen) { - let windowScrollPosition = window.pageYOffset; - let windowHeight = document.documentElement.clientHeight; - let viewportPosition = windowScrollPosition + windowHeight; - let itemBottomPosition = element.offsetTop + element.offsetHeight; + const windowScrollPosition = window.pageYOffset; + const windowHeight = document.documentElement.clientHeight; + const viewportPosition = windowScrollPosition + windowHeight; + const itemBottomPosition = element.offsetTop + element.offsetHeight; if (evenIfOnScreen || viewportPosition - itemBottomPosition < 0 || viewportPosition - element.offsetTop > windowHeight) { window.scrollTo(0, element.offsetTop - 10); -- cgit v1.2.3