From 344a237af87e07c51ca73e3b6f1c23598613996d Mon Sep 17 00:00:00 2001 From: Andrew Gunnerson Date: Tue, 5 Sep 2023 17:36:28 -0400 Subject: touch_handler: Fix scroll up behavior on Firefox Android When the touchmove listener is registered with passive: false, scrolling up on Firefox Android only works every other attempt. When scrolling breaks, the touchmove callback is never invoked. The passive flag was originally set to false as part of a fix to prevent vertical scrolling while swiping: 3f3174491103fc5a96b36918d8eada778f5b7210. Setting passive to true doesn't seem to negatively affect that in both Firefox and Chrome, but fixes the scoll up behavior on Firefox. Fixes: #2053 Signed-off-by: Andrew Gunnerson --- internal/ui/static/js/touch_handler.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'internal/ui/static/js/touch_handler.js') diff --git a/internal/ui/static/js/touch_handler.js b/internal/ui/static/js/touch_handler.js index 99c1d5b2..a3339cb5 100644 --- a/internal/ui/static/js/touch_handler.js +++ b/internal/ui/static/js/touch_handler.js @@ -164,7 +164,7 @@ class TouchHandler { elements.forEach((element) => { element.addEventListener("touchstart", (e) => this.onItemTouchStart(e), hasPassiveOption ? { passive: true } : false); - element.addEventListener("touchmove", (e) => this.onItemTouchMove(e), hasPassiveOption ? { passive: false } : false); + element.addEventListener("touchmove", (e) => this.onItemTouchMove(e), hasPassiveOption ? { passive: true } : false); element.addEventListener("touchend", (e) => this.onItemTouchEnd(e), hasPassiveOption ? { passive: true } : false); element.addEventListener("touchcancel", () => this.reset(), hasPassiveOption ? { passive: true } : false); }); -- cgit v1.2.3