Filter Always ON by Default (#2031)

* Filter Always ON by Default

* Fix CI Tests

* Update Docs

* Fix CI Test dirichletbc

* Default WarpX::use_filter = 0 with RZ FDTD, Add Warnings

* Set WarpX::use_kspace_filter = true by Default, too

* RZ: Fix Bug with PSATD Binary and FDTD Runtime Solver

* Default use_kspace_filter = true, Fix Runtime Issue with Rho Functor

14 files changed, 16 insertions, 6 deletions

diff --git a/Examples/Tests/ElectrostaticDirichletBC/inputs_2d b/Examples/Tests/ElectrostaticDirichletBC/inputs_2d
index 43705a527..7057c9258 100644
--- a/Examples/Tests/ElectrostaticDirichletBC/inputs_2d
+++ b/Examples/Tests/ElectrostaticDirichletBC/inputs_2d
@@ -3,6 +3,7 @@ warpx.verbose = 0
 warpx.const_dt = 7.5e-10
 warpx.do_electrostatic = labframe
 warpx.self_fields_required_precision = 1e-06
+warpx.use_filter = 0
 amr.n_cell = 64 8
 amr.max_grid_size = 32
 amr.max_level = 0
diff --git a/Examples/Tests/ElectrostaticSphere/inputs_rz b/Examples/Tests/ElectrostaticSphere/inputs_rz
index d9c8feca6..6634fa3f5 100644
--- a/Examples/Tests/ElectrostaticSphere/inputs_rz
+++ b/Examples/Tests/ElectrostaticSphere/inputs_rz
@@ -10,6 +10,7 @@ geometry.prob_hi     =  0.5  0.5
 warpx.do_pml = 0
 warpx.const_dt = 1e-6
 warpx.do_electrostatic = labframe
+warpx.use_filter = 0
 
 particles.species_names = electron
 
diff --git a/Examples/Tests/Langmuir/PICMI_inputs_langmuir2d.py b/Examples/Tests/Langmuir/PICMI_inputs_langmuir2d.py
index 5f81ab33c..a8b1c5ef2 100644
--- a/Examples/Tests/Langmuir/PICMI_inputs_langmuir2d.py
+++ b/Examples/Tests/Langmuir/PICMI_inputs_langmuir2d.py
@@ -79,7 +79,8 @@ part_diag1 = picmi.ParticleDiagnostic(name = 'diag1',
 sim = picmi.Simulation(solver = solver,
                        max_steps = max_steps,
                        verbose = 1,
-                       warpx_current_deposition_algo = 'direct')
+                       warpx_current_deposition_algo = 'direct',
+                       warpx_use_filter = 0)
 
 sim.add_species(electrons,
                 layout = picmi.GriddedLayout(n_macroparticle_per_cell=number_per_cell_each_dim, grid=grid))
diff --git a/Examples/Tests/Langmuir/PICMI_inputs_langmuir_rz_multimode_analyze.py b/Examples/Tests/Langmuir/PICMI_inputs_langmuir_rz_multimode_analyze.py
index 112862ce6..16a3f0575 100644
--- a/Examples/Tests/Langmuir/PICMI_inputs_langmuir_rz_multimode_analyze.py
+++ b/Examples/Tests/Langmuir/PICMI_inputs_langmuir_rz_multimode_analyze.py
@@ -118,7 +118,8 @@ sim = picmi.Simulation(solver = solver,
                        verbose = 1,
                        warpx_current_deposition_algo = 'esirkepov',
                        warpx_field_gathering_algo = 'energy-conserving',
-                       warpx_particle_pusher_algo = 'boris')
+                       warpx_particle_pusher_algo = 'boris',
+                       warpx_use_filter = 0)
 
 sim.add_species(electrons, layout=picmi.GriddedLayout(n_macroparticle_per_cell=[2,16,2], grid=grid))
 sim.add_species(protons, layout=picmi.GriddedLayout(n_macroparticle_per_cell=[2,16,2], grid=grid))
diff --git a/Examples/Tests/Langmuir/inputs_2d_multi_rt b/Examples/Tests/Langmuir/inputs_2d_multi_rt
index 91eb0c345..35b8c9fac 100644
--- a/Examples/Tests/Langmuir/inputs_2d_multi_rt
+++ b/Examples/Tests/Langmuir/inputs_2d_multi_rt
@@ -25,6 +25,7 @@ warpx.verbose = 1
 # Algorithms
 algo.field_gathering = energy-conserving
 warpx.do_pml = 0
+warpx.use_filter = 0
 
 # Order of particle shape factors
 algo.particle_shape = 1
diff --git a/Examples/Tests/Langmuir/inputs_2d_multi_rz_rt b/Examples/Tests/Langmuir/inputs_2d_multi_rz_rt
index 78e0a3694..f133cdcb7 100644
--- a/Examples/Tests/Langmuir/inputs_2d_multi_rz_rt
+++ b/Examples/Tests/Langmuir/inputs_2d_multi_rz_rt
@@ -27,6 +27,7 @@ warpx.verbose = 1
 warpx.do_pml = 0
 algo.field_gathering = energy-conserving
 algo.current_deposition = esirkepov
+warpx.use_filter = 0
 
 # Order of particle shape factors
 algo.particle_shape = 1
diff --git a/Examples/Tests/Langmuir/inputs_3d_multi_rt b/Examples/Tests/Langmuir/inputs_3d_multi_rt
index 16bceeb43..4d08a2a43 100644
--- a/Examples/Tests/Langmuir/inputs_3d_multi_rt
+++ b/Examples/Tests/Langmuir/inputs_3d_multi_rt
@@ -26,6 +26,7 @@ warpx.verbose = 1
 algo.current_deposition = esirkepov
 algo.field_gathering = energy-conserving
 warpx.do_pml = 0
+warpx.use_filter = 0
 
 # Order of particle shape factors
 algo.particle_shape = 1
diff --git a/Examples/Tests/Larmor/inputs_2d_mr b/Examples/Tests/Larmor/inputs_2d_mr
index 9fa5157a9..7431180d6 100644
--- a/Examples/Tests/Larmor/inputs_2d_mr
+++ b/Examples/Tests/Larmor/inputs_2d_mr
@@ -34,6 +34,7 @@ particles.B_external_particle = 0.0  0.00078110417851950768  0.0
 warpx.verbose = 1
 
 # Algorithms
+warpx.use_filter = 0
 
 # CFL
 warpx.cfl = 1.0
diff --git a/Examples/Tests/PML/inputs_2d b/Examples/Tests/PML/inputs_2d
index d4d84f7aa..3284e98fd 100644
--- a/Examples/Tests/PML/inputs_2d
+++ b/Examples/Tests/PML/inputs_2d
@@ -21,9 +21,9 @@ geometry.prob_hi     =  30.e-6  120.e-6
 warpx.verbose = 1
 
 # Algorithms
-
 warpx.cfl = 1.0
 warpx.do_pml = 1
+warpx.use_filter = 0
 
 warpx.do_moving_window = 0
 # warpx.moving_window_dir = z
diff --git a/Examples/Tests/SilverMueller/inputs_2d_x b/Examples/Tests/SilverMueller/inputs_2d_x
index 431315421..708fcd0fe 100644
--- a/Examples/Tests/SilverMueller/inputs_2d_x
+++ b/Examples/Tests/SilverMueller/inputs_2d_x
@@ -21,10 +21,10 @@ geometry.prob_hi     =  20.e-6  40.e-6
 warpx.verbose = 1
 
 # Algorithms
-
 warpx.cfl = 1.0
 warpx.do_pml = 0
 warpx.do_silver_mueller = 1
+warpx.use_filter = 0
 
 warpx.do_moving_window = 0
 # warpx.moving_window_dir = z
diff --git a/Examples/Tests/SilverMueller/inputs_2d_z b/Examples/Tests/SilverMueller/inputs_2d_z
index 266423ad7..e14f35ecf 100644
--- a/Examples/Tests/SilverMueller/inputs_2d_z
+++ b/Examples/Tests/SilverMueller/inputs_2d_z
@@ -21,10 +21,10 @@ geometry.prob_hi     =  40.e-6  20.e-6
 warpx.verbose = 1
 
 # Algorithms
-
 warpx.cfl = 1.0
 warpx.do_pml = 0
 warpx.do_silver_mueller = 1
+warpx.use_filter = 0
 
 warpx.do_moving_window = 0
 # warpx.moving_window_dir = z
diff --git a/Examples/Tests/SilverMueller/inputs_rz_z b/Examples/Tests/SilverMueller/inputs_rz_z
index ccb10d528..1b4e846b0 100644
--- a/Examples/Tests/SilverMueller/inputs_rz_z
+++ b/Examples/Tests/SilverMueller/inputs_rz_z
@@ -22,10 +22,10 @@ warpx.verbose = 1
 warpx.n_rz_azimuthal_modes = 2
 
 # Algorithms
-
 warpx.cfl = 1.0
 warpx.do_pml = 0
 warpx.do_silver_mueller = 1
+warpx.use_filter = 0
 
 warpx.do_moving_window = 0
 
diff --git a/Examples/Tests/initial_distribution/inputs b/Examples/Tests/initial_distribution/inputs
index 50999b3ea..cb12f251f 100644
--- a/Examples/Tests/initial_distribution/inputs
+++ b/Examples/Tests/initial_distribution/inputs
@@ -17,6 +17,7 @@ warpx.do_pml         = 0
 #################################
 warpx.verbose = 1
 warpx.cfl     = 1.e-8
+warpx.use_filter = 0
 
 # Order of particle shape factors
 algo.particle_shape = 1
diff --git a/Examples/Tests/laser_on_fine/inputs_2d b/Examples/Tests/laser_on_fine/inputs_2d
index b8ae4e2d2..e973c126e 100644
--- a/Examples/Tests/laser_on_fine/inputs_2d
+++ b/Examples/Tests/laser_on_fine/inputs_2d
@@ -34,6 +34,7 @@ warpx.verbose = 1
 algo.current_deposition = esirkepov
 algo.charge_deposition = standard
 algo.field_gathering = energy-conserving
+warpx.use_filter = 0
 
 # CFL
 warpx.cfl = 1.0