diff options
| author |  Luca Fedeli <luca.fedeli@cea.fr>
| 2023-07-26 20:55:34 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-07-26 18:55:34 +0000 |
| commit | 766d71146a8314a48db88f29b0e0548d1d9c5397 (patch) | |
| tree | 630ae577a1856ae0f5fb2e236a4e85b9346566d2 /Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp | |
| parent | 4783ad60809fc5fdff164a4ed0cacca4b3fffa70 (diff) | |
| download | WarpX-766d71146a8314a48db88f29b0e0548d1d9c5397.tar.gz WarpX-766d71146a8314a48db88f29b0e0548d1d9c5397.tar.zst WarpX-766d71146a8314a48db88f29b0e0548d1d9c5397.zip | |
Initialize variables at declaration if it improves readability (#4117)
* init some variables at declaration
* make code more readable
* avoid lossy function result cast
* Update Source/Initialization/WarpXInitData.cpp
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
* replace with equality
* Revert "replace with equality"
This reverts commit e3164f9e053d345b153d770ae107a7f68c4bb260.
* Update Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
---------
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
Diffstat (limited to 'Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp')
| -rw-r--r-- | Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp b/Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp index c6d0f57df..d3932472c 100644 --- a/Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp +++ b/Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp @@ -93,9 +93,8 @@ ParticleReductionFunctor::operator() (amrex::MultiFab& mf_dst, const int dcomp, const amrex::ParticleReal ux = p.rdata(PIdx::ux) / PhysConst::c; const amrex::ParticleReal uy = p.rdata(PIdx::uy) / PhysConst::c; const amrex::ParticleReal uz = p.rdata(PIdx::uz) / PhysConst::c; - amrex::Real value; - if ((do_filter) && (!filter_fn(xw, yw, zw, ux, uy, uz))) value = 0._rt; - else value = map_fn(xw, yw, zw, ux, uy, uz); + const bool filtered_out_flag = ((do_filter) && (filter_fn(xw, yw, zw, ux, uy, uz) == 0.0_prt)); + const amrex::Real value = (filtered_out_flag) ? (0._rt):(map_fn(xw, yw, zw, ux, uy, uz)); amrex::Gpu::Atomic::AddNoRet(&out_array(ii, jj, kk, 0), (amrex::Real)(p.rdata(PIdx::w) * value)); }); if (m_do_average) { |