aboutsummaryrefslogtreecommitdiff
path: root/Source/Diagnostics/Diagnostics.cpp
diff options
context:
space:
mode:
authorGravatar Luca Fedeli <luca.fedeli@cea.fr> 2023-08-30 03:36:46 +0200
committerGravatar GitHub <noreply@github.com> 2023-08-29 18:36:46 -0700
commit3f95ac68a1d7cf764f58e360ae9b4c43e5913095 (patch)
tree5da34d67f9fcdf0086d73e077b677ccf9b870541 /Source/Diagnostics/Diagnostics.cpp
parent71432aac4ef37b0c3476a2af2255140af3188669 (diff)
downloadWarpX-3f95ac68a1d7cf764f58e360ae9b4c43e5913095.tar.gz
WarpX-3f95ac68a1d7cf764f58e360ae9b4c43e5913095.tar.zst
WarpX-3f95ac68a1d7cf764f58e360ae9b4c43e5913095.zip
Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)
* add more readability checks to clang-tidy CI test * reformat check list * starting to address issues found with clang-tidy£ * addressing issues * remove check * address issues * address all issues * address issue found with github code scanning
Diffstat (limited to 'Source/Diagnostics/Diagnostics.cpp')
-rw-r--r--Source/Diagnostics/Diagnostics.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/Source/Diagnostics/Diagnostics.cpp b/Source/Diagnostics/Diagnostics.cpp
index a0e6db68d..7eb574aa0 100644
--- a/Source/Diagnostics/Diagnostics.cpp
+++ b/Source/Diagnostics/Diagnostics.cpp
@@ -117,7 +117,7 @@ Diagnostics::BaseReadParameters ()
}
#ifdef WARPX_DIM_RZ
WARPX_ALWAYS_ASSERT_WITH_MESSAGE(
- m_pfield_varnames.size() == 0,
+ m_pfield_varnames.empty(),
"Input error: cannot use particle_fields_to_plot with RZ"
);
#endif
@@ -134,7 +134,7 @@ Diagnostics::BaseReadParameters ()
pp_diag_pfield, (var + "(x,y,z,ux,uy,uz)"), parser_str);
WARPX_ALWAYS_ASSERT_WITH_MESSAGE(
- parser_str != "",
+ !parser_str.empty(),
std::string("Input error: cannot find parser string for ").append(var).append(" in file. ").append(
m_diag_name).append(".particle_fields.").append(var).append("(x,y,z,ux,uy,uz) is required"));