Clang-tidy CI test: add some performance checks in clang-tidy CI test (#4077)

* add some performance checks in clang-tidy CI test

* fix few smalle performance issues found with clang-tidy

* fix bug

* fixed bug

* fixed performance issue

1 files changed, 5 insertions, 4 deletions

diff --git a/Source/Diagnostics/Diagnostics.cpp b/Source/Diagnostics/Diagnostics.cpp
index 8af5c24b9..b87e60fab 100644
--- a/Source/Diagnostics/Diagnostics.cpp
+++ b/Source/Diagnostics/Diagnostics.cpp
@@ -136,9 +136,8 @@ Diagnostics::BaseReadParameters ()
 
         WARPX_ALWAYS_ASSERT_WITH_MESSAGE(
             parser_str != "",
-            "Input error: cannot find parser string for " + var + " in file. "
-            + m_diag_name + ".particle_fields." + var + "(x,y,z,ux,uy,uz) is required"
-        );
+            std::string("Input error: cannot find parser string for ").append(var).append(" in file. ").append(
+                m_diag_name).append(".particle_fields.").append(var).append("(x,y,z,ux,uy,uz) is required"));
 
         m_pfield_strings.push_back(parser_str);
 
@@ -189,7 +188,9 @@ Diagnostics::BaseReadParameters ()
     // Generate names of averaged particle fields and append to m_varnames
     for (const auto& fname : m_pfield_varnames) {
         for (const auto& sname : m_pfield_species) {
-            m_varnames.push_back(fname + '_' + sname);
+            auto varname = fname;
+            varname.append("_").append(sname);
+            m_varnames.push_back(varname);
         }
     }