1D3V Cartesian Support (#2307)

* Build System: Add 1D Geometry

* test PR

* test PR

* 1D cartesian yee algorithm

* fixed typo

* Fixes for PML

* 1D support related multiple changes

* Fix compilation

* change 1D to 1D_Z

* 1D Field Gather and typo fix

* 1D Charge Deposition

* Particle Pusher

* multiple changes related to 1D

* 1D diagnostics and initialization

* PlasmaInjector and PEC fixes for 1D

* clean-up delete diags file

* mobility 1D laser particle and bilinear filter

* deleted diags files

* update laser particle weight formula

* delete diags files

* Azure: Add 1D Cartesian Runner

* 1D fixes for FieldProbe

* Update Docs/source/developers/dimensionality.rst

Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>

* 1d laser injection and langmuir test input files

* 1d tests

* clean up : delete print statements

* analyse simulation result for laser injection and Langmuir tests

* EOL

* delete input files for which there are no automated tests

* delete input files for which there are no automated tests

* add ignore_unused to remove warnings

* remove space

* Fix compilation issues

* fix error : macro name must be an identifier

* Small bug fix

* cleanup Python script for analysis

* bug fix

* bug fix

* Update ParticleProbe: Check 1D in-domain

* Update Source/Make.WarpX

* Update .azure-pipelines.yml

* Add USE_OPENPMD=FALSE to .azure-pipeline.yml

* resolve conflict

* resolve conflict

* fix typo

* Correct out-of-bound access

* Fix Particle BC in WarpXParticleContainer and correct path to checksumAPI in python analysis scripts

* EOL

* Fix bug : accessing out of bound index of cell in 1D

* remove 1d test for cartesian3d

* Fix CI check

* Slight style change

* Address review comments

* Fix GPU compilation Filter.cpp

* Fix CI

* Fix Indentation

* Address review comments

* More consistent ifdef for dimension bigger than 1

* Update Examples/Tests/Langmuir/analysis_langmuir_multi_1d.py

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update GNUmakefile

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Regression/prepare_file_ci.py

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianCKCAlgorithm.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianNodalAlgorithm.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Initialization/PlasmaInjector.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Initialization/PlasmaInjector.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* add comment inline to explain twice push_back

* Add amrex::Abort for NCIGodfreyFilter

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Prabhat Kumar <prabhatkumar@kraken.dhcp.lbl.gov>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <rlehe@lbl.gov>

1 files changed, 20 insertions, 4 deletions

diff --git a/Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianYeeAlgorithm.H b/Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianYeeAlgorithm.H
index 4fe813754..f2c8553d5 100644
--- a/Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianYeeAlgorithm.H
+++ b/Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianYeeAlgorithm.H
@@ -71,8 +71,14 @@ struct CartesianYeeAlgorithm {
         amrex::Real const * const coefs_x, int const /*n_coefs_x*/,
         int const i, int const j, int const k, int const ncomp=0 ) {
 
+        using namespace amrex;
+#if (defined WARPX_DIM_1D_Z)
+        amrex::ignore_unused(F, coefs_x, i, j, k, ncomp);
+        return 0._rt; // 1D Cartesian: derivative along x is 0
+#else
         amrex::Real const inv_dx = coefs_x[0];
         return inv_dx*( F(i+1,j,k,ncomp) - F(i,j,k,ncomp) );
+#endif
     }
 
     /**
@@ -84,8 +90,14 @@ struct CartesianYeeAlgorithm {
         amrex::Real const * const coefs_x, int const /*n_coefs_x*/,
         int const i, int const j, int const k, int const ncomp=0 ) {
 
+        using namespace amrex;
+#if (defined WARPX_DIM_1D_Z)
+        amrex::ignore_unused(F, coefs_x, i, j, k, ncomp);
+        return 0._rt; // 1D Cartesian: derivative along x is 0
+#else
         amrex::Real const inv_dx = coefs_x[0];
         return inv_dx*( F(i,j,k,ncomp) - F(i-1,j,k,ncomp) );
+#endif
     }
 
     /**
@@ -101,10 +113,10 @@ struct CartesianYeeAlgorithm {
         Real const inv_dy = coefs_y[0];
         amrex::ignore_unused(n_coefs_y);
         return inv_dy*( F(i,j+1,k,ncomp) - F(i,j,k,ncomp) );
-#elif (defined WARPX_DIM_XZ)
+#elif (defined WARPX_DIM_XZ || WARPX_DIM_1D_Z)
         amrex::ignore_unused(F, coefs_y, n_coefs_y,
             i, j, k, ncomp);
-        return 0._rt; // 2D Cartesian: derivative along y is 0
+        return 0._rt; // 1D and 2D Cartesian: derivative along y is 0
 #else
         amrex::ignore_unused(F, coefs_y, n_coefs_y,
             i, j, k, ncomp);
@@ -125,10 +137,10 @@ struct CartesianYeeAlgorithm {
         Real const inv_dy = coefs_y[0];
         amrex::ignore_unused(n_coefs_y);
         return inv_dy*( F(i,j,k,ncomp) - F(i,j-1,k,ncomp) );
-#elif (defined WARPX_DIM_XZ)
+#elif (defined WARPX_DIM_XZ || WARPX_DIM_1D_Z)
         amrex::ignore_unused(F, coefs_y, n_coefs_y,
             i, j, k, ncomp);
-        return 0._rt; // 2D Cartesian: derivative along y is 0
+        return 0._rt; // 1D and 2D Cartesian: derivative along y is 0
 #else
         amrex::ignore_unused(F, coefs_y, n_coefs_y,
             i, j, k, ncomp);
@@ -149,6 +161,8 @@ struct CartesianYeeAlgorithm {
         return inv_dz*( F(i,j,k+1,ncomp) - F(i,j,k,ncomp) );
 #elif (defined WARPX_DIM_XZ)
         return inv_dz*( F(i,j+1,k,ncomp) - F(i,j,k,ncomp) );
+#elif (defined WARPX_DIM_1D_Z)
+        return inv_dz*( F(i+1,j,k,ncomp) - F(i,j,k,ncomp) );
 #endif
     }
 
@@ -167,6 +181,8 @@ struct CartesianYeeAlgorithm {
         return inv_dz*( F(i,j,k,ncomp) - F(i,j,k-1,ncomp) );
 #elif (defined WARPX_DIM_XZ)
         return inv_dz*( F(i,j,k,ncomp) - F(i,j-1,k,ncomp) );
+#elif (defined WARPX_DIM_1D_Z)
+        return inv_dz*( F(i,j,k,ncomp) - F(i-1,j,k,ncomp) );
 #endif
     }