Clang tidy CI test: add several readability checks to clang tidy CI test (#4124)

* add few readability checks to clang-tidy CI test

* address all the issues found with clang-tidy

* fix bug

* fixed bug

* fix residual issue

* fix issue found with clang-tidy

1 files changed, 4 insertions, 4 deletions

diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.cpp b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.cpp
index 946d938c7..e396efe12 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.cpp
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.cpp
@@ -53,10 +53,10 @@ PsatdAlgorithmFirstOrder::pushSpectralFields (SpectralFieldData& f) const
 {
     const bool div_cleaning = m_div_cleaning;
 
-    const bool J_constant = (m_J_in_time == JInTime::Constant) ? true : false;
-    const bool J_linear   = (m_J_in_time == JInTime::Linear  ) ? true : false;
-    const bool rho_constant = (m_rho_in_time == RhoInTime::Constant) ? true : false;
-    const bool rho_linear   = (m_rho_in_time == RhoInTime::Linear  ) ? true : false;
+    const bool J_constant = (m_J_in_time == JInTime::Constant);
+    const bool J_linear   = (m_J_in_time == JInTime::Linear);
+    const bool rho_constant = (m_rho_in_time == RhoInTime::Constant);
+    const bool rho_linear   = (m_rho_in_time == RhoInTime::Linear);
 
     const amrex::Real dt = m_dt;
     const amrex::Real dt2 = dt*dt;