Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)

* add more readability checks to clang-tidy CI test

* reformat check list

* starting to address issues found with clang-tidy£

* addressing issues

* remove check

* address issues

* address all issues

* address issue found with github code scanning

10 files changed, 61 insertions, 61 deletions

diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.H
index d52b2c09b..be9dbf26b 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmComoving.H
@@ -29,13 +29,13 @@ class PsatdAlgorithmComoving : public SpectralBaseAlgorithm
         PsatdAlgorithmComoving (const SpectralKSpace& spectral_kspace,
                                 const amrex::DistributionMapping& dm,
                                 const SpectralFieldIndex& spectral_index,
-                                const int norder_x,
-                                const int norder_y,
-                                const int norder_z,
-                                const short grid_type,
+                                int norder_x,
+                                int norder_y,
+                                int norder_z,
+                                short grid_type,
                                 const amrex::Vector<amrex::Real>& v_comoving,
-                                const amrex::Real dt,
-                                const bool update_with_rho);
+                                amrex::Real dt,
+                                bool update_with_rho);
 
         /**
          * \brief Override the update equations in Fourier space
@@ -46,7 +46,7 @@ class PsatdAlgorithmComoving : public SpectralBaseAlgorithm
          */
         void InitializeSpectralCoefficients (const SpectralKSpace& spectral_kspace,
                                              const amrex::DistributionMapping& dm,
-                                             const amrex::Real dt);
+                                             amrex::Real dt);
 
         /**
          * \brief Virtual function for current correction in Fourier space.
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.H
index 3e20a2c4e..dea72bec3 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmFirstOrder.H
@@ -47,14 +47,14 @@ class PsatdAlgorithmFirstOrder : public SpectralBaseAlgorithm
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
             const SpectralFieldIndex& spectral_index,
-            const int norder_x,
-            const int norder_y,
-            const int norder_z,
-            const short grid_type,
-            const amrex::Real dt,
-            const bool div_cleaning,
-            const int J_in_time,
-            const int rho_in_time);
+            int norder_x,
+            int norder_y,
+            int norder_z,
+            short grid_type,
+            amrex::Real dt,
+            bool div_cleaning,
+            int J_in_time,
+            int rho_in_time);
 
         /**
          * \brief Updates E, B, F, and G fields in spectral space,
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmGalileanRZ.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmGalileanRZ.H
index 59b307731..37d763739 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmGalileanRZ.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmGalileanRZ.H
@@ -19,11 +19,11 @@ class PsatdAlgorithmGalileanRZ : public SpectralBaseAlgorithmRZ
         PsatdAlgorithmGalileanRZ (SpectralKSpaceRZ const & spectral_kspace,
                                   amrex::DistributionMapping const & dm,
                                   const SpectralFieldIndex& spectral_index,
-                                  int const n_rz_azimuthal_modes, int const norder_z,
-                                  short const grid_type,
+                                  int n_rz_azimuthal_modes, int norder_z,
+                                  short grid_type,
                                   const amrex::Vector<amrex::Real>& v_galilean,
-                                  amrex::Real const dt_step,
-                                  bool const update_with_rho);
+                                  amrex::Real dt_step,
+                                  bool update_with_rho);
         // Redefine functions from base class
         virtual void pushSpectralFields (SpectralFieldDataRZ & f) override final;
 
@@ -53,7 +53,7 @@ class PsatdAlgorithmGalileanRZ : public SpectralBaseAlgorithmRZ
 
         bool coefficients_initialized;
         // Note that dt and v_galilean are saved to use in InitializeSpectralCoefficients
-        amrex::Real const m_dt;
+        amrex::Real m_dt;
         amrex::Vector<amrex::Real> m_v_galilean;
         bool m_update_with_rho;
 
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJConstantInTime.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJConstantInTime.H
index 742e9a116..ed293fd1e 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJConstantInTime.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJConstantInTime.H
@@ -49,16 +49,16 @@ class PsatdAlgorithmJConstantInTime : public SpectralBaseAlgorithm
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
             const SpectralFieldIndex& spectral_index,
-            const int norder_x,
-            const int norder_y,
-            const int norder_z,
-            const short grid_type,
+            int norder_x,
+            int norder_y,
+            int norder_z,
+            short grid_type,
             const amrex::Vector<amrex::Real>& v_galilean,
-            const amrex::Real dt,
-            const bool update_with_rho,
-            const bool time_averaging,
-            const bool dive_cleaning,
-            const bool divb_cleaning);
+            amrex::Real dt,
+            bool update_with_rho,
+            bool time_averaging,
+            bool dive_cleaning,
+            bool divb_cleaning);
 
         /**
          * \brief Updates the E and B fields in spectral space, according to the relevant PSATD equations
@@ -77,7 +77,7 @@ class PsatdAlgorithmJConstantInTime : public SpectralBaseAlgorithm
         void InitializeSpectralCoefficients (
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
-            const amrex::Real dt);
+            amrex::Real dt);
 
         /**
          * \brief Initializes additional coefficients used in \c pushSpectralFields to update the E and B fields,
@@ -90,7 +90,7 @@ class PsatdAlgorithmJConstantInTime : public SpectralBaseAlgorithm
         void InitializeSpectralCoefficientsAveraging (
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
-            const amrex::Real dt);
+            amrex::Real dt);
 
         /**
          * \brief Virtual function for current correction in Fourier space
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJLinearInTime.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJLinearInTime.H
index acabd69d3..94eda8a2f 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJLinearInTime.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmJLinearInTime.H
@@ -50,14 +50,14 @@ class PsatdAlgorithmJLinearInTime : public SpectralBaseAlgorithm
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
             const SpectralFieldIndex& spectral_index,
-            const int norder_x,
-            const int norder_y,
-            const int norder_z,
-            const short grid_type,
-            const amrex::Real dt,
-            const bool time_averaging,
-            const bool dive_cleaning,
-            const bool divb_cleaning);
+            int norder_x,
+            int norder_y,
+            int norder_z,
+            short grid_type,
+            amrex::Real dt,
+            bool time_averaging,
+            bool dive_cleaning,
+            bool divb_cleaning);
 
         /**
          * \brief Updates the E and B fields in spectral space, according to the multi-J PSATD equations
@@ -76,7 +76,7 @@ class PsatdAlgorithmJLinearInTime : public SpectralBaseAlgorithm
         void InitializeSpectralCoefficients (
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
-            const amrex::Real dt);
+            amrex::Real dt);
 
         /**
          * \brief Initialize additional coefficients used in \c pushSpectralFields to update E,B,
@@ -89,7 +89,7 @@ class PsatdAlgorithmJLinearInTime : public SpectralBaseAlgorithm
         void InitializeSpectralCoefficientsAveraging (
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
-            const amrex::Real dt);
+            amrex::Real dt);
 
         /**
          * \brief Virtual function for current correction in Fourier space
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPml.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPml.H
index b9342ebfe..7f50d1cd8 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPml.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPml.H
@@ -30,16 +30,16 @@ class PsatdAlgorithmPml : public SpectralBaseAlgorithm
         PsatdAlgorithmPml(const SpectralKSpace& spectral_kspace,
                           const amrex::DistributionMapping& dm,
                           const SpectralFieldIndex& spectral_index,
-                          const int norder_x, const int norder_y,
-                          const int norder_z, const short grid_type,
-                          const amrex::Real dt,
-                          const bool dive_cleaning,
-                          const bool divb_cleaning);
+                          int norder_x, int norder_y,
+                          int norder_z, short grid_type,
+                          amrex::Real dt,
+                          bool dive_cleaning,
+                          bool divb_cleaning);
 
         void InitializeSpectralCoefficients(
             const SpectralKSpace& spectral_kspace,
             const amrex::DistributionMapping& dm,
-            const amrex::Real dt);
+            amrex::Real dt);
 
         // Redefine functions from base class
         virtual void pushSpectralFields(SpectralFieldData& f) const override final;
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPmlRZ.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPmlRZ.H
index e347cf40e..33dafd382 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPmlRZ.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmPmlRZ.H
@@ -19,8 +19,8 @@ class PsatdAlgorithmPmlRZ : public SpectralBaseAlgorithmRZ
         PsatdAlgorithmPmlRZ (SpectralKSpaceRZ const & spectral_kspace,
                              amrex::DistributionMapping const & dm,
                              const SpectralFieldIndex& spectral_index,
-                             int const n_rz_azimuthal_modes, int const norder_z,
-                             short const grid_type, amrex::Real const dt_step);
+                             int n_rz_azimuthal_modes, int norder_z,
+                             short grid_type, amrex::Real dt_step);
 
         // Redefine functions from base class
         virtual void pushSpectralFields (SpectralFieldDataRZ & f) override final;
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmRZ.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmRZ.H
index f8dd6bb78..5f02498f7 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmRZ.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/PsatdAlgorithmRZ.H
@@ -19,14 +19,14 @@ class PsatdAlgorithmRZ : public SpectralBaseAlgorithmRZ
         PsatdAlgorithmRZ(SpectralKSpaceRZ const & spectral_kspace,
                          amrex::DistributionMapping const & dm,
                          const SpectralFieldIndex& spectral_index,
-                         int const n_rz_azimuthal_modes, int const norder_z,
-                         short const grid_type, amrex::Real const dt_step,
-                         bool const update_with_rho,
-                         const bool time_averaging,
-                         const int J_in_time,
-                         const int rho_in_time,
-                         const bool dive_cleaning,
-                         const bool divb_cleaning);
+                         int n_rz_azimuthal_modes, int norder_z,
+                         short grid_type, amrex::Real dt_step,
+                         bool update_with_rho,
+                         bool time_averaging,
+                         int J_in_time,
+                         int rho_in_time,
+                         bool dive_cleaning,
+                         bool divb_cleaning);
         // Redefine functions from base class
         virtual void pushSpectralFields(SpectralFieldDataRZ & f) override final;
 
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithm.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithm.H
index fe624e9b8..22fc506cc 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithm.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithm.H
@@ -64,7 +64,7 @@ class SpectralBaseAlgorithm
         /**
          * \brief Compute spectral divergence of E
          */
-        void ComputeSpectralDivE ( const int lev,
+        void ComputeSpectralDivE ( int lev,
                                    SpectralFieldData& field_data,
                                    const std::array<std::unique_ptr<amrex::MultiFab>,3>& Efield,
                                    amrex::MultiFab& divE );
@@ -82,8 +82,8 @@ class SpectralBaseAlgorithm
         SpectralBaseAlgorithm(const SpectralKSpace& spectral_kspace,
                               const amrex::DistributionMapping& dm,
                               const SpectralFieldIndex& spectral_index,
-                              const int norder_x, const int norder_y,
-                              const int norder_z, const short grid_type);
+                              int norder_x, int norder_y,
+                              int norder_z, short grid_type);
 
         SpectralFieldIndex m_spectral_index;
 
diff --git a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithmRZ.H b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithmRZ.H
index 37bb862a9..5758f81e3 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithmRZ.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralAlgorithms/SpectralBaseAlgorithmRZ.H
@@ -40,7 +40,7 @@ class SpectralBaseAlgorithmRZ
         /**
          * \brief Compute spectral divergence of E
          */
-        void ComputeSpectralDivE ( const int lev,
+        void ComputeSpectralDivE ( int lev,
                                    SpectralFieldDataRZ& field_data,
                                    const std::array<std::unique_ptr<amrex::MultiFab>,3>& Efield,
                                    amrex::MultiFab& divE );