Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)

* add more readability checks to clang-tidy CI test

* reformat check list

* starting to address issues found with clang-tidy£

* addressing issues

* remove check

* address issues

* address all issues

* address issue found with github code scanning

1 files changed, 16 insertions, 16 deletions

diff --git a/Source/FieldSolver/SpectralSolver/SpectralFieldData.H b/Source/FieldSolver/SpectralSolver/SpectralFieldData.H
index e86348484..8fd23fac7 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralFieldData.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralFieldData.H
@@ -56,14 +56,14 @@ class SpectralFieldIndex
          * \param[in] pml_rz          whether the indices are used to access spectral data
          *                            for the RZ PML spectral solver
          */
-        SpectralFieldIndex (const bool update_with_rho,
-                            const bool time_averaging,
-                            const int J_in_time,
-                            const int rho_in_time,
-                            const bool dive_cleaning,
-                            const bool divb_cleaning,
-                            const bool pml,
-                            const bool pml_rz = false);
+        SpectralFieldIndex (bool update_with_rho,
+                            bool time_averaging,
+                            int J_in_time,
+                            int rho_in_time,
+                            bool dive_cleaning,
+                            bool divb_cleaning,
+                            bool pml,
+                            bool pml_rz = false);
 
         /**
          * \brief Default constructor
@@ -122,22 +122,22 @@ class SpectralFieldData
 {
 
     public:
-        SpectralFieldData( const int lev,
+        SpectralFieldData( int lev,
                            const amrex::BoxArray& realspace_ba,
                            const SpectralKSpace& k_space,
                            const amrex::DistributionMapping& dm,
-                           const int n_field_required,
-                           const bool periodic_single_box);
+                           int n_field_required,
+                           bool periodic_single_box);
         SpectralFieldData() = default; // Default constructor
         SpectralFieldData& operator=(SpectralFieldData&& field_data) = default;
         ~SpectralFieldData();
 
-        void ForwardTransform (const int lev,
-                               const amrex::MultiFab& mf, const int field_index,
-                               const int i_comp);
+        void ForwardTransform (int lev,
+                               const amrex::MultiFab& mf, int field_index,
+                               int i_comp);
 
-        void BackwardTransform (const int lev, amrex::MultiFab& mf, const int field_index,
-                                const amrex::IntVect& fill_guards, const int i_comp);
+        void BackwardTransform (int lev, amrex::MultiFab& mf, int field_index,
+                                const amrex::IntVect& fill_guards, int i_comp);
 
         // `fields` stores fields in spectral space, as multicomponent FabArray
         SpectralField fields;