Initialize variables at declaration if it improves readability (#4117)

* init some variables at declaration

* make code more readable

* avoid lossy function result cast

* Update Source/Initialization/WarpXInitData.cpp

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>

* replace with equality

* Revert "replace with equality"

This reverts commit e3164f9e053d345b153d770ae107a7f68c4bb260.

* Update Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>

---------

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>

1 files changed, 1 insertions, 6 deletions

diff --git a/Source/FieldSolver/SpectralSolver/SpectralHankelTransform/HankelTransform.cpp b/Source/FieldSolver/SpectralSolver/SpectralHankelTransform/HankelTransform.cpp
index ddd07acad..5d49322b2 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralHankelTransform/HankelTransform.cpp
+++ b/Source/FieldSolver/SpectralSolver/SpectralHankelTransform/HankelTransform.cpp
@@ -64,12 +64,7 @@ HankelTransform::HankelTransform (int const hankel_order,
     // NB: When compared with the FBPIC article, all the matrices here
     // are calculated in transposed form. This is done so as to use the
     // `dot` and `gemm` functions, in the `transform` method.
-    int p_denom;
-    if (hankel_order == azimuthal_mode) {
-        p_denom = hankel_order + 1;
-    } else {
-        p_denom = hankel_order;
-    }
+    const int p_denom = (hankel_order == azimuthal_mode)?(hankel_order + 1):(hankel_order);
 
     amrex::Vector<amrex::Real> denom(m_nk);
     for (int ik=0 ; ik < m_nk ; ik++) {