Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)

* add more readability checks to clang-tidy CI test

* reformat check list

* starting to address issues found with clang-tidy£

* addressing issues

* remove check

* address issues

* address all issues

* address issue found with github code scanning

1 files changed, 10 insertions, 6 deletions

diff --git a/Source/FieldSolver/SpectralSolver/SpectralKSpace.H b/Source/FieldSolver/SpectralSolver/SpectralKSpace.H
index d5266b2a2..2a4dd3d15 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralKSpace.H
+++ b/Source/FieldSolver/SpectralSolver/SpectralKSpace.H
@@ -49,19 +49,23 @@ class SpectralKSpace
     public:
         amrex::BoxArray spectralspace_ba;
         SpectralKSpace() : dx(amrex::RealVect::Zero) {}
+
         SpectralKSpace( const amrex::BoxArray& realspace_ba,
                         const amrex::DistributionMapping& dm,
-                        const amrex::RealVect realspace_dx );
+                        amrex::RealVect realspace_dx );
+
         KVectorComponent getKComponent(
             const amrex::DistributionMapping& dm,
             const amrex::BoxArray& realspace_ba,
-            const int i_dim, const bool only_positive_k ) const;
+            int i_dim, bool only_positive_k ) const;
+
         KVectorComponent getModifiedKComponent(
-            const amrex::DistributionMapping& dm, const int i_dim,
-            const int n_order, const short grid_type ) const;
+            const amrex::DistributionMapping& dm, int i_dim,
+            int n_order, short grid_type ) const;
+
         SpectralShiftFactor getSpectralShiftFactor(
-            const amrex::DistributionMapping& dm, const int i_dim,
-            const int shift_type ) const;
+            const amrex::DistributionMapping& dm, int i_dim,
+            int shift_type ) const;
 
     protected:
         amrex::Array<KVectorComponent, AMREX_SPACEDIM> k_vec;