Initialize variables at declaration if it improves readability (#4117)

* init some variables at declaration

* make code more readable

* avoid lossy function result cast

* Update Source/Initialization/WarpXInitData.cpp

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>

* replace with equality

* Revert "replace with equality"

This reverts commit e3164f9e053d345b153d770ae107a7f68c4bb260.

* Update Source/Diagnostics/ComputeDiagFunctors/ParticleReductionFunctor.cpp

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>

---------

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>

1 files changed, 2 insertions, 7 deletions

diff --git a/Source/FieldSolver/SpectralSolver/SpectralKSpace.cpp b/Source/FieldSolver/SpectralSolver/SpectralKSpace.cpp
index 7320b7cf1..b8d81000c 100644
--- a/Source/FieldSolver/SpectralSolver/SpectralKSpace.cpp
+++ b/Source/FieldSolver/SpectralSolver/SpectralKSpace.cpp
@@ -68,14 +68,9 @@ SpectralKSpace::SpectralKSpace( const BoxArray& realspace_ba,
     spectralspace_ba.define( spectral_bl );
 
     // Allocate the components of the k vector: kx, ky (only in 3D), kz
-    bool only_positive_k;
     for (int i_dim=0; i_dim<AMREX_SPACEDIM; i_dim++) {
-        if (i_dim==0) {
-            // Real-to-complex FFTs: first axis contains only the positive k
-            only_positive_k = true;
-        } else {
-            only_positive_k = false;
-        }
+        // Real-to-complex FFTs: first axis contains only the positive k
+        const auto only_positive_k = (i_dim==0);
         k_vec[i_dim] = getKComponent(dm, realspace_ba, i_dim, only_positive_k);
     }
 }