Enforce const correctness using clang-tidy CI test (#3921)

* add clang-tidy workflow

* fix missing newline

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* make clang.14.sh executable

* remove non explicitly selected checks

* complete list of dependencies

* fix bug

* specify path of clang-tidy file

* fix bug

* add new check

* remove one check

* add magic numbers check

* removed one check

* keep only one check

* Docs: Conda Dev w/ Boost (#3911)

Add the `boost` package to the conda developer environment.
Used for QED table generation.

* Fix typo in Adastra cluster documentation (#3918)

* add back three checks

* prepare clang-tidy wrapper

* actually use clang-tidy in the script

* test

* fix bug

* actually use clang-tidy

* fixed bug

* fixed bug

* fixed bug

* fixed bug

* remove all checks except the selected 3

* fixed bug

* fixed bug

* fixed bug

* enforce const correctness using clang-tidy

* remove one check

* Fix Concurrency Issue

* BLAS++/LAPACK++ for RZ+PSATD

* Build all 4 WarpX DIMS

* add few echo for test purposes

* try to debug mysterious error

* don't test RZ with clang-tidy

* add back RZ test

* add some const

* fix bug

* check also header files

* remove header filter since it does not work as expected

* fixed bug

* check also WarpX headers

* fix bugs

* continue enforcing const correctness

* continue enforcing const correctness

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed bug

* fix bugs and add new const

* clean .clang-tidy

* make regex more precise according to Weiqun's suggestion

* add more const

* fix bugs

* fix bug

* silence warning on float comparison

* fixed bug

* fixed bugs

* fix bug and add const

* fixed bugs

* fix bug

* fix bug

* fix bug

* fixed bug

* fix bug

1 files changed, 3 insertions, 3 deletions

diff --git a/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.cpp b/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.cpp
index c94cd8812..8eddad7c4 100644
--- a/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.cpp
+++ b/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.cpp
@@ -20,7 +20,7 @@ namespace BinaryCollisionUtils{
     NuclearFusionType get_nuclear_fusion_type (const std::string collision_name,
                                                MultiParticleContainer const * const mypc)
         {
-            amrex::ParmParse pp_collision_name(collision_name);
+            const amrex::ParmParse pp_collision_name(collision_name);
             amrex::Vector<std::string> species_names;
             pp_collision_name.getarr("species", species_names);
             auto& species1 = mypc->GetParticleContainerFromName(species_names[0]);
@@ -107,11 +107,11 @@ namespace BinaryCollisionUtils{
     CollisionType get_collision_type (const std::string collision_name,
                                       MultiParticleContainer const * const mypc)
         {
-            amrex::ParmParse pp_collision_name(collision_name);
+            const amrex::ParmParse pp_collision_name(collision_name);
             std::string type;
             pp_collision_name.get("type", type);
             if (type == "nuclearfusion") {
-                NuclearFusionType fusion_type = get_nuclear_fusion_type(collision_name, mypc);
+                const NuclearFusionType fusion_type = get_nuclear_fusion_type(collision_name, mypc);
                 return nuclear_fusion_type_to_collision_type(fusion_type);
             }
             WARPX_ABORT_WITH_MESSAGE(type + " is not a valid type of collision that creates new particles");