Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)

* add more readability checks to clang-tidy CI test

* reformat check list

* starting to address issues found with clang-tidy£

* addressing issues

* remove check

* address issues

* address all issues

* address issue found with github code scanning

5 files changed, 14 insertions, 14 deletions

diff --git a/Source/Particles/Collision/BackgroundMCC/MCCProcess.H b/Source/Particles/Collision/BackgroundMCC/MCCProcess.H
index 7a283b751..31f790153 100644
--- a/Source/Particles/Collision/BackgroundMCC/MCCProcess.H
+++ b/Source/Particles/Collision/BackgroundMCC/MCCProcess.H
@@ -27,7 +27,7 @@ public:
     MCCProcess (
                 const std::string& scattering_process,
                 const std::string& cross_section_file,
-                const amrex::ParticleReal energy
+                amrex::ParticleReal energy
                 );
 
     template <typename InputVector>
@@ -35,7 +35,7 @@ public:
                 const std::string& scattering_process,
                 const InputVector&& energies,
                 const InputVector&& sigmas,
-                const amrex::ParticleReal energy
+                amrex::ParticleReal energy
                 );
 
     MCCProcess (MCCProcess const&) = delete;
@@ -54,7 +54,7 @@ public:
      */
     static
     void readCrossSectionFile (
-                               const std::string cross_section_file,
+                               std::string cross_section_file,
                                amrex::Vector<amrex::ParticleReal>& energies,
                                amrex::Gpu::HostVector<amrex::ParticleReal>& sigmas
                                );
@@ -125,7 +125,7 @@ private:
     static
     MCCProcessType parseProcessType(const std::string& process);
 
-    void init (const std::string& scattering_process, const amrex::ParticleReal energy);
+    void init (const std::string& scattering_process, amrex::ParticleReal energy);
 
     amrex::Vector<amrex::ParticleReal> m_energies;
 
diff --git a/Source/Particles/Collision/BinaryCollision/BinaryCollision.H b/Source/Particles/Collision/BinaryCollision/BinaryCollision.H
index c52182681..5473f0093 100644
--- a/Source/Particles/Collision/BinaryCollision/BinaryCollision.H
+++ b/Source/Particles/Collision/BinaryCollision/BinaryCollision.H
@@ -96,7 +96,7 @@ public:
 
         const amrex::ParmParse pp_collision_name(collision_name);
         pp_collision_name.queryarr("product_species", m_product_species);
-        m_have_product_species = m_product_species.size() > 0;
+        m_have_product_species = !m_product_species.empty();
         m_copy_transform_functor = CopyTransformFunctorType(collision_name, mypc);
     }
 
diff --git a/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H b/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H
index 09213ba03..0a7aae983 100644
--- a/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H
+++ b/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H
@@ -29,13 +29,13 @@ enum struct NuclearFusionType {
 
 namespace BinaryCollisionUtils{
 
-    NuclearFusionType get_nuclear_fusion_type (const std::string collision_name,
-                                               MultiParticleContainer const * const mypc);
+    NuclearFusionType get_nuclear_fusion_type (std::string collision_name,
+                                               MultiParticleContainer const * mypc);
 
-    CollisionType get_collision_type (const std::string collision_name,
-                                      MultiParticleContainer const * const mypc);
+    CollisionType get_collision_type (std::string collision_name,
+                                      MultiParticleContainer const * mypc);
 
-    CollisionType nuclear_fusion_type_to_collision_type (const NuclearFusionType fusion_type);
+    CollisionType nuclear_fusion_type_to_collision_type (NuclearFusionType fusion_type);
 }
 
 #endif // BINARY_COLLISION_UTILS_H_
diff --git a/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H b/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H
index 0868e3131..3b81dfa87 100644
--- a/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H
+++ b/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H
@@ -50,7 +50,7 @@ public:
      * @param[in] collision_name the name of the collision
      * @param[in] mypc pointer to the MultiParticleContainer
      */
-    ParticleCreationFunc (const std::string collision_name, MultiParticleContainer const * const mypc);
+    ParticleCreationFunc (std::string collision_name, MultiParticleContainer const * mypc);
 
     /**
      * \brief operator() of the ParticleCreationFunc class. It creates new particles from binary
@@ -99,7 +99,7 @@ public:
     AMREX_INLINE
     amrex::Vector<int> operator() (
                     const index_type& n_total_pairs,
-                    const SoaData_type soa_1, const SoaData_type soa_2,
+                    const SoaData_type& soa_1, const SoaData_type& soa_2,
                     ParticleTileType** AMREX_RESTRICT tile_products,
                     ParticleType* particle_ptr_1, ParticleType*  particle_ptr_2,
                     const amrex::ParticleReal& m1, const amrex::ParticleReal& m2,
@@ -286,7 +286,7 @@ public:
     AMREX_INLINE
     amrex::Vector<int> operator() (
                     const index_type& /*n_total_pairs*/,
-                    const SoaData_type /*soa_1*/, const SoaData_type /*soa_2*/,
+                    const SoaData_type& /*soa_1*/, const SoaData_type& /*soa_2*/,
                     ParticleTileType** /*tile_products*/,
                     ParticleType* /*particle_ptr_1*/, ParticleType* /*particle_ptr_2*/,
                     const amrex::ParticleReal& /*m1*/, const amrex::ParticleReal& /*m2*/,
diff --git a/Source/Particles/Collision/CollisionHandler.H b/Source/Particles/Collision/CollisionHandler.H
index 7adc15dec..caa1d1588 100644
--- a/Source/Particles/Collision/CollisionHandler.H
+++ b/Source/Particles/Collision/CollisionHandler.H
@@ -23,7 +23,7 @@
 class CollisionHandler
 {
 public:
-    CollisionHandler (MultiParticleContainer const * const mypc);
+    CollisionHandler (const MultiParticleContainer*  mypc);
 
     /* Perform all of the collisions */
     void doCollisions (amrex::Real cur_time, amrex::Real dt, MultiParticleContainer* mypc);