Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)

* add more readability checks to clang-tidy CI test

* reformat check list

* starting to address issues found with clang-tidy£

* addressing issues

* remove check

* address issues

* address all issues

* address issue found with github code scanning

5 files changed, 14 insertions, 14 deletions

diff --git a/Source/Particles/ElementaryProcess/Ionization.H b/Source/Particles/ElementaryProcess/Ionization.H
index 5d0dc8bf1..b6b746448 100644
--- a/Source/Particles/ElementaryProcess/Ionization.H
+++ b/Source/Particles/ElementaryProcess/Ionization.H
@@ -70,10 +70,10 @@ struct IonizationFilterFunc
                           amrex::FArrayBox const& bxfab,
                           amrex::FArrayBox const& byfab,
                           amrex::FArrayBox const& bzfab,
-                          const amrex::Real* const AMREX_RESTRICT a_ionization_energies,
-                          const amrex::Real* const AMREX_RESTRICT a_adk_prefactor,
-                          const amrex::Real* const AMREX_RESTRICT a_adk_exp_prefactor,
-                          const amrex::Real* const AMREX_RESTRICT a_adk_power,
+                          const amrex::Real* AMREX_RESTRICT a_ionization_energies,
+                          const amrex::Real* AMREX_RESTRICT a_adk_prefactor,
+                          const amrex::Real* AMREX_RESTRICT a_adk_exp_prefactor,
+                          const amrex::Real* AMREX_RESTRICT a_adk_power,
                           int a_comp,
                           int a_atomic_number,
                           int a_offset = 0) noexcept;
diff --git a/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.H b/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.H
index ab15a2d8f..2abd31fb4 100644
--- a/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.H
+++ b/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.H
@@ -334,14 +334,14 @@ public:
      */
     bool init_lookup_tables_from_raw_data (
         const std::vector<char>& raw_data,
-        const amrex::ParticleReal bw_minimum_chi_phot);
+        amrex::ParticleReal bw_minimum_chi_phot);
 
     /**
      * Init lookup tables using built-in (low resolution) tables
      *
      * @param[in] bw_minimum_chi_phot minimum chi parameter to evolve the optical depth of a photon
      */
-    void init_builtin_tables(const amrex::ParticleReal bw_minimum_chi_phot);
+    void init_builtin_tables(amrex::ParticleReal bw_minimum_chi_phot);
 
     /**
      * Computes the lookup tables. It does nothing unless WarpX is compiled with QED_TABLE_GEN=TRUE
@@ -349,8 +349,8 @@ public:
      * @param[in] ctrl control params to generate the tables
      * @param[in] bw_minimum_chi_phot minimum chi parameter to evolve the optical depth of a photon
      */
-    void compute_lookup_tables (const PicsarBreitWheelerCtrl ctrl,
-        const amrex::ParticleReal bw_minimum_chi_phot);
+    void compute_lookup_tables (PicsarBreitWheelerCtrl ctrl,
+        amrex::ParticleReal bw_minimum_chi_phot);
 
     /**
      * gets default values for the control parameters
diff --git a/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.H b/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.H
index 5529019d4..33660cde2 100644
--- a/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.H
+++ b/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.H
@@ -312,14 +312,14 @@ public:
      * @return true if it succeeds, false if it cannot parse raw_data
      */
     bool init_lookup_tables_from_raw_data (const std::vector<char>& raw_data,
-        const amrex::ParticleReal qs_minimum_chi_part);
+        amrex::ParticleReal qs_minimum_chi_part);
 
     /**
      * Init lookup tables using built-in (low resolution) tables
      *
      * @param[in] qs_minimum_chi_part minimum chi parameter to evolve the optical depth of a particle.
      */
-    void init_builtin_tables(const amrex::ParticleReal qs_minimum_chi_part);
+    void init_builtin_tables(amrex::ParticleReal qs_minimum_chi_part);
 
     /**
      * Computes the lookup tables. It does nothing unless WarpX is compiled with QED_TABLE_GEN=TRUE
@@ -328,7 +328,7 @@ public:
      * @param[in] qs_minimum_chi_part minimum chi parameter to evolve the optical depth of a particle.
      */
     void compute_lookup_tables (PicsarQuantumSyncCtrl ctrl,
-        const amrex::ParticleReal qs_minimum_chi_part);
+        amrex::ParticleReal qs_minimum_chi_part);
 
     /**
      * gets default values for the control parameters
diff --git a/Source/Particles/ElementaryProcess/QEDPairGeneration.H b/Source/Particles/ElementaryProcess/QEDPairGeneration.H
index a38d0754a..dbdbd0e6d 100644
--- a/Source/Particles/ElementaryProcess/QEDPairGeneration.H
+++ b/Source/Particles/ElementaryProcess/QEDPairGeneration.H
@@ -96,7 +96,7 @@ public:
     * @param[in] bzfab constant reference to the FArrayBox of the z component of the magnetic field
     * @param[in] a_offset offset to apply to the particle indices
     */
-    PairGenerationTransformFunc(BreitWheelerGeneratePairs const generate_functor,
+    PairGenerationTransformFunc(BreitWheelerGeneratePairs generate_functor,
                                 const WarpXParIter& a_pti, int lev, amrex::IntVect ngEB,
                                 amrex::FArrayBox const& exfab,
                                 amrex::FArrayBox const& eyfab,
diff --git a/Source/Particles/ElementaryProcess/QEDPhotonEmission.H b/Source/Particles/ElementaryProcess/QEDPhotonEmission.H
index 93aea3c3b..080555e6f 100644
--- a/Source/Particles/ElementaryProcess/QEDPhotonEmission.H
+++ b/Source/Particles/ElementaryProcess/QEDPhotonEmission.H
@@ -109,8 +109,8 @@ public:
     */
     PhotonEmissionTransformFunc (
         QuantumSynchrotronGetOpticalDepth opt_depth_functor,
-        int const opt_depth_runtime_comp,
-        QuantumSynchrotronPhotonEmission const emission_functor,
+        int opt_depth_runtime_comp,
+        QuantumSynchrotronPhotonEmission emission_functor,
         const WarpXParIter& a_pti, int lev, amrex::IntVect ngEB,
         amrex::FArrayBox const& exfab,
         amrex::FArrayBox const& eyfab,