Clang tidy CI test: add some modernize checks to clang-tidy CI test (#4133)

* Clang Tidy: add several modernize checks

* eliminate file included in commit by mistake

* fix bug

2 files changed, 6 insertions, 8 deletions

diff --git a/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.cpp b/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.cpp
index 249e35f6f..12f479d32 100644
--- a/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.cpp
+++ b/Source/Particles/ElementaryProcess/QEDInternals/BreitWheelerEngineWrapper.cpp
@@ -38,7 +38,7 @@ namespace pxr_sr = picsar::multi_physics::utils::serialization;
 BreitWheelerGetOpticalDepth
 BreitWheelerEngine::build_optical_depth_functor () const
 {
-    return BreitWheelerGetOpticalDepth();
+    return {};
 }
 
 BreitWheelerEvolveOpticalDepth
@@ -46,8 +46,7 @@ BreitWheelerEngine::build_evolve_functor () const
 {
     AMREX_ALWAYS_ASSERT(m_lookup_tables_initialized);
 
-    return BreitWheelerEvolveOpticalDepth(m_dndt_table.get_view(),
-        m_bw_minimum_chi_phot);
+    return {m_dndt_table.get_view(), m_bw_minimum_chi_phot};
 }
 
 BreitWheelerGeneratePairs
@@ -55,7 +54,7 @@ BreitWheelerEngine::build_pair_functor () const
 {
     AMREX_ALWAYS_ASSERT(m_lookup_tables_initialized);
 
-    return BreitWheelerGeneratePairs(m_pair_prod_table.get_view());
+    return {m_pair_prod_table.get_view()};
 }
 
 bool BreitWheelerEngine::are_lookup_tables_initialized () const
diff --git a/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.cpp b/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.cpp
index 280c1cfd4..c9bede891 100644
--- a/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.cpp
+++ b/Source/Particles/ElementaryProcess/QEDInternals/QuantumSyncEngineWrapper.cpp
@@ -38,22 +38,21 @@ namespace pxr_sr = picsar::multi_physics::utils::serialization;
 QuantumSynchrotronGetOpticalDepth
 QuantumSynchrotronEngine::build_optical_depth_functor ()
 {
-    return QuantumSynchrotronGetOpticalDepth();
+    return {};
 }
 
 QuantumSynchrotronEvolveOpticalDepth QuantumSynchrotronEngine::build_evolve_functor ()
 {
     AMREX_ALWAYS_ASSERT(m_lookup_tables_initialized);
 
-    return QuantumSynchrotronEvolveOpticalDepth(m_dndt_table.get_view(),
-        m_qs_minimum_chi_part);
+    return {m_dndt_table.get_view(), m_qs_minimum_chi_part};
 }
 
 QuantumSynchrotronPhotonEmission QuantumSynchrotronEngine::build_phot_em_functor ()
 {
     AMREX_ALWAYS_ASSERT(m_lookup_tables_initialized);
 
-    return QuantumSynchrotronPhotonEmission(m_phot_em_table.get_view());
+    return {m_phot_em_table.get_view()};
 
 }