diff options
| author |  Weiqun Zhang <WeiqunZhang@lbl.gov>
| 2021-07-13 20:51:16 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-07-13 20:51:16 -0700 |
| commit | 40e36e1860015214601d618c9ab847f623328867 (patch) | |
| tree | 718e4c794540e5d8cc9a31e54ae858a488b19164 /Source/Particles/MultiParticleContainer.cpp | |
| parent | 521112f66ad545749b9ae728379524ea3832ee47 (diff) | |
| download | WarpX-40e36e1860015214601d618c9ab847f623328867.tar.gz WarpX-40e36e1860015214601d618c9ab847f623328867.tar.zst WarpX-40e36e1860015214601d618c9ab847f623328867.zip | |
Update Monte Carlo Collisions (#2085)
* Update Monte Carlo Collisions
This addresses a number of issues in the Monte Carlo collision code.
* `MCCProcess` is not trivially copyable because it contains
`ManagedVector`. Therefore, it cannot be captured by GPU device lambda.
* The use of managed memory may have performance issues.
* There are memory leaks because some raw pointers allocated by `new` are
not `delete`d.
* `BackgroundMCCCollision` derives from a virtual base class, but the
compiler generated destructor is not automatically virtual.
* Apply suggestions from code review
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
* Apply the suggestion from @PhilMiller to get rid of unique_ptr
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Diffstat (limited to 'Source/Particles/MultiParticleContainer.cpp')
0 files changed, 0 insertions, 0 deletions