Clang tidy CI test: add more readability checks to clang tidy CI test (#4146)

* add more readability checks to clang-tidy CI test

* reformat check list

* starting to address issues found with clang-tidy£

* addressing issues

* remove check

* address issues

* address all issues

* address issue found with github code scanning

3 files changed, 8 insertions, 8 deletions

diff --git a/Source/Particles/Resampling/LevelingThinning.H b/Source/Particles/Resampling/LevelingThinning.H
index 7b491fc9d..d7db1e702 100644
--- a/Source/Particles/Resampling/LevelingThinning.H
+++ b/Source/Particles/Resampling/LevelingThinning.H
@@ -36,7 +36,7 @@ public:
      *
      * @param[in] species_name the name of the resampled species
      */
-    LevelingThinning (const std::string species_name);
+    LevelingThinning (std::string species_name);
 
     /**
      * \brief A method that performs leveling thinning for the considered species.
@@ -45,7 +45,7 @@ public:
      * @param[in] lev the index of the refinement level.
      * @param[in] pc a pointer to the particle container.
      */
-    void operator() (WarpXParIter& pti, const int lev, WarpXParticleContainer * const pc) const override final;
+    void operator() (WarpXParIter& pti, int lev, WarpXParticleContainer* pc) const override final;
 
 private:
     amrex::Real m_target_ratio = amrex::Real(1.5);
diff --git a/Source/Particles/Resampling/Resampling.H b/Source/Particles/Resampling/Resampling.H
index 3a065d239..820b14f5d 100644
--- a/Source/Particles/Resampling/Resampling.H
+++ b/Source/Particles/Resampling/Resampling.H
@@ -24,7 +24,7 @@ struct ResamplingAlgorithm
     /**
      * \brief Virtual operator() of the abstract ResamplingAlgorithm class
      */
-    virtual void operator() (WarpXParIter& /*pti*/, const int /*lev*/, WarpXParticleContainer* /*pc*/) const = 0;
+    virtual void operator() (WarpXParIter& /*pti*/, int /*lev*/, WarpXParticleContainer* /*pc*/) const = 0;
 
     /**
      * \brief Virtual destructor of the abstract ResamplingAlgorithm class
@@ -53,7 +53,7 @@ public:
      *
      * @param[in] species_name the name of the resampled species
      */
-    Resampling (const std::string species_name);
+    Resampling (std::string species_name);
 
     /**
      * \brief A method that returns true if resampling should be done for the considered species
@@ -62,7 +62,7 @@ public:
      * @param[in] timestep the current timestep
      * @param[in] global_numparts the total number of particles of the considered species
      */
-    bool triggered (const int timestep, const amrex::Real global_numparts) const;
+    bool triggered (int timestep, amrex::Real global_numparts) const;
 
     /**
      * \brief A method that uses the ResamplingAlgorithm object to perform resampling.
@@ -71,7 +71,7 @@ public:
      * @param[in] lev the index of the refinement level.
      * @param[in] pc a pointer to the particle container.
      */
-    void operator() (WarpXParIter& pti, const int lev, WarpXParticleContainer * const pc) const;
+    void operator() (WarpXParIter& pti, int lev, WarpXParticleContainer* pc) const;
 
 private:
     ResamplingTrigger m_resampling_trigger;
diff --git a/Source/Particles/Resampling/ResamplingTrigger.H b/Source/Particles/Resampling/ResamplingTrigger.H
index ce89adab8..42c3902c2 100644
--- a/Source/Particles/Resampling/ResamplingTrigger.H
+++ b/Source/Particles/Resampling/ResamplingTrigger.H
@@ -33,7 +33,7 @@ public:
      * \brief Constructor of the ResamplingTrigger class. Reads the resampling trigger parameters
      * from the input file.
      */
-    ResamplingTrigger (const std::string species_name);
+    ResamplingTrigger (std::string species_name);
 
     /**
      * \brief A method that returns true if resampling should be done for the considered species
@@ -42,7 +42,7 @@ public:
      * @param[in] timestep the current timestep
      * @param[in] global_numparts the total number of particles of the considered species
      */
-    bool triggered (const int timestep, const amrex::Real global_numparts) const;
+    bool triggered (int timestep, amrex::Real global_numparts) const;
 
     /**
      * \brief A method that initializes the member m_global_numcells. It is only called once (the