1D3V Cartesian Support (#2307)

* Build System: Add 1D Geometry

* test PR

* test PR

* 1D cartesian yee algorithm

* fixed typo

* Fixes for PML

* 1D support related multiple changes

* Fix compilation

* change 1D to 1D_Z

* 1D Field Gather and typo fix

* 1D Charge Deposition

* Particle Pusher

* multiple changes related to 1D

* 1D diagnostics and initialization

* PlasmaInjector and PEC fixes for 1D

* clean-up delete diags file

* mobility 1D laser particle and bilinear filter

* deleted diags files

* update laser particle weight formula

* delete diags files

* Azure: Add 1D Cartesian Runner

* 1D fixes for FieldProbe

* Update Docs/source/developers/dimensionality.rst

Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>

* 1d laser injection and langmuir test input files

* 1d tests

* clean up : delete print statements

* analyse simulation result for laser injection and Langmuir tests

* EOL

* delete input files for which there are no automated tests

* delete input files for which there are no automated tests

* add ignore_unused to remove warnings

* remove space

* Fix compilation issues

* fix error : macro name must be an identifier

* Small bug fix

* cleanup Python script for analysis

* bug fix

* bug fix

* Update ParticleProbe: Check 1D in-domain

* Update Source/Make.WarpX

* Update .azure-pipelines.yml

* Add USE_OPENPMD=FALSE to .azure-pipeline.yml

* resolve conflict

* resolve conflict

* fix typo

* Correct out-of-bound access

* Fix Particle BC in WarpXParticleContainer and correct path to checksumAPI in python analysis scripts

* EOL

* Fix bug : accessing out of bound index of cell in 1D

* remove 1d test for cartesian3d

* Fix CI check

* Slight style change

* Address review comments

* Fix GPU compilation Filter.cpp

* Fix CI

* Fix Indentation

* Address review comments

* More consistent ifdef for dimension bigger than 1

* Update Examples/Tests/Langmuir/analysis_langmuir_multi_1d.py

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update GNUmakefile

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Regression/prepare_file_ci.py

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianCKCAlgorithm.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianNodalAlgorithm.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Initialization/PlasmaInjector.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Initialization/PlasmaInjector.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* add comment inline to explain twice push_back

* Add amrex::Abort for NCIGodfreyFilter

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Prabhat Kumar <prabhatkumar@kraken.dhcp.lbl.gov>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <rlehe@lbl.gov>

1 files changed, 20 insertions, 4 deletions

diff --git a/Source/Particles/WarpXParticleContainer.cpp b/Source/Particles/WarpXParticleContainer.cpp
index 554d8fee4..f7cb27b28 100644
--- a/Source/Particles/WarpXParticleContainer.cpp
+++ b/Source/Particles/WarpXParticleContainer.cpp
@@ -109,12 +109,16 @@ WarpXParticleContainer::WarpXParticleContainer (AmrCore* amr_core, int ispecies)
     // The boundary conditions are read in in ReadBCParams but a child class
     // can allow these value to be overwritten if different boundary
     // conditions are desired for a specific species
+#ifndef WARPX_DIM_1D_Z
     m_boundary_conditions.SetBoundsX(WarpX::particle_boundary_lo[0], WarpX::particle_boundary_hi[0]);
+#endif
 #ifdef WARPX_DIM_3D
     m_boundary_conditions.SetBoundsY(WarpX::particle_boundary_lo[1], WarpX::particle_boundary_hi[1]);
     m_boundary_conditions.SetBoundsZ(WarpX::particle_boundary_lo[2], WarpX::particle_boundary_hi[2]);
-#else
+#elif WARPX_DIM_XZ || WARPX_DIM_RZ
     m_boundary_conditions.SetBoundsZ(WarpX::particle_boundary_lo[1], WarpX::particle_boundary_hi[1]);
+#else
+    m_boundary_conditions.SetBoundsZ(WarpX::particle_boundary_lo[0], WarpX::particle_boundary_hi[0]);
 #endif
     m_boundary_conditions.BuildReflectionModelParsers();
 }
@@ -212,6 +216,9 @@ WarpXParticleContainer::AddNParticles (int /*lev*/,
         p.pos(0) = x[i];
 #endif
         p.pos(1) = z[i];
+#else //AMREX_SPACEDIM == 1
+        amrex::ignore_unused(x,y);
+        p.pos(0) = z[i];
 #endif
 
         pinned_tile.push_back(p);
@@ -325,7 +332,9 @@ WarpXParticleContainer::DepositCurrent (WarpXParIter& pti,
     // deposit part of its current in a neighboring box. However, this should catch particles
     // traveling many cells away, for example with algorithms that allow for large time steps.
 
-#if   (AMREX_SPACEDIM == 2)
+#if   (AMREX_SPACEDIM == 1)
+    const amrex::IntVect shape_extent = amrex::IntVect(static_cast<int>(WarpX::noz/2));
+#elif   (AMREX_SPACEDIM == 2)
     const amrex::IntVect shape_extent = amrex::IntVect(static_cast<int>(WarpX::nox/2),
                                                        static_cast<int>(WarpX::noz/2));
 #elif (AMREX_SPACEDIM == 3)
@@ -608,7 +617,9 @@ WarpXParticleContainer::DepositCharge (WarpXParIter& pti, RealVector& wp,
     // are not trivial, this check might be too strict and we might need to relax it, as currently
     // done for the current deposition.
 
-#if   (AMREX_SPACEDIM == 2)
+#if   (AMREX_SPACEDIM == 1)
+    const amrex::IntVect shape_extent = amrex::IntVect(static_cast<int>(WarpX::noz/2+1));
+#elif   (AMREX_SPACEDIM == 2)
     const amrex::IntVect shape_extent = amrex::IntVect(static_cast<int>(WarpX::nox/2+1),
                                                        static_cast<int>(WarpX::noz/2+1));
 #elif (AMREX_SPACEDIM == 3)
@@ -1132,8 +1143,10 @@ WarpXParticleContainer::ApplyBoundaryConditions (){
         {
             auto GetPosition = GetParticlePosition(pti);
             auto SetPosition = SetParticlePosition(pti);
+#ifndef WARPX_DIM_1D_Z
             const Real xmin = Geom(lev).ProbLo(0);
             const Real xmax = Geom(lev).ProbHi(0);
+#endif
 #ifdef WARPX_DIM_3D
             const Real ymin = Geom(lev).ProbLo(1);
             const Real ymax = Geom(lev).ProbHi(1);
@@ -1163,7 +1176,10 @@ WarpXParticleContainer::ApplyBoundaryConditions (){
                     // Note that for RZ, (x, y, z) is actually (r, theta, z).
 
                     bool particle_lost = false;
-                    ApplyParticleBoundaries::apply_boundaries(x, xmin, xmax,
+                    ApplyParticleBoundaries::apply_boundaries(
+#ifndef WARPX_DIM_1D_Z
+                                                              x, xmin, xmax,
+#endif
 #ifdef WARPX_DIM_3D
                                                               y, ymin, ymax,
 #endif