Fix miscellaneous issues found with clang tidy (#3083)

* fix miscellaneous issues found with clang tidy
* fix miscellaneous issues found with clang tidy
* moved default constructors and destructors to header
* fix issue
* Use default again

2 files changed, 17 insertions, 17 deletions

diff --git a/Source/Particles/MultiParticleContainer.cpp b/Source/Particles/MultiParticleContainer.cpp
index da1c692ba..6349fe3d9 100644
--- a/Source/Particles/MultiParticleContainer.cpp
+++ b/Source/Particles/MultiParticleContainer.cpp
@@ -689,37 +689,37 @@ MultiParticleContainer
             // and Fills parts[species number i] with particle data from all grids and
             // tiles in diagnostic_particles. parts contains particles from all
             // AMR levels indistinctly.
-            for (auto it = diagnostic_particles[lev].begin(); it != diagnostic_particles[lev].end(); ++it){
+            for (const auto& dp : diagnostic_particles[lev]){
                 // it->first is the [grid index][tile index] key
                 // it->second is the corresponding
                 // WarpXParticleContainer::DiagnosticParticleData value
                 parts[i].GetRealData(DiagIdx::w).insert(  parts[i].GetRealData(DiagIdx::w  ).end(),
-                                                          it->second.GetRealData(DiagIdx::w  ).begin(),
-                                                          it->second.GetRealData(DiagIdx::w  ).end());
+                                                          dp.second.GetRealData(DiagIdx::w  ).begin(),
+                                                          dp.second.GetRealData(DiagIdx::w  ).end());
 
                 parts[i].GetRealData(DiagIdx::x).insert(  parts[i].GetRealData(DiagIdx::x  ).end(),
-                                                          it->second.GetRealData(DiagIdx::x  ).begin(),
-                                                          it->second.GetRealData(DiagIdx::x  ).end());
+                                                          dp.second.GetRealData(DiagIdx::x  ).begin(),
+                                                          dp.second.GetRealData(DiagIdx::x  ).end());
 
                 parts[i].GetRealData(DiagIdx::y).insert(  parts[i].GetRealData(DiagIdx::y  ).end(),
-                                                          it->second.GetRealData(DiagIdx::y  ).begin(),
-                                                          it->second.GetRealData(DiagIdx::y  ).end());
+                                                          dp.second.GetRealData(DiagIdx::y  ).begin(),
+                                                          dp.second.GetRealData(DiagIdx::y  ).end());
 
                 parts[i].GetRealData(DiagIdx::z).insert(  parts[i].GetRealData(DiagIdx::z  ).end(),
-                                                          it->second.GetRealData(DiagIdx::z  ).begin(),
-                                                          it->second.GetRealData(DiagIdx::z  ).end());
+                                                          dp.second.GetRealData(DiagIdx::z  ).begin(),
+                                                          dp.second.GetRealData(DiagIdx::z  ).end());
 
                 parts[i].GetRealData(DiagIdx::ux).insert(  parts[i].GetRealData(DiagIdx::ux).end(),
-                                                           it->second.GetRealData(DiagIdx::ux).begin(),
-                                                           it->second.GetRealData(DiagIdx::ux).end());
+                                                           dp.second.GetRealData(DiagIdx::ux).begin(),
+                                                           dp.second.GetRealData(DiagIdx::ux).end());
 
                 parts[i].GetRealData(DiagIdx::uy).insert(  parts[i].GetRealData(DiagIdx::uy).end(),
-                                                           it->second.GetRealData(DiagIdx::uy).begin(),
-                                                           it->second.GetRealData(DiagIdx::uy).end());
+                                                           dp.second.GetRealData(DiagIdx::uy).begin(),
+                                                           dp.second.GetRealData(DiagIdx::uy).end());
 
                 parts[i].GetRealData(DiagIdx::uz).insert(  parts[i].GetRealData(DiagIdx::uz).end(),
-                                                           it->second.GetRealData(DiagIdx::uz).begin(),
-                                                           it->second.GetRealData(DiagIdx::uz).end());
+                                                           dp.second.GetRealData(DiagIdx::uz).begin(),
+                                                           dp.second.GetRealData(DiagIdx::uz).end());
             }
         }
     }
diff --git a/Source/Particles/WarpXParticleContainer.cpp b/Source/Particles/WarpXParticleContainer.cpp
index 1d057f5a2..ca9b99500 100644
--- a/Source/Particles/WarpXParticleContainer.cpp
+++ b/Source/Particles/WarpXParticleContainer.cpp
@@ -783,8 +783,8 @@ Real WarpXParticleContainer::sumParticleCharge(bool local) {
         for (WarpXParIter pti(*this, lev); pti.isValid(); ++pti)
         {
             auto& wp = pti.GetAttribs(PIdx::w);
-            for (unsigned long i = 0; i < wp.size(); i++) {
-                total_charge += wp[i];
+            for (const auto& tt : wp) {
+                total_charge += tt;
             }
         }
     }