Enforce const correctness using clang-tidy CI test (#3921)

* add clang-tidy workflow

* fix missing newline

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* make clang.14.sh executable

* remove non explicitly selected checks

* complete list of dependencies

* fix bug

* specify path of clang-tidy file

* fix bug

* add new check

* remove one check

* add magic numbers check

* removed one check

* keep only one check

* Docs: Conda Dev w/ Boost (#3911)

Add the `boost` package to the conda developer environment.
Used for QED table generation.

* Fix typo in Adastra cluster documentation (#3918)

* add back three checks

* prepare clang-tidy wrapper

* actually use clang-tidy in the script

* test

* fix bug

* actually use clang-tidy

* fixed bug

* fixed bug

* fixed bug

* fixed bug

* remove all checks except the selected 3

* fixed bug

* fixed bug

* fixed bug

* enforce const correctness using clang-tidy

* remove one check

* Fix Concurrency Issue

* BLAS++/LAPACK++ for RZ+PSATD

* Build all 4 WarpX DIMS

* add few echo for test purposes

* try to debug mysterious error

* don't test RZ with clang-tidy

* add back RZ test

* add some const

* fix bug

* check also header files

* remove header filter since it does not work as expected

* fixed bug

* check also WarpX headers

* fix bugs

* continue enforcing const correctness

* continue enforcing const correctness

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed bug

* fix bugs and add new const

* clean .clang-tidy

* make regex more precise according to Weiqun's suggestion

* add more const

* fix bugs

* fix bug

* silence warning on float comparison

* fixed bug

* fixed bugs

* fix bug and add const

* fixed bugs

* fix bug

* fix bug

* fix bug

* fixed bug

* fix bug

1 files changed, 9 insertions, 9 deletions

diff --git a/Source/Python/WarpXWrappers.cpp b/Source/Python/WarpXWrappers.cpp
index ec9b52da9..4f32f4ed8 100644
--- a/Source/Python/WarpXWrappers.cpp
+++ b/Source/Python/WarpXWrappers.cpp
@@ -59,7 +59,7 @@ namespace
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
         for ( amrex::MFIter mfi(mf, false); mfi.isValid(); ++mfi ) {
-            int i = mfi.LocalIndex();
+            const int i = mfi.LocalIndex();
             data[i] = mf[mfi].dataPtr();
             for (int j = 0; j < AMREX_SPACEDIM; ++j) {
                 (*shapes)[shapesize*i+j] = mf[mfi].box().length(j);
@@ -70,7 +70,7 @@ namespace
     }
     int* getMultiFabLoVects (const amrex::MultiFab& mf, int *num_boxes, int **ngrowvect)
     {
-        int shapesize = AMREX_SPACEDIM;
+        const int shapesize = AMREX_SPACEDIM;
         *ngrowvect = static_cast<int*>(malloc(sizeof(int)*shapesize));
         for (int j = 0; j < AMREX_SPACEDIM; ++j) {
             (*ngrowvect)[j] = mf.nGrow(j);
@@ -481,7 +481,7 @@ namespace
         const std::string species_name(char_species_name);
         auto & myspc = mypc.GetParticleContainerFromName(species_name);
 
-        int comp = warpx_getParticleCompIndex(char_species_name, char_comp_name);
+        const int comp = warpx_getParticleCompIndex(char_species_name, char_comp_name);
 
         *num_tiles = myspc.numLocalTilesAtLevel(lev);
         *particles_per_tile = static_cast<int*>(malloc(*num_tiles*sizeof(int)));
@@ -724,7 +724,7 @@ namespace
     }
 
     int warpx_getistep (int lev) {
-        WarpX& warpx = WarpX::GetInstance();
+        const WarpX& warpx = WarpX::GetInstance();
         return warpx.getistep(lev);
     }
     void warpx_setistep (int lev, int ii) {
@@ -732,7 +732,7 @@ namespace
         warpx.setistep(lev, ii);
     }
     amrex::Real warpx_gett_new (int lev) {
-        WarpX& warpx = WarpX::GetInstance();
+        const WarpX& warpx = WarpX::GetInstance();
         return warpx.gett_new(lev);
     }
     void warpx_sett_new (int lev, amrex::Real time) {
@@ -740,21 +740,21 @@ namespace
         warpx.sett_new(lev, time);
     }
     amrex::Real warpx_getdt (int lev) {
-        WarpX& warpx = WarpX::GetInstance();
+        const WarpX& warpx = WarpX::GetInstance();
         return warpx.getdt(lev);
     }
 
     int warpx_maxStep () {
-        WarpX& warpx = WarpX::GetInstance();
+        const WarpX& warpx = WarpX::GetInstance();
         return warpx.maxStep();
     }
     amrex::Real warpx_stopTime () {
-        WarpX& warpx = WarpX::GetInstance();
+        const WarpX& warpx = WarpX::GetInstance();
         return warpx.stopTime();
     }
 
     int warpx_finestLevel () {
-        WarpX& warpx = WarpX::GetInstance();
+        const WarpX& warpx = WarpX::GetInstance();
         return warpx.finestLevel();
     }