1D3V Cartesian Support (#2307)

* Build System: Add 1D Geometry

* test PR

* test PR

* 1D cartesian yee algorithm

* fixed typo

* Fixes for PML

* 1D support related multiple changes

* Fix compilation

* change 1D to 1D_Z

* 1D Field Gather and typo fix

* 1D Charge Deposition

* Particle Pusher

* multiple changes related to 1D

* 1D diagnostics and initialization

* PlasmaInjector and PEC fixes for 1D

* clean-up delete diags file

* mobility 1D laser particle and bilinear filter

* deleted diags files

* update laser particle weight formula

* delete diags files

* Azure: Add 1D Cartesian Runner

* 1D fixes for FieldProbe

* Update Docs/source/developers/dimensionality.rst

Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>

* 1d laser injection and langmuir test input files

* 1d tests

* clean up : delete print statements

* analyse simulation result for laser injection and Langmuir tests

* EOL

* delete input files for which there are no automated tests

* delete input files for which there are no automated tests

* add ignore_unused to remove warnings

* remove space

* Fix compilation issues

* fix error : macro name must be an identifier

* Small bug fix

* cleanup Python script for analysis

* bug fix

* bug fix

* Update ParticleProbe: Check 1D in-domain

* Update Source/Make.WarpX

* Update .azure-pipelines.yml

* Add USE_OPENPMD=FALSE to .azure-pipeline.yml

* resolve conflict

* resolve conflict

* fix typo

* Correct out-of-bound access

* Fix Particle BC in WarpXParticleContainer and correct path to checksumAPI in python analysis scripts

* EOL

* Fix bug : accessing out of bound index of cell in 1D

* remove 1d test for cartesian3d

* Fix CI check

* Slight style change

* Address review comments

* Fix GPU compilation Filter.cpp

* Fix CI

* Fix Indentation

* Address review comments

* More consistent ifdef for dimension bigger than 1

* Update Examples/Tests/Langmuir/analysis_langmuir_multi_1d.py

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update GNUmakefile

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Regression/prepare_file_ci.py

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianCKCAlgorithm.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceAlgorithms/CartesianNodalAlgorithm.H

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Filter/Filter.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Initialization/PlasmaInjector.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* Update Source/Initialization/PlasmaInjector.cpp

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

* add comment inline to explain twice push_back

* Add amrex::Abort for NCIGodfreyFilter

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Prabhat Kumar <prabhatkumar@kraken.dhcp.lbl.gov>
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Co-authored-by: Remi Lehe <rlehe@lbl.gov>

1 files changed, 26 insertions, 3 deletions

diff --git a/Source/Utils/WarpXMovingWindow.cpp b/Source/Utils/WarpXMovingWindow.cpp
index 600ad180e..3bb48d1a5 100644
--- a/Source/Utils/WarpXMovingWindow.cpp
+++ b/Source/Utils/WarpXMovingWindow.cpp
@@ -63,6 +63,12 @@ WarpX::UpdatePlasmaInjectionPosition (amrex::Real a_dt)
             // This needs to be converted in order to index `boost_direction`
             // which has 3 components, for both 2D and 3D simulations.
             WarpX::boost_direction[2*dir] * PhysConst::c * a_dt;
+#elif ( AMREX_SPACEDIM == 1 )
+            // In 1D, dir=0 corresponds to z
+            // This needs to be converted in order to index `boost_direction`
+            // which has 3 components, for 1D, 2D, and 3D simulations.
+            WarpX::boost_direction[2] * PhysConst::c * a_dt;
+            amrex::ignore_unused(dir);
 #endif
     }
 }
@@ -365,13 +371,20 @@ WarpX::shiftMF (amrex::MultiFab& mf, const amrex::Geometry& geom, int num_shift,
                       [=] AMREX_GPU_DEVICE (int i, int j, int k, int n) noexcept
                 {
                       // Compute x,y,z co-ordinates based on index type of mf
+#if (AMREX_SPACEDIM==1)
+                      amrex::Real x = 0.0;
+                      amrex::Real y = 0.0;
+                      amrex::Real fac_z = (1.0 - mf_type[0]) * dx[0]*0.5;
+                      amrex::Real z = i*dx[0] + real_box.lo(0) + fac_z;
+#elif (AMREX_SPACEDIM==2)
                       amrex::Real fac_x = (1.0 - mf_type[0]) * dx[0]*0.5;
                       amrex::Real x = i*dx[0] + real_box.lo(0) + fac_x;
-#if (AMREX_SPACEDIM==2)
                       amrex::Real y = 0.0;
                       amrex::Real fac_z = (1.0 - mf_type[1]) * dx[1]*0.5;
                       amrex::Real z = j*dx[1] + real_box.lo(1) + fac_z;
 #else
+                      amrex::Real fac_x = (1.0 - mf_type[0]) * dx[0]*0.5;
+                      amrex::Real x = i*dx[0] + real_box.lo(0) + fac_x;
                       amrex::Real fac_y = (1.0 - mf_type[1]) * dx[1]*0.5;
                       amrex::Real y = j*dx[1] + real_box.lo(1) + fac_y;
                       amrex::Real fac_z = (1.0 - mf_type[2]) * dx[2]*0.5;
@@ -417,6 +430,11 @@ WarpX::ShiftGalileanBoundary ()
             m_v_galilean[0]*time_shift,
             std::numeric_limits<amrex::Real>::quiet_NaN(),
             m_v_galilean[2]*time_shift };
+#elif (AMREX_SPACEDIM == 1)
+        m_galilean_shift = {
+            std::numeric_limits<Real>::quiet_NaN(),
+            std::numeric_limits<Real>::quiet_NaN(),
+            m_v_galilean[2]*time_shift };
 #endif
 
 #if (AMREX_SPACEDIM == 3)
@@ -430,8 +448,13 @@ WarpX::ShiftGalileanBoundary ()
         new_hi[0] = current_hi[0] + m_galilean_shift[0];
         new_lo[1] = current_lo[1] + m_galilean_shift[2];
         new_hi[1] = current_hi[1] + m_galilean_shift[2];
-      }
-    #endif
+    }
+#elif (AMREX_SPACEDIM == 1)
+    {
+        new_lo[0] = current_lo[0] + m_galilean_shift[2];
+        new_hi[0] = current_hi[0] + m_galilean_shift[2];
+    }
+#endif
     time_of_last_gal_shift = cur_time;
 
     ResetProbDomain(amrex::RealBox(new_lo, new_hi));