aboutsummaryrefslogtreecommitdiff
path: root/Source/Particles/Collision/BinaryCollision
diff options
context:
space:
mode:
Diffstat (limited to 'Source/Particles/Collision/BinaryCollision')
-rw-r--r--Source/Particles/Collision/BinaryCollision/BinaryCollision.H2
-rw-r--r--Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H10
-rw-r--r--Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H6
3 files changed, 9 insertions, 9 deletions
diff --git a/Source/Particles/Collision/BinaryCollision/BinaryCollision.H b/Source/Particles/Collision/BinaryCollision/BinaryCollision.H
index c52182681..5473f0093 100644
--- a/Source/Particles/Collision/BinaryCollision/BinaryCollision.H
+++ b/Source/Particles/Collision/BinaryCollision/BinaryCollision.H
@@ -96,7 +96,7 @@ public:
const amrex::ParmParse pp_collision_name(collision_name);
pp_collision_name.queryarr("product_species", m_product_species);
- m_have_product_species = m_product_species.size() > 0;
+ m_have_product_species = !m_product_species.empty();
m_copy_transform_functor = CopyTransformFunctorType(collision_name, mypc);
}
diff --git a/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H b/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H
index 09213ba03..0a7aae983 100644
--- a/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H
+++ b/Source/Particles/Collision/BinaryCollision/BinaryCollisionUtils.H
@@ -29,13 +29,13 @@ enum struct NuclearFusionType {
namespace BinaryCollisionUtils{
- NuclearFusionType get_nuclear_fusion_type (const std::string collision_name,
- MultiParticleContainer const * const mypc);
+ NuclearFusionType get_nuclear_fusion_type (std::string collision_name,
+ MultiParticleContainer const * mypc);
- CollisionType get_collision_type (const std::string collision_name,
- MultiParticleContainer const * const mypc);
+ CollisionType get_collision_type (std::string collision_name,
+ MultiParticleContainer const * mypc);
- CollisionType nuclear_fusion_type_to_collision_type (const NuclearFusionType fusion_type);
+ CollisionType nuclear_fusion_type_to_collision_type (NuclearFusionType fusion_type);
}
#endif // BINARY_COLLISION_UTILS_H_
diff --git a/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H b/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H
index 0868e3131..3b81dfa87 100644
--- a/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H
+++ b/Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H
@@ -50,7 +50,7 @@ public:
* @param[in] collision_name the name of the collision
* @param[in] mypc pointer to the MultiParticleContainer
*/
- ParticleCreationFunc (const std::string collision_name, MultiParticleContainer const * const mypc);
+ ParticleCreationFunc (std::string collision_name, MultiParticleContainer const * mypc);
/**
* \brief operator() of the ParticleCreationFunc class. It creates new particles from binary
@@ -99,7 +99,7 @@ public:
AMREX_INLINE
amrex::Vector<int> operator() (
const index_type& n_total_pairs,
- const SoaData_type soa_1, const SoaData_type soa_2,
+ const SoaData_type& soa_1, const SoaData_type& soa_2,
ParticleTileType** AMREX_RESTRICT tile_products,
ParticleType* particle_ptr_1, ParticleType* particle_ptr_2,
const amrex::ParticleReal& m1, const amrex::ParticleReal& m2,
@@ -286,7 +286,7 @@ public:
AMREX_INLINE
amrex::Vector<int> operator() (
const index_type& /*n_total_pairs*/,
- const SoaData_type /*soa_1*/, const SoaData_type /*soa_2*/,
+ const SoaData_type& /*soa_1*/, const SoaData_type& /*soa_2*/,
ParticleTileType** /*tile_products*/,
ParticleType* /*particle_ptr_1*/, ParticleType* /*particle_ptr_2*/,
const amrex::ParticleReal& /*m1*/, const amrex::ParticleReal& /*m2*/,