Age | Commit message (Collapse) | Author | Files | Lines |
|
* Clang Tidy: add several modernize checks
* eliminate file included in commit by mistake
* fix bug
|
|
* add some performance checks in clang-tidy CI test
* fix few smalle performance issues found with clang-tidy
* fix bug
* fixed bug
* fixed performance issue
|
|
* use iwyu on ablastr
* fix bug
* add missing include
* always include AMReX_ParallelDescriptor in Logger.cpp
|
|
* add clang-tidy workflow
* fix missing newline
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* make clang.14.sh executable
* remove non explicitly selected checks
* complete list of dependencies
* fix bug
* specify path of clang-tidy file
* fix bug
* add new check
* remove one check
* add magic numbers check
* removed one check
* keep only one check
* Docs: Conda Dev w/ Boost (#3911)
Add the `boost` package to the conda developer environment.
Used for QED table generation.
* Fix typo in Adastra cluster documentation (#3918)
* add back three checks
* prepare clang-tidy wrapper
* actually use clang-tidy in the script
* test
* fix bug
* actually use clang-tidy
* fixed bug
* fixed bug
* fixed bug
* fixed bug
* remove all checks except the selected 3
* fixed bug
* fixed bug
* fixed bug
* enforce const correctness using clang-tidy
* remove one check
* Fix Concurrency Issue
* BLAS++/LAPACK++ for RZ+PSATD
* Build all 4 WarpX DIMS
* add few echo for test purposes
* try to debug mysterious error
* don't test RZ with clang-tidy
* add back RZ test
* add some const
* fix bug
* check also header files
* remove header filter since it does not work as expected
* fixed bug
* check also WarpX headers
* fix bugs
* continue enforcing const correctness
* continue enforcing const correctness
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fixed bug
* fix bugs and add new const
* clean .clang-tidy
* make regex more precise according to Weiqun's suggestion
* add more const
* fix bugs
* fix bug
* silence warning on float comparison
* fixed bug
* fixed bugs
* fix bug and add const
* fixed bugs
* fix bug
* fix bug
* fix bug
* fixed bug
* fix bug
|
|
Simplify the logic by fusing a loop.
|
|
* Fix: `MPI_CXX_BOOL` -> `MPI_BYTE`
C99 types were aded in MPI-2.2, while Cray's MPICH fork in version
8.1.13 defines `MPI_CXX_BOOL` to `MPI_DATATYPE_NULL` on Perlmutter.
We could use `MPI_C_BOOL`, which is technically a `_Bool` from
[<cstdbool>](https://en.cppreference.com/w/cpp/header/cstdbool)
(deprecated: C++17; removed: C++20) - or we simply do a static
assert on `sizeof(bool)` and communicate as a `MPI_BYTE` or
`MPI_CHAR`.
* Signals: Do no MPI Comms if none is configured
* Docs: Link and Explain Allowed Signal Values
* Review Comments & Style
|
|
* Beginnings of signal handling machinery
* Add tentative logic to make checkpoint call
* Adapt formatting slightly
* Add calls to read signals and set up signal handlers
* Initialize signal flag array
* Add parsing of signal names, and fix some whitespace issues
* Skip signal setup on Windows
* added checkpoint and break signal inputs to picmi.py
* Address initial review requests
* Correct comment to match changed code
* Convert maximum signal number to a symbolic name
* Always parse signal input, and error out on Windows or wherever it may be unsupported
* Typo fix
* Add missing reset of checkpoint signal flag
* Add reset of break signal, in support of Python or library usage
* Test for a configured checkpoint diag when asked to checkpoint on a signal
* Fix typo in Linux code path
* Clean up MPI support
* Use symbolic name for maximum signal number
* Fix unused variable in the no-MPI case
* Add missing header inclusions
* Switch signal parsing to an enumerated table
* Test signal handling for Linux, not GNU C library
* Avoid another magic number
* Update MPI_Ibcast call to match symbolic array length
* Update loop over signal flags to use symbolic limit
* Match #includes to usage
* Add omitted C++ std <atomic> header include
* Guard entire set of signal definitions as *nix-only, not for Windows
* Broaden Windows exclusion to avoid zero-length array that displeases MSVC++
* Check return value from sigaction()
* Convert conditional calls to Abort() to assertions
* Move check for platform support to input parsing
* Shift signal handling code over toward ABLASTR to share with ImpactX and Hipace++
* Minor cleanup
* A bit more cleanup
* Fix formatting nits
* Add AMReX error handling on MPI calls
* Add ABLASTR signal handling code to GNU makefile too
* Document new input parameters
* Use ABLASTR assertion macros in ABLASTR code
* Convert requests limit value to a requests array size
* Generalize signal handling to an arbitrary set of potential actions
* Rename class to match usage and file name
* Stick stuff in ABLASTR namespace
* Indent conditional includes as requested
Co-authored-by: Roelof <roelof.groenewald@modernelectron.com>
|