diff options
author | 2025-02-07 09:09:37 +0000 | |
---|---|---|
committer | 2025-02-07 09:09:37 +0000 | |
commit | 0063ecb06335b653935fb056481efbe80bf90087 (patch) | |
tree | 7c184168e8d4a66b50d43f5a62a06bcbf1970075 | |
parent | 9b8042a1ed2068c398d77a73503b82d3e68424d1 (diff) | |
download | astro-0063ecb06335b653935fb056481efbe80bf90087.tar.gz astro-0063ecb06335b653935fb056481efbe80bf90087.tar.zst astro-0063ecb06335b653935fb056481efbe80bf90087.zip |
chore: fix linting issues
12 files changed, 28 insertions, 35 deletions
diff --git a/packages/integrations/cloudflare/src/index.ts b/packages/integrations/cloudflare/src/index.ts index d38594f15..b0c08cdcf 100644 --- a/packages/integrations/cloudflare/src/index.ts +++ b/packages/integrations/cloudflare/src/index.ts @@ -192,7 +192,7 @@ export default function createIntegration(args?: Options): AstroIntegration { const clientLocalsSymbol = Symbol.for('astro.locals'); - server.middlewares.use(async function middleware(req, res, next) { + server.middlewares.use(async function middleware(req, _res, next) { Reflect.set(req, clientLocalsSymbol, { runtime: { env: platformProxy.env, @@ -265,7 +265,7 @@ export default function createIntegration(args?: Options): AstroIntegration { for (const file of PLATFORM_FILES) { try { await rename(new URL(file, _config.build.client), new URL(file, _config.outDir)); - } catch (e) { + } catch (_e) { logger.error( `There was an error moving ${file} to the root of the output directory.`, ); @@ -279,7 +279,7 @@ export default function createIntegration(args?: Options): AstroIntegration { if (redirectsStat.isFile()) { redirectsExists = true; } - } catch (error) { + } catch (_error) { redirectsExists = false; } @@ -314,7 +314,7 @@ export default function createIntegration(args?: Options): AstroIntegration { if (routesStat.isFile()) { routesExists = true; } - } catch (error) { + } catch (_error) { routesExists = false; } @@ -347,7 +347,7 @@ export default function createIntegration(args?: Options): AstroIntegration { if (!trueRedirects.empty()) { try { await appendFile(new URL('./_redirects', _config.outDir), trueRedirects.print()); - } catch (error) { + } catch (_error) { logger.error('Failed to write _redirects file'); } } diff --git a/packages/integrations/cloudflare/src/utils/cloudflare-module-loader.ts b/packages/integrations/cloudflare/src/utils/cloudflare-module-loader.ts index 0b6f82cf3..7017acd57 100644 --- a/packages/integrations/cloudflare/src/utils/cloudflare-module-loader.ts +++ b/packages/integrations/cloudflare/src/utils/cloudflare-module-loader.ts @@ -127,7 +127,7 @@ export function cloudflareModuleLoader( // chunk id can be many things, (alpha numeric, dollars, or underscores, maybe more) replaced = replaced.replaceAll( new RegExp(`${MAGIC_STRING}([^\\s]+?)${escapeRegExp(extension)}\\.mjs`, 'g'), - (s, assetId) => { + (_s, assetId) => { const fileName = this.getFileName(assetId); const relativePath = path .relative(path.dirname(chunk.fileName), fileName) diff --git a/packages/integrations/cloudflare/src/utils/generate-routes-json.ts b/packages/integrations/cloudflare/src/utils/generate-routes-json.ts index f12782b7b..eea7c38e1 100644 --- a/packages/integrations/cloudflare/src/utils/generate-routes-json.ts +++ b/packages/integrations/cloudflare/src/utils/generate-routes-json.ts @@ -63,7 +63,7 @@ async function writeRoutesFileToOutDir( ), 'utf-8', ); - } catch (error) { + } catch (_error) { logger.error("There was an error writing the '_routes.json' file to the output directory."); } } @@ -94,9 +94,9 @@ class PathTrie { this.root = new TrieNode(); } - insert(path: string[]) { + insert(thisPath: string[]) { let node = this.root; - for (const segment of path) { + for (const segment of thisPath) { if (segment === '*') { node.hasWildcardChild = true; break; @@ -105,7 +105,6 @@ class PathTrie { node.children.set(segment, new TrieNode()); } - // biome-ignore lint/style/noNonNullAssertion: The `if` condition above ensures that the segment exists inside the map node = node.children.get(segment)!; } @@ -117,19 +116,19 @@ class PathTrie { * It makes sure that all necessary paths are returned, but not paths with an existing wildcard prefix. * e.g. if we have a path like /foo/* and /foo/bar, we only want to return /foo/* */ - private dfs(node: TrieNode, path: string[], allPaths: string[][]): void { + private dfs(node: TrieNode, thisPath: string[], allPaths: string[][]): void { if (node.hasWildcardChild) { this.returnHasWildcard = true; - allPaths.push([...path, '*']); + allPaths.push([...thisPath, '*']); return; } if (node.isEndOfPath) { - allPaths.push([...path]); + allPaths.push([...thisPath]); } for (const [segment, childNode] of node.children) { - this.dfs(childNode, [...path, segment], allPaths); + this.dfs(childNode, [...thisPath, segment], allPaths); } } @@ -322,7 +321,7 @@ export async function createRoutesFile( logger, ['/*'].concat(includeExtends?.map((entry) => entry.pattern) ?? []), deduplicatedExcludePaths - .map((path) => `${prependForwardSlash(path.join('/'))}`) + .map((thisPath) => `${prependForwardSlash(thisPath.join('/'))}`) .slice( 0, CLOUDFLARE_COMBINED_LIMIT - @@ -337,11 +336,11 @@ export async function createRoutesFile( _config, logger, deduplicatedIncludePaths - .map((path) => `${prependForwardSlash(path.join('/'))}`) + .map((thisPath) => `${prependForwardSlash(thisPath.join('/'))}`) .concat(includeExtends?.map((entry) => entry.pattern) ?? []), includedPathsHaveWildcard ? deduplicatedExcludePaths - .map((path) => `${prependForwardSlash(path.join('/'))}`) + .map((thisPath) => `${prependForwardSlash(thisPath.join('/'))}`) .concat(excludeExtends?.map((entry) => entry.pattern) ?? []) : [], ); diff --git a/packages/integrations/cloudflare/test/astro-dev-platform.test.js b/packages/integrations/cloudflare/test/astro-dev-platform.test.js index f360b93a7..ab47e0aa4 100644 --- a/packages/integrations/cloudflare/test/astro-dev-platform.test.js +++ b/packages/integrations/cloudflare/test/astro-dev-platform.test.js @@ -18,7 +18,7 @@ describe('AstroDevPlatform', () => { }); }); - after((done) => { + after((_done) => { cli.kill(); }); diff --git a/packages/integrations/cloudflare/test/astro-env.test.js b/packages/integrations/cloudflare/test/astro-env.test.js index 6a45f4300..a20d20dd9 100644 --- a/packages/integrations/cloudflare/test/astro-env.test.js +++ b/packages/integrations/cloudflare/test/astro-env.test.js @@ -20,7 +20,7 @@ describe('astro:env', () => { // console.log('[stdout]', data.toString()); if (data.toString().includes('http://127.0.0.1:8788')) resolve(); }); - wrangler.stderr.on('data', (data) => { + wrangler.stderr.on('data', (_data) => { // console.log('[stderr]', data.toString()); }); }); diff --git a/packages/integrations/cloudflare/test/fixtures/compile-image-service/src/pages/blog/[...slug].astro b/packages/integrations/cloudflare/test/fixtures/compile-image-service/src/pages/blog/[...slug].astro index 82f3ce6a2..f5f8ed847 100644 --- a/packages/integrations/cloudflare/test/fixtures/compile-image-service/src/pages/blog/[...slug].astro +++ b/packages/integrations/cloudflare/test/fixtures/compile-image-service/src/pages/blog/[...slug].astro @@ -6,7 +6,6 @@ export const prerender = false; type Props = CollectionEntry<"blog">; -// biome-ignore lint/style/noNonNullAssertion: <explanation> const post = await getEntry("blog", Astro.params.slug!); if (!post) return Astro.rewrite("/404"); diff --git a/packages/integrations/cloudflare/test/module-loader.test.js b/packages/integrations/cloudflare/test/module-loader.test.js index 1f1e1c84d..a455ccdec 100644 --- a/packages/integrations/cloudflare/test/module-loader.test.js +++ b/packages/integrations/cloudflare/test/module-loader.test.js @@ -17,13 +17,13 @@ describe('CloudflareModuleLoading', () => { // console.log('[stdout]', data.toString()); if (data.toString().includes('http://127.0.0.1:8788')) resolve(); }); - wrangler.stderr.on('data', (data) => { + wrangler.stderr.on('data', (_data) => { // console.log('[stderr]', data.toString()); }); }); }); - after((done) => { + after((_done) => { wrangler.kill(); }); diff --git a/packages/integrations/cloudflare/test/with-solid-js.test.js b/packages/integrations/cloudflare/test/with-solid-js.test.js index b6194105e..465274422 100644 --- a/packages/integrations/cloudflare/test/with-solid-js.test.js +++ b/packages/integrations/cloudflare/test/with-solid-js.test.js @@ -17,13 +17,13 @@ describe('SolidJS', () => { // console.log('[stdout]', data.toString()); if (data.toString().includes('http://127.0.0.1:8788')) resolve(); }); - wrangler.stderr.on('data', (data) => { + wrangler.stderr.on('data', (_data) => { // console.log('[stderr]', data.toString()); }); }); }); - after((done) => { + after((_done) => { wrangler.kill(); }); diff --git a/packages/integrations/cloudflare/test/with-svelte.test.js b/packages/integrations/cloudflare/test/with-svelte.test.js index eb48b4b51..4f1e72a7d 100644 --- a/packages/integrations/cloudflare/test/with-svelte.test.js +++ b/packages/integrations/cloudflare/test/with-svelte.test.js @@ -17,13 +17,13 @@ describe('Svelte', () => { // console.log('[stdout]', data.toString()); if (data.toString().includes('http://127.0.0.1:8788')) resolve(); }); - wrangler.stderr.on('data', (data) => { + wrangler.stderr.on('data', (_data) => { // console.log('[stderr]', data.toString()); }); }); }); - after((done) => { + after((_done) => { wrangler.kill(); }); diff --git a/packages/integrations/cloudflare/test/with-vue.test.js b/packages/integrations/cloudflare/test/with-vue.test.js index 60e210750..8e7befae6 100644 --- a/packages/integrations/cloudflare/test/with-vue.test.js +++ b/packages/integrations/cloudflare/test/with-vue.test.js @@ -17,13 +17,13 @@ describe('Vue', () => { // console.log('[stdout]', data.toString()); if (data.toString().includes('http://127.0.0.1:8788')) resolve(); }); - wrangler.stderr.on('data', (data) => { + wrangler.stderr.on('data', (_data) => { // console.log('[stderr]', data.toString()); }); }); }); - after((done) => { + after((_done) => { wrangler.kill(); }); diff --git a/packages/integrations/cloudflare/test/wrangler-preview-platform.test.js b/packages/integrations/cloudflare/test/wrangler-preview-platform.test.js index a6a04892c..bf1fb5c47 100644 --- a/packages/integrations/cloudflare/test/wrangler-preview-platform.test.js +++ b/packages/integrations/cloudflare/test/wrangler-preview-platform.test.js @@ -18,13 +18,13 @@ describe('WranglerPreviewPlatform', () => { // console.log('[stdout]', data.toString()); if (data.toString().includes('http://127.0.0.1:8788')) resolve(); }); - wrangler.stderr.on('data', (data) => { + wrangler.stderr.on('data', (_data) => { // console.log('[stderr]', data.toString()); }); }); }); - after((done) => { + after((_done) => { wrangler.kill(); }); diff --git a/packages/integrations/node/src/log-listening-on.ts b/packages/integrations/node/src/log-listening-on.ts index f78b5b7f1..b7a9f0bf9 100644 --- a/packages/integrations/node/src/log-listening-on.ts +++ b/packages/integrations/node/src/log-listening-on.ts @@ -31,11 +31,9 @@ function getResolvedHostForHttpServer(host: string | boolean | undefined) { if (host === false) { // Use a secure default return 'localhost'; - // biome-ignore lint/style/noUselessElse: <explanation> } else if (host === true) { // If passed --host in the CLI without arguments return undefined; // undefined typically means 0.0.0.0 or :: (listen on all IPs) - // biome-ignore lint/style/noUselessElse: <explanation> } else { return host; } @@ -48,7 +46,6 @@ interface NetworkAddressOpt { // this code from vite https://github.com/vitejs/vite/blob/d09bbd093a4b893e78f0bbff5b17c7cf7821f403/packages/vite/src/node/utils.ts#L892-L914 export function getNetworkAddress( - // biome-ignore lint/style/useDefaultParameterLast: <explanation> protocol: 'http' | 'https' = 'http', hostname: string | undefined, port: number, @@ -58,12 +55,10 @@ export function getNetworkAddress( local: [], network: [], }; - // biome-ignore lint/complexity/noForEach: <explanation> Object.values(os.networkInterfaces()) .flatMap((nInterface) => nInterface ?? []) .filter( (detail) => - // biome-ignore lint/complexity/useOptionalChain: <explanation> detail && detail.address && (detail.family === 'IPv4' || |